all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Carlos Pita <carlosjosepita@gmail.com>
To: 37932@debbugs.gnu.org
Subject: bug#37932: [PATCH] Support hidpi fringes and images with Cairo
Date: Sat, 26 Oct 2019 03:43:38 -0300	[thread overview]
Message-ID: <CAELgYhe70fjMN7kKey6O=W+6Y=HznLz+hvdhkMTLzCZCofGBWQ@mail.gmail.com> (raw)
In-Reply-To: <CAELgYheLBih528b5i6m-6Emd+6EMS3dHL1e=km056B5TFLc4qw@mail.gmail.com>

Ok, the problem is that widget-image-insert (in wid-edit.el) is
directly inserting the image with insert-image, without creating the
spec with create-image first, so the spec doesn't get the :scale
property. Similarly, gamegrid.el is creating its own, unscaled, image
spec.

IMO there is something smelly in using the :scale attribute like
create-image does, scaling to compensate hidpi is a very different
concern than "application level" scaling.

Anyway, do you think that:

1. I should fix those two modules to use create-image or at least add :scale, or
2. put a mark to unscaled images so that they are always scaled at the
end in x_cr_draw_image, or
3. disable this auto :scale feature when the new low-level scaling
mechanism is on

?

I think I prefer 3.





  reply	other threads:[~2019-10-26  6:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26  2:17 bug#37932: [PATCH] Support hidpi fringes and images with Cairo Carlos Pita
2019-10-26  2:30 ` Carlos Pita
2019-10-26  6:01   ` Carlos Pita
2019-10-26  6:43     ` Carlos Pita [this message]
2019-10-26  8:05       ` Carlos Pita
2019-10-26  9:14         ` Eli Zaretskii
2019-10-26  9:18           ` Carlos Pita
2019-10-27  8:22           ` Robert Pluim
2019-10-27 17:08             ` Carlos Pita
2019-10-27 17:10               ` Carlos Pita
2024-01-10 22:15                 ` Stefan Kangas
2024-01-11 17:35                   ` Carlos Pita
2024-01-11 18:21                     ` Stefan Kangas
2024-01-11 18:38                       ` Carlos Pita
2024-01-11 19:31                         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAELgYhe70fjMN7kKey6O=W+6Y=HznLz+hvdhkMTLzCZCofGBWQ@mail.gmail.com' \
    --to=carlosjosepita@gmail.com \
    --cc=37932@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.