bug#18843: Invalid block indentation in Python mode

bug#18843: Invalid block indentation in Python mode

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Block indentation in Python mode often gives silly results. For example,
with 'emacs -q' create a Python buffer and type this:

def foo ():
    try:
        pass
    except:
        pass

Now 'C-x h TAB' gives something that is not valid at all:

def foo ():
    try:
        pass
except:
    pass

Note that if you go to the 'except:' line and press 'TAB', 'except:' is
indented back to its proper position. Further 'TAB's don't change this,
i.e. mode understands that it cannot place 'except:' at any other
indentation level.

Emacs version (just compiled):
GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.9) of
2014-10-26

Paul

[-- Attachment #2: Type: text/html, Size: 874 bytes --]

bug#18843:

[Carlos Pita]

This is a duplicate of my own report #18796.

Take a look at that report for a very simple fix.

Hope it gets commited soon.

bug#18843: Invalid block indentation in Python mode

[Fabián Ezequiel Gallina]

Fixed at 89ebffc in the emacs-24 branch.

`python-indent-region` region now follows saner approach, it uses
`python-indent-line` and skips special cases: namely block starts,
enders and dedenters.

The idea is that those mark the base indentation and stuff within them
could be re-indented.

I tested this approach in few large codebases and the results are quite
promising, in fact I found several bad indented stuff thanks to this.


PS: I unmerged this from #18796, it's not really the same thing.



Thanks for the report,
Fabián