From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#31764: 26.1; Point in VC change log is not centered as documented Date: Sat, 9 Jun 2018 11:18:10 -0300 Message-ID: References: <87vaatf5fn.fsf@gmail.com> <83k1r9t6ew.fsf@gnu.org> <83h8mdt4uq.fsf@gnu.org> <87sh5w245l.fsf@gmail.com> <83efhgtq25.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1528553830 31556 195.159.176.226 (9 Jun 2018 14:17:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Jun 2018 14:17:10 +0000 (UTC) Cc: 31764@debbugs.gnu.org, Noam Postavsky To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 09 16:17:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRefw-000879-GA for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 16:17:04 +0200 Original-Received: from localhost ([::1]:40474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRei3-00079r-CZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 10:19:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRehu-00079h-7k for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 10:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRehr-00025n-3l for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 10:19:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRehr-00025f-0T for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 10:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRehq-00060b-Ax for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jun 2018 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31764-submit@debbugs.gnu.org id=B31764.152855391723067 (code B ref 31764); Sat, 09 Jun 2018 14:19:02 +0000 Original-Received: (at 31764) by debbugs.gnu.org; 9 Jun 2018 14:18:37 +0000 Original-Received: from localhost ([127.0.0.1]:41417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRehR-0005zz-HT for submit@debbugs.gnu.org; Sat, 09 Jun 2018 10:18:37 -0400 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:42824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRehQ-0005zk-5Y for 31764@debbugs.gnu.org; Sat, 09 Jun 2018 10:18:36 -0400 Original-Received: by mail-io0-f176.google.com with SMTP id r24-v6so19050750ioh.9 for <31764@debbugs.gnu.org>; Sat, 09 Jun 2018 07:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d3JIpdyRreoGTnf3qpPeBcCs/gTMoLVCs2dyZWYNRcE=; b=nsx9YXAmp0HoGEbeNl50tTdXmDEBK+Mz5A+KlVQG8+EGRn54Rzwsi6cvPu6TnO2VjZ upSZrz4LdY7FXCyju5qjI1pbUUvHo+/e6HxZFZB2RqTTlFfL9sFWDGKBB5Ut7za4KwR+ KtqNaydrgmG7fy3kvkSGTeO9SB92P4ZJu2GEIMVt/XAMi6qv0GKHmi3pUYVBE5N86TCw V1jKS0CnW/7mX1Q3u3W0KR70Em65S5CpufHflQlYQP8YFiCw0Vtfm+0AkJOckEJeqEAZ 5hncJmx05A4hcEWlbTQFImRvCXlOY2IpvSWB6Lq/mZIQyuM+00bMK/G8BDR5Po+VGhBJ 2rRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d3JIpdyRreoGTnf3qpPeBcCs/gTMoLVCs2dyZWYNRcE=; b=rQrIrgj15hVBbUjByHtMrg9EIc8yAcUzOUj8EyWsNc4+LRacOfUavp803ac4SrbMNm Tr4jYmkvIOKphUx6DcrtedvjIMvGTZOqyRdKvKDpVBPHp0tZHVF86DezFmzTcOpUnAHL d1uSNlKh/Hn5O8GH0P4pmcaSke6CQ6squT/8frok1GHA5jtSQhyhOtiJ5JttncrFfx+D t6XuGFcJrOVFk9aU9MIaqaQRwafo3L1iHH/xiZI65T1KZch3o8vXecoDVIgPnvWQqVDi pfk0wAMnbB0WmkCutjEgbXCpFnk005bZKOP7UjbW0aYtkOfH41SwvD3sSCENfH4LGvmq Iz/A== X-Gm-Message-State: APt69E30tbvl/ymw2FTJ/GKogLILqg2rzcZq1B7MfoFkYQ3Z3NUvPKTG csj7TXLgk1v3x+W2wVA3h86lGhJ6Snao0NG94SU= X-Google-Smtp-Source: ADUXVKIFQlqYje0rOAuHuWfb5Uu4sZwpOyM7oZGcU8aKSKBAl3FmgcYXlHugB8Nll/xuxxH/CR38SG0qPwPiuYHrPiI= X-Received: by 2002:a6b:de14:: with SMTP id v20-v6mr8983733iog.260.1528553910366; Sat, 09 Jun 2018 07:18:30 -0700 (PDT) Original-Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Sat, 9 Jun 2018 07:18:10 -0700 (PDT) In-Reply-To: <83efhgtq25.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147245 Archived-At: Sadly it doesn't improve matters, Eli. Below I'm repeating the conclusions of my debugging session in a more orderly fashion: 1) `C-x v l` is bound to vc-print-log 2) vc-print-log takes an optional working-revision argument. When called with a prefix argument, working-revision is prompted for. 3) In both cases (prompted or not) the default value for this argument is nil. 4) vc-print-log calls (vc-print-log-internal backend files working-revision nil limit) 5) Then vc-print-log-internal calls vc-log-internal-common. 6) This last function takes a goto-location-func argument that the caller is passing as the result of: ;; When it's nil, point really shouldn't move (bug#15322). (when working-revision (lambda (bk) (vc-call-backend bk 'show-log-entry working-revision))) that is, nil by default. 7) vc-log-internal-common only moves the point when goto-location-func is not nil: (when goto-location-func (funcall goto-location-func backend) (setq vc-sentinel-movepoint (point))) So I'm really failing to see how this could work at all. Besides, there is the point that this advice, that changes the nil default for the working version of the current buffer, makes it work as documented: (advice-add 'vc-print-log :filter-args (lambda (args) (cons (or (car args) (and (buffer-file-name) (vc-working-revision (buffer-file-name)))) (cdr args))))