From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#31884: 26.1.50; Wrong icon in gtk tooltips Date: Mon, 18 Jun 2018 22:03:58 -0300 Message-ID: References: <87a7rsneb2.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000003c1c7056ef4433e" X-Trace: blaine.gmane.org 1529370184 6070 195.159.176.226 (19 Jun 2018 01:03:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Jun 2018 01:03:04 +0000 (UTC) To: 31884@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 19 03:03:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV52x-0001TY-VK for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jun 2018 03:03:00 +0200 Original-Received: from localhost ([::1]:38258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV555-0000fu-9K for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 21:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV54x-0000fo-HR for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:05:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV54w-0006bX-LM for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:05:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV54w-0006bR-HP for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fV54w-0004Fp-9i for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jun 2018 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31884 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152937026916307 (code B ref -1); Tue, 19 Jun 2018 01:05:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Jun 2018 01:04:29 +0000 Original-Received: from localhost ([127.0.0.1]:55567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV54P-0004Ex-Ej for submit@debbugs.gnu.org; Mon, 18 Jun 2018 21:04:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV54O-0004Em-9i for submit@debbugs.gnu.org; Mon, 18 Jun 2018 21:04:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV54I-0006E9-5n for submit@debbugs.gnu.org; Mon, 18 Jun 2018 21:04:23 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:47361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fV54I-0006E5-1X for submit@debbugs.gnu.org; Mon, 18 Jun 2018 21:04:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV54G-0000YD-Sj for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:04:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV54G-0006DM-0t for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:04:20 -0400 Original-Received: from mail-it0-x22d.google.com ([2607:f8b0:4001:c0b::22d]:38388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV54F-0006D7-RY for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 21:04:19 -0400 Original-Received: by mail-it0-x22d.google.com with SMTP id v83-v6so14791753itc.3 for ; Mon, 18 Jun 2018 18:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=FwLUY5agYWfLYPPtSUuVesH5ZvaEc/JRD5/7iUFB9Sk=; b=pXfo/bnzANG/kAdkyrcX0vOr0b5UxT+Sr+4qzKB0GWTjsuyDrQ2817XthNCrc6qhdI vthQ71NS3aXvWlVyQ8vCfOdgQcnTCgduoWkIqeFLjCwnFceDv9D5yYzqd6mmUInwthJi r8CtIe74IA40V4Ni879TRA/h23+fbGaISQ260Ufs7Rkl4Tp2vLPfX78htM+UdRxpjtXk Kx3DBun211iS74WR7HM3/LxtXujQN+lQiu+W4Cv5ZAK87Z8USUrjZADdLhMt6NYV2DRH gljnxPAwLki3/L3JfXAAFR0yWj5qwEAq2IoEUQKpzDwaTkr0b+nN06f7WeUsXyqYX0od PIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=FwLUY5agYWfLYPPtSUuVesH5ZvaEc/JRD5/7iUFB9Sk=; b=fPFsBOtbYEtjrOe0bShoDoYhPP4ETU+0evyg5JRCI/MB0kt7isCZwP8Hdb8j5BT0oL hS9uJi75mc/BxexsiZlrn0ONOxsElLeRbW/foqg94yXWUtzXp1Nqmbp4au/cuYkm3kpt +Yyw4qS+wTeFIVV/c4vy8eAXWBt691ngIKVQ2pKWqiv2p9tE7M/KLHdI/sfxZ8bC6vDm gQ95/vXu0sAZsxtbd6pSw2jleUr1k4VPcHe2PLKJKyXQdhNpdBD1uMVZREFgs6dxgk5F V9f4vhzjMPoHXTtICsdZ0x11dJxslCmEMYNzp3cFwpF5VSw+Ec95O83WDWloAyFy0aCw uSfw== X-Gm-Message-State: APt69E010E+fpzY2FZg9mgmYg0/Oys3WQjnVlnunla97/f/shSGwJsQM AuKDjgDzceFFMNRKauW2QLoshaxWKQ6fRuzNuV0= X-Google-Smtp-Source: ADUXVKIs8gK2aut7OpznsAfjo2Cc3KlktOQYdZLMu/h2/ROVUpg5JtPu8Gh2DtehkYoPl1qVPUQV6qci6u+2C6MbhGs= X-Received: by 2002:a24:e44a:: with SMTP id o71-v6mr11213378ith.86.1529370258935; Mon, 18 Jun 2018 18:04:18 -0700 (PDT) Original-Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 18:03:58 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147616 Archived-At: --00000000000003c1c7056ef4433e Content-Type: text/plain; charset="UTF-8" Tags: patch This was a hard one to find... The problem is in gtkutil.c xg_show_tooltip: gtk_widget_show_all makes the icon that comes by default with a tooltip visible, which is undesirable since that icon was never set. The fix is to simply use gtk_widget_show. Attached is a python script that reproduces the behavior, trying to mimic the real emacs code. The first time you press the button show is called and the tooltip has no icon, as expected. The second time show_all is called and the missing icon problem manifests. If you keep pressing the button show and show_all alternate, but the missing icon is still there since it has been made visible forever by the first show_all call. --00000000000003c1c7056ef4433e Content-Type: text/x-python; charset="US-ASCII"; name="tooltip.py" Content-Disposition: attachment; filename="tooltip.py" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jikzidd50 aW1wb3J0IGdpCmdpLnJlcXVpcmVfdmVyc2lvbigiR3RrIiwgIjMuMCIpCmZyb20gZ2kucmVwb3Np dG9yeSBpbXBvcnQgR3RrICAjIG5vcWEKCgpjbGFzcyBBcHAoR3RrLldpbmRvdyk6CgogICAgZGVm IF9faW5pdF9fKHNlbGYpOgogICAgICAgIHN1cGVyKCkuX19pbml0X18oKQogICAgICAgIHNlbGYu dGlwID0gc2VsZi50aXBfd2luID0gc2VsZi50aXBfbGJsID0gTm9uZQogICAgICAgIHNlbGYuYWxs ID0gRmFsc2UKICAgICAgICBzZWxmLnNldF9zaXplX3JlcXVlc3QoMjUwLCAyMDApCiAgICAgICAg c2VsZi5zZXRfdG9vbHRpcF90ZXh0KCdIaScpCiAgICAgICAgc2VsZi5jb25uZWN0KCJkZXN0cm95 IiwgR3RrLm1haW5fcXVpdCkKICAgICAgICBzZWxmLmNvbm5lY3QoInF1ZXJ5LXRvb2x0aXAiLCBz ZWxmLl90aXBfY2IpCgogICAgICAgIGZpeGVkID0gR3RrLkZpeGVkKCkKICAgICAgICBzZWxmLmFk ZChmaXhlZCkKICAgICAgICBidXR0b24gPSBHdGsuQnV0dG9uKCJCdXR0b24iKQogICAgICAgIGJ1 dHRvbi5zZXRfc2l6ZV9yZXF1ZXN0KDgwLCAzNSkKICAgICAgICBmaXhlZC5wdXQoYnV0dG9uLCA1 MCwgNTApCiAgICAgICAgYnV0dG9uLmNvbm5lY3QoImNsaWNrZWQiLCBzZWxmLl9zaG93X3RpcCkK CiAgICAgICAgc2VsZi5zaG93X2FsbCgpCgogICAgZGVmIF90aXBfY2Ioc2VsZiwgdG9wX3dpbiwg eCwgeSwgeHQsIHRpcCk6CiAgICAgICAgaWYgc2VsZi50aXBfd2luIGlzIE5vbmU6CiAgICAgICAg ICAgIHRvcF93aW4uc2V0X3Byb3BlcnR5KCJoYXMtdG9vbHRpcCIsIEZhbHNlKQogICAgICAgICAg ICBzZWxmLnRpcCA9IHRpcAogICAgICAgICAgICBzZWxmLnRpcF9sYmwgPSBHdGsuTGFiZWwoIlRv cCB3aW5kb3cgdGlwIikKICAgICAgICAgICAgc2VsZi50aXAuc2V0X2N1c3RvbShzZWxmLnRpcF9s YmwpCiAgICAgICAgICAgIHNlbGYudGlwX3dpbiA9IHNlbGYudGlwX2xibC5nZXRfdG9wbGV2ZWwo KQogICAgICAgIHJldHVybiBGYWxzZQoKICAgIGRlZiBfc2hvd190aXAoc2VsZiwgXyk6CiAgICAg ICAgaWYgc2VsZi50aXAgaXMgTm9uZToKICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgc2VsZi50 aXAuc2V0X2N1c3RvbShzZWxmLnRpcF9sYmwpCiAgICAgICAgaWYgc2VsZi5hbGw6CiAgICAgICAg ICAgIHNlbGYudGlwX3dpbi5zaG93X2FsbCgpCiAgICAgICAgZWxzZToKICAgICAgICAgICAgc2Vs Zi50aXBfd2luLnNob3coKQogICAgICAgIHNlbGYuYWxsID0gbm90IHNlbGYuYWxsCgppZiBfX25h bWVfXyA9PSAiX19tYWluX18iOgogICAgcHlhcHAgPSBBcHAoKQogICAgR3RrLm1haW4oKQo= --00000000000003c1c7056ef4433e--