From: Carlos Pita <carlosjosepita@gmail.com>
To: 32344@debbugs.gnu.org
Subject: bug#32344:
Date: Wed, 12 Sep 2018 14:04:15 -0300 [thread overview]
Message-ID: <CAELgYhcWWNF6CP-5v=Bz-7TfUDcc8vU0=O94n9Wx5h64ceMYcQ@mail.gmail.com> (raw)
In-Reply-To: <87h8kdwro4.fsf@gmail.com>
Recently I've had some exchange with elpy maintainer and he said he
would be glad to support full history fontification for python mode
but he didn't want to add my advice (its final version is quoted
below) to elpy in order to instrument comint-send-input, so for now we
just have a wiki-level DIY solution. Now, I fully understand his
concern, so is there any interest in adding this option to comint? It
seems quite simple a change and it will allow inferior modes to fully
colorize their history, which is a rather nice feature. In case there
is any interest I could submit a patch.
---
(advice-add 'comint-send-input
:around (lambda (f &rest args)
(if (eq major-mode 'inferior-python-mode)
(cl-letf ((g (symbol-function 'add-text-properties))
((symbol-function 'add-text-properties)
(lambda (start end properties
&optional object)
(unless (eq (nth 3 properties)
'comint-highlight-input)
(funcall g start end
properties object)))))
(apply f args))
(apply f args))))
next prev parent reply other threads:[~2018-09-12 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 0:14 bug#32344: 26.1; Option to avoid comint highlighting input Carlos Pita
2018-08-02 1:19 ` bug#32344: Carlos Pita
2018-09-12 17:04 ` Carlos Pita [this message]
2018-09-17 16:36 ` bug#32344: (no subject) Jörg Behrmann
2019-10-13 17:18 ` bug#32344: Carlos Pita
2019-10-13 18:36 ` bug#32344: Carlos Pita
2019-10-13 19:23 ` bug#32344: Carlos Pita
2019-10-13 19:24 ` bug#32344: Carlos Pita
2019-10-13 21:53 ` bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Carlos Pita
2019-10-21 20:39 ` Carlos Pita
2020-08-10 12:51 ` Lars Ingebrigtsen
2020-08-19 11:11 ` Lars Ingebrigtsen
2019-10-20 15:57 ` bug#32344: Juri Linkov
2019-10-14 17:16 ` bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Gaby Launay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-21 20:53 ` bug#32344: Add option to keep colorization in comint, use it in python.el Carlos Pita
2019-10-22 18:25 ` Carlos Pita
2019-10-22 20:37 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELgYhcWWNF6CP-5v=Bz-7TfUDcc8vU0=O94n9Wx5h64ceMYcQ@mail.gmail.com' \
--to=carlosjosepita@gmail.com \
--cc=32344@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.