bug#19696: Acknowledgement (24.4; python.el: blank line eldoc error)

[Carlos Pita <carlosjosepita@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

X-Debbugs-CC: galli.87@gmail.com
Tags: patch

Advising eldoc-documentation-function sometimes resulted in a function
void symbol error. I don't know exactly why but the fact is that
eldoc-print-current-symbol-info error handler ended up printing "eldoc
error: ...". Anyway the approach seems to me a bit contorted so I
replaced the advice by a more conventional local variable and it seems
to work fine now.

[-- Attachment #2: eldoc.patch --]
[-- Type: text/x-patch, Size: 671 bytes --]

diff --git a/.emacs.d/lisp/python.el b/.emacs.d/lisp/python.el
index ce9ed96..4c8f4c6 100644
--- a/.emacs.d/lisp/python.el
+++ b/.emacs.d/lisp/python.el
@@ -4707,8 +4707,8 @@ Arguments START and END narrow the buffer region to work on."
                                                  (current-column))))
          (^ '(- (1+ (current-indentation))))))
 
-  (add-function :before-until (local 'eldoc-documentation-function)
-                #'python-eldoc-function)
+  (set (make-local-variable 'eldoc-documentation-function)
+       #'python-eldoc-function)
 
   (add-to-list 'hs-special-modes-alist
                `(python-mode "\\s-*\\(?:def\\|class\\)\\>" nil "#"