From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter Mao Newsgroups: gmane.emacs.tangents Subject: Re: Continuous scroll for pdf-tools Date: Tue, 4 Jul 2023 22:59:45 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000002b78705ffb71c7f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15690"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry M To: emacs-tangents@gnu.org, orzodk@fastmail.com, rahguzar@zohomail.eu Original-X-From: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Wed Jul 05 13:13:35 2023 Return-path: Envelope-to: get-emacs-tangents@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qH0Ry-0003tA-N7 for get-emacs-tangents@m.gmane-mx.org; Wed, 05 Jul 2023 13:13:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qH0Rl-0001i7-JN; Wed, 05 Jul 2023 07:13:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGvYa-0003yd-7R for emacs-tangents@gnu.org; Wed, 05 Jul 2023 02:00:04 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGvYW-0001pH-G8 for emacs-tangents@gnu.org; Wed, 05 Jul 2023 02:00:03 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4fa48b5dc2eso10229552e87.1 for ; Tue, 04 Jul 2023 22:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688536798; x=1691128798; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=mopLPE6f2sIQnh2Xtsitw9Hu7zKWszT/wVipLOqbgeg=; b=Bxx2ECC7JNwivke7WzaGlJCt1abbOI1b/ruI4F2mLDRGdiAoBRM7ersUP6fDgMRUrT iAYD08WvdaE9gYICaXUXT1KfQftATxKwb2pLU5dDi/E3aO3uqbwpPqZxzuCWm9Pclcbl mAgu2ejO9GCqnigQb6Zr5jEME/aKq1N3aLNJGdZE4egpH16TZS04dHTE/lBggZKT7Xpu nvm4mGOg+u/VVN801Bekvc+hPsfhINb1tATz7DT/2z1KdqSySC2Uxj/d1I/2xTTBD7P5 8lqDLSQC4F2wDMACB+OdfXDswNiCFfoyPV3xFlSf7d0w++9Aa4DCCTKDHljTc0xLpoS0 xsHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688536798; x=1691128798; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mopLPE6f2sIQnh2Xtsitw9Hu7zKWszT/wVipLOqbgeg=; b=AMltIFvhZaV+2EM3TqukTpaQFuqhuMKmcTPzOl8MGVMRSmAyNAWDsRc4uxUJ5qxVQh VBms/kSVf7joFO4Xnx84oLqwy9vsfntYvIv/uhlCxleYC8SRd2i2AmSPf52G883aFYyD yYX4UlljZ1xF19QLXmtxnF3v1OTzsc/ToIGIdwaVcT2LxJ5xjDdce0t9TQvQZWMc0ukN hKGXqdeiiIMeuVkD7ew2o4/KzyypkAKi3bVg44dFE3Ezk6dxaFvoVbkO58MPG1T5gcvR uRIQQ5eWYYfNi1lBbUd3zw1Gi88uYSL5xmeMnNwEQAo/LgODqPfrUFcCfzqNJ9GTfTtR JlAA== X-Gm-Message-State: ABy/qLa6yUaU7AvC+EXmGsa3HsEt1uPbMCeHGxGGUArbRYS6+yQDDgEu OYwmbIlgcHULJ/FTQuP7tSNfjQoov8Q6/aLwdFL7GomoHX4= X-Google-Smtp-Source: APBJJlGX3EtX5salpFgNpkwEf9f1DTc6+Xyg/esS9amBr5H7kmyeyDvhEaKC6iXv4AAptbe59lFCXwd7IjMgq6haxx0= X-Received: by 2002:a05:6512:308a:b0:4fb:89bb:bcc4 with SMTP id z10-20020a056512308a00b004fb89bbbcc4mr12393378lfd.51.1688536797590; Tue, 04 Jul 2023 22:59:57 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=peter.mao@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 05 Jul 2023 07:13:20 -0400 X-BeenThere: emacs-tangents@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Emacs news and miscellaneous discussions outside the scope of other Emacs mailing lists List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Original-Sender: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.tangents:1031 Archived-At: --00000000000002b78705ffb71c7f Content-Type: text/plain; charset="UTF-8" > > Rahguzar writes: > > > If you have wanted this functionality, please try the my fork of > > image-roll which is hosted at, > > > > https://github.com/aikrahguzar/image-roll.el > > > > together with the continuous scroll branch of my pdf-tools fork > > > > https://github.com/aikrahguzar/pdf-tools/tree/continuous-scroll > > > > and report back your experience and even better fixes for any problems > > you encountered. > > Thanks for this! One of my pet peeves with pdf-tools (+ org-noter) on a > smaller screen was accidentally scrolling just a bit too far and having > it replace the page. Your packages so far have solved this problem for > me. > > I'll be using these packages from now on and I'll be sure to report back > if I run into any problems. > Dmitry and I are maintainers of org-noter. I haven't tried your code yet, but I think the feature is important for pdf-tools and if it gets integrated into pdf-tools, I'd like to ensure that org-noter works well with it. Rahguzar -- are you going to be making pull-requests to the upstream repos? I notice that you are a fork of a fork of the "official" pdf-tools repo (vedang/pdf-tools), and your code has diverged significantly from vedang/pdf-tools (96 ahead/44 behind). Since vedang/pdf-tools is under active maintainership, I think the best course of action is to make a PR (or a series of PRs, as it looks like you've done a **lot** of work on this feature). Orzodk -- Please consider opening an issue at https://github.com/org-noter/org-noter/issues to communicate/log what you find with these packages. Although this looks very interesting to me, I don't have the bandwidth to dive into it. Peter --00000000000002b78705ffb71c7f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Rahguzar= <rahguzar@zohomail.eu> w= rites:

> If you have wanted this functionality, please try the my= fork of
> image-roll which is hosted at,
>
> https://github.com/aikrahguza= r/image-roll.el
>
> together with the continuous scroll bra= nch of my pdf-tools fork
>
> https://github.com/aikrahguzar/pd= f-tools/tree/continuous-scroll
>
> and report back your exp= erience and even better fixes for any problems
> you encountered.
=
Thanks for this! One of my pet peeves with pdf-tools (+ org-noter) on a=
smaller screen was accidentally scrolling just a bit too far and having=
it replace the page. Your packages so far have solved this problem for<= br>me.

I'll be using these packages from now on and I'll be = sure to report back
if I run into any problems.
Dmitry and I are maintainers of org-noter.=C2=A0 I haven't= tried your code yet, but I think the feature is important for pdf-tools an= d if it gets integrated into pdf-tools, I'd like to ensure that org-not= er works well with it.

Rahguzar -- are you goi= ng to be making pull-requests to the upstream repos?=C2=A0 I notice that yo= u are a fork of a fork of the "official" pdf-tools repo (vedang/p= df-tools), and your code has diverged significantly from vedang/pdf-tools (= 96 ahead/44 behind).=C2=A0 Since vedang/pdf-tools is under active maintaine= rship, I think the best course of action is to make a PR (or a series of PR= s, as it looks like you've done a **lot** of work on this feature).

Orzodk -- Please consider opening an issue at https://github.com/org-n= oter/org-noter/issues to communicate/log what you find with these packa= ges.

Although this looks very interesting to me, I= don't have the bandwidth to dive into it.

Pet= er
--00000000000002b78705ffb71c7f--