From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Kristoffer_Gr=C3=B6nlund?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Sun, 28 Feb 2016 08:13:33 +0000 Message-ID: References: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> <87egbxid4e.fsf@gmail.com> <87y4a5s6cv.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11402028526f5b052cd01cf2 X-Trace: ger.gmane.org 1456647253 10251 80.91.229.3 (28 Feb 2016 08:14:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2016 08:14:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen , Mitchel Humpherys Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 28 09:14:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZwUQ-00048G-K4 for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 09:14:06 +0100 Original-Received: from localhost ([::1]:57930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZwUP-0007AF-Hb for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 03:14:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZwU9-0007A6-36 for emacs-devel@gnu.org; Sun, 28 Feb 2016 03:13:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZwU5-0006ur-5Y for emacs-devel@gnu.org; Sun, 28 Feb 2016 03:13:49 -0500 Original-Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:36000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZwU4-0006uk-Qm for emacs-devel@gnu.org; Sun, 28 Feb 2016 03:13:45 -0500 Original-Received: by mail-lf0-x236.google.com with SMTP id l83so27638629lfd.3 for ; Sun, 28 Feb 2016 00:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koru-se.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pyczNaZPCCa3m0gTN+olrb5ad7hehkzYAQy459RUpzQ=; b=Vc8DWoEgXLZGN/JjKcsuJDZ2xl4NQ9uuXeBZHjCj2yjQvBDQWj84Y7NoF7F9bqVTlU xaLDvZbb75lUJpGO6k9bjdofd8ohJT9IDzzvSdHWcv1fUgIgqJaviSlEylnG5+nauKaY 82b54qCNFo7rToVfF0rbqGIE17LxJsTaKG4ZdI7cEDbzrYzc6gSPAipcppBVzCzxyU5G 4FN5nievKdwCxA9u8eATO2pW+gT7//phz0NNwMs9X4RzBXyn9ENHTw33Sh5SgikzUJ3e ncqZM55hL1ze8E4xNoojk9zdJO3LlmZnyx3xtn34FE8LmgboK15S5msvdP7+o7gw+mir wUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pyczNaZPCCa3m0gTN+olrb5ad7hehkzYAQy459RUpzQ=; b=cbSM9hz5QlcR6mADVBgJMGhuvngV+MllOlFDeKqY9nfXd4mTQtvBuHy4FIWziDe+sL OBlrziOA5PCn3oO7IGda6nkr0QQmWmm17Aepeu7HEcDqti24+HGp8470yk7pSBrgclW+ iYssmBaVMAynORrDAjV62UHgGaq5aoovRWXS6xQUeHMZ7jHvYgV45VoEHw7vriQAuzZb dWFgeO4dihErAtC4J+tIbdrovEtmcr9DbKKfpZq3O8EllXtstGngPf7+03DHPQX8O5bZ +dyANi/wkf9TdUvhUa59CdO2MWYF/R7ig0Tu8qdKEmXs9tY+cSvFouGK/P4hV1WRZ0Wy ThYQ== X-Gm-Message-State: AD7BkJJ3/I+F0V8+exr9qC+FRwKHJwn1GpEgnZB4pVoc2HqTVVPnHPjFfTMxs2Dkdmj9xK1w65/uSBvYkbYLQA== X-Received: by 10.25.159.68 with SMTP id i65mr3461293lfe.94.1456647223530; Sun, 28 Feb 2016 00:13:43 -0800 (PST) In-Reply-To: <87y4a5s6cv.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200746 Archived-At: --001a11402028526f5b052cd01cf2 Content-Type: text/plain; charset=UTF-8 Sounds good to me too. On Sun, 28 Feb 2016 07:21 Lars Ingebrigtsen, wrote: > Mitchel Humpherys writes: > > > On Mon, Feb 22 2016 at 05:04:31 PM, Mitchel Humpherys > > wrote: > >> Setting a foreground color on the `region' face is slightly annoying. > >> This is subjective, of course, but the consensus among other themes and > >> around the web is to *not* set a foreground color on the region face. > > > > Any objections to this? I should have mentioned that the reason it's > > slightly annoying is because setting a foreground color hides existing > > syntax highlighting within the region text. > > The patch sounds OK to me. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --001a11402028526f5b052cd01cf2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Sounds good to me too.


On Sun, 28 Feb 2016 07:21 L= ars Ingebrigtsen, <larsi@gnus.org&= gt; wrote:
Mitchel Humpherys <mitch.special@gm= ail.com> writes:

> On Mon, Feb 22 2016 at 05:04:31 PM, Mitchel Humpherys
> <mitch= .special@gmail.com> wrote:
>> Setting a foreground color on the `region' face is slightly an= noying.
>> This is subjective, of course, but the consensus among other theme= s and
>> around the web is to *not* set a foreground color on the region fa= ce.
>
> Any objections to this?=C2=A0 I should have mentioned that the reason = it's
> slightly annoying is because setting a foreground color hides existing=
> syntax highlighting within the region text.

The patch sounds OK to me.

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--001a11402028526f5b052cd01cf2--