Re: PR: dired-do-create-files now checks for trailing slashes in the target

[Rudi C <rudiwillalwaysloveyou@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1578 bytes --]

Okay, I have attached a new patch (no need for the previous patches).

PS: I inserted newlines into the docstring to make the lines shorter, but
this makes the docstring ugly to view (as it is essentially hardwrapping
based on an arbitrary column size that the user's screen will not share).

On Tue, Nov 2, 2021 at 6:45 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Rudi C <rudiwillalwaysloveyou@gmail.com>
> > Date: Tue, 2 Nov 2021 18:38:08 +0330
> > Cc: Eli Zaretskii <eliz@gnu.org>, Tassilo Horn <tsdh@gnu.org>, Stefan
> Kangas <stefankangas@gmail.com>,
> >       emacs-devel@gnu.org
> >
> > +(defcustom dired-create-destination-dirs-trailing-separator-special nil
>
> This variable's name is a mouthful; please let's find a shorter name.
>
> > +  "If t, when selecting a single destination in Dired, paths that end
> in a path separator will be treated as a non-existent directory, and acted
> on according to `dired-create-destination-dirs'.
> > +
> > +This option is only relevant if `dired-create-destination-dirs' is not
> `nil', and you are moving/copying a single directory.
> > +
> > +For example, when renaming a directory named `old_name' to `new_name/'
> (note the trailing path separator), `new_name' might be created depending
> on `dired-create-destination-dirs' and `old_name' will be moved into it if
> it is created; Otherwise `old_name' will be directly renamed to `new_name'."
> > +  :type '(choice (const :tag "Do not treat paths with a trailing path
> separator specially" nil)
>
> These lines are too long; please divide them into shorter lines.
>

[-- Attachment #1.2: Type: text/html, Size: 2363 bytes --]

[-- Attachment #2: 0001-Added-dired-create-dirs-trailing-separator.patch --]
[-- Type: application/octet-stream, Size: 2294 bytes --]

From 3dfea8f43a45473138d9d3d9716658390957b494 Mon Sep 17 00:00:00 2001
From: NightMachinary <rudiwillalwaysloveyou@gmail.com>
Date: Tue, 9 Nov 2021 16:19:45 +0330
Subject: [PATCH] Added: dired-create-dirs-trailing-separator

---
 lisp/dired-aux.el | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index ef299b21fd..064d9eba8d 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1789,6 +1789,25 @@ If `ask', ask for user confirmation."
   :group 'dired
   :version "27.1")
 
+(defcustom dired-create-dirs-trailing-separator nil
+  "If t, when selecting a single destination in Dired,
+paths that end in a path separator will be treated as a non-existent directory,
+and acted on according to `dired-create-destination-dirs'.
+
+This option is only relevant if `dired-create-destination-dirs' is not `nil',
+and you are moving/copying a single directory.
+
+For example, when renaming a directory named `old_name' to `new_name/'
+(note the trailing path separator), `new_name' might be created depending on
+`dired-create-destination-dirs' and `old_name' will be moved into it
+if it is created; Otherwise `old_name' will be directly renamed to `new_name'."
+  :type '(choice
+          (const :tag
+                 "Do not treat paths with a trailing path separator specially" nil)
+          (const :tag "Treat paths with a trailing path separator specially" t))
+  :group 'dired
+  :version "28.1")
+
 (defun dired-maybe-create-dirs (dir)
   "Create DIR if doesn't exist according to `dired-create-destination-dirs'."
   (when (and dired-create-destination-dirs (not (file-exists-p dir)))
@@ -2157,7 +2176,12 @@ Optional arg HOW-TO determines how to treat the target.
 		     target-dir op-symbol arg rfn-list default))))
 	 (into-dir
           (progn
-            (unless dired-one-file (dired-maybe-create-dirs target))
+            (when
+                (or
+                 (not dired-one-file)
+                 (and dired-create-dirs-trailing-separator
+                      (directory-name-p target)))
+              (dired-maybe-create-dirs target))
             (cond ((null how-to)
 		   ;; Allow users to change the letter case of
 		   ;; a directory on a case-insensitive
-- 
2.33.1