From: Gustav Broberg <gustav.broberg@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: michael@mauger.com, Eli Zaretskii <eliz@gnu.org>, 66983@debbugs.gnu.org
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Date: Fri, 15 Dec 2023 11:05:54 +0100 [thread overview]
Message-ID: <CAE4h+g3zMxYEy73p7REoqhTqeLEUUH_Mk+j78nNt_6=hWUyteA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
On Fri, Dec 15, 2023 at 2:28 AM Stefan Kangas <stefankangas@gmail.com>
wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Ping! Michael, can you please look into this?
> >
> >> Cc: 66983@debbugs.gnu.org
> >> Date: Fri, 10 Nov 2023 14:06:20 +0200
> >> From: Eli Zaretskii <eliz@gnu.org>
> >>
> >> > From: Gustav Broberg <gustav.broberg@gmail.com>
> >> > Date: Fri, 10 Nov 2023 10:41:03 +0100
> >> >
> >> > Patch for changing sql.el sqlite's prompt-cont-regexp to be
> compatible with SQLite 3.41.0.
> >>
> >> Thanks.
> >>
> >> Michael, any comments or suggestions?
>
> It would be nice to get this fixed already in Emacs 29.2, given that
> SQLite is so common.
>
> FWIW, if Michael doesn't have time to look into this, the patch seems to
> make sense. It just allows a few more prompts that weren't allowed
> before.
>
> At the same time, if these are indeed the only allowed prompts:
>
> ...>
> ` ...>
> ' ...>
> " ...>
> /* ...>
> (xN...> (where N is 1 to 9)
> (.....>
> )x!...>
>
> we could probably make something a bit more strict. Where do we find
> the documentation for that though? Gustav, where is that from?
>
Thanks,
Not sure if it was clear, but the regexp in my actual patch is more strict
than in my first email: ^[`'\"/() ][x*. ][1-9!. ]\\.\\.\\.>
Unfortunately I've found no documentation listing the continuation prompts
– I derived this list by inspecting the sqlite source code. For example:
https://github.com/sqlite/sqlite/blob/e98238561911f85e54af3e6f26e47c2de8d1cda1/src/shell.c.in#L583-L611
-- Gustav
[-- Attachment #2: Type: text/html, Size: 2520 bytes --]
prev parent reply other threads:[~2023-12-15 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:20 bug#66983: 29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0 Gustav Broberg
2023-11-10 9:41 ` bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt Gustav Broberg
2023-11-10 12:06 ` Eli Zaretskii
2023-11-25 9:26 ` Eli Zaretskii
2023-12-15 1:28 ` Stefan Kangas
2023-12-15 8:39 ` Eli Zaretskii
2023-12-15 10:05 ` Gustav Broberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4h+g3zMxYEy73p7REoqhTqeLEUUH_Mk+j78nNt_6=hWUyteA@mail.gmail.com' \
--to=gustav.broberg@gmail.com \
--cc=66983@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael@mauger.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.