From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Laurence Warne Newsgroups: gmane.emacs.bugs Subject: bug#59307: [PATCH] Cancel proced auto update timer if no proced buffers are open Date: Sun, 20 Nov 2022 11:18:17 +0000 Message-ID: References: <83o7t16hha.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000001edb0605ede51909" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59307@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 12:19:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owiM3-0009xc-Hu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 12:19:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owiLs-0007Q2-8v; Sun, 20 Nov 2022 06:19:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owiLm-0007N9-VI for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 06:19:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owiLm-0000Od-Fb for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 06:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owiLl-0007AM-Vu for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 06:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Laurence Warne Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 11:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59307 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59307-submit@debbugs.gnu.org id=B59307.166894311727512 (code B ref 59307); Sun, 20 Nov 2022 11:19:01 +0000 Original-Received: (at 59307) by debbugs.gnu.org; 20 Nov 2022 11:18:37 +0000 Original-Received: from localhost ([127.0.0.1]:42474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owiLM-00079g-NR for submit@debbugs.gnu.org; Sun, 20 Nov 2022 06:18:37 -0500 Original-Received: from mail-ua1-f48.google.com ([209.85.222.48]:33361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owiLJ-00079S-Tb for 59307@debbugs.gnu.org; Sun, 20 Nov 2022 06:18:36 -0500 Original-Received: by mail-ua1-f48.google.com with SMTP id 97so3189973uam.0 for <59307@debbugs.gnu.org>; Sun, 20 Nov 2022 03:18:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fEbt2+8xHjwAObL+wCtVUxWi6MLKWw4zvxKrXEysPYk=; b=V39QlU892aPa8dJ9mPc7/tikRo+ADXClnOEN+Oo5InCgMj+pGXXPjkr0Cmw2CbrGDB WFn7woLNCx0ybo7MZmEhsSJ3fAkOSt5yBs0A8no1nCFAtKbGHe7VrAXEvyiJx8O5nMqD 2H3f3UYUuVqIt2zYX+k2er9gwkRybyO3vOqysCCCHFRMpbhQTGr3HvOkVwtaZltRONud 2Cz30YmAdtJG5htcLCJxIjCssM3wpO4DrsHwoducx6j/ZLOREh1h9yvRJ27sTFdsm7Bm 1fKvgoTcc2y2+z9RzpGIPcJvINWoeRrISUZJ7aN59aABkAqdTGJBlzWth9NamJWWaz/u o/Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fEbt2+8xHjwAObL+wCtVUxWi6MLKWw4zvxKrXEysPYk=; b=KB1Ql23yHF2zM7rcVCNMhVBhFkqjMHtZ/AVX4Ss2lEAlr9eOR7nVd4kdvZW5Spj4yL UjKbXDAI59UnY0fXiHnyz5GCphKQmcz7BKurMqfcg1B+NheKQth5i4SU8HXOKSI3un3u KOXhMhGHTHi+rBsjfpgXoF+T0fBtYC8WWCl/LsbK5mgdRaMnvNxsPkIx8cJ3n2BQlVG3 +p/PhroQ8epk0h/g0fC1gsex4wiGYSwzM7V/Dk90Q2W1Sh45LArQJFknVIxSIAXf1Mjo oecZhFPOJAtdh+C0u8nrfC+5a+j2tu1xItepqTkJ6xJd+ULfOOKS83mtazDry95JgS8X QQkA== X-Gm-Message-State: ANoB5pkA6zzpS4TBLYFlJ8kcWtbblhtv8xlN89uuxWSwu+F0KulYvbzr M254p0r9CQgWa1j5BSbUpUHPiKiBi0/8pSw6Zcg= X-Google-Smtp-Source: AA0mqf7HAM8Bv8ra/YHRcdsb+JEXBnxyVMEeqLX/4rKRvJradKC7Js8wt7ETzEMniL0NLHDfPAcD4FN6RD/TgSq3s+o= X-Received: by 2002:a9f:22c7:0:b0:3d6:45ee:7efc with SMTP id 65-20020a9f22c7000000b003d645ee7efcmr7571754uan.86.1668943108293; Sun, 20 Nov 2022 03:18:28 -0800 (PST) In-Reply-To: <83o7t16hha.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248414 Archived-At: --0000000000001edb0605ede51909 Content-Type: multipart/alternative; boundary="0000000000001edb0205ede51907" --0000000000001edb0205ede51907 Content-Type: text/plain; charset="UTF-8" Hi, thanks for taking a look. Apologies, you're right. I've attached an updated patch, the problem before was that it was possible for a timer to be cancelled when there still existed proced buffers, which broke proced-toggle-auto-update. To reproduce, apply the patch and then type > > M-x proced-toggle-auto-update RET > > The result is that the Proced display is not updated every 5 sec as > expected, and the value of proced-auto-update-timer is nil. > I've tested this with the new patch, and it works for me. Thanks, Laurence --0000000000001edb0205ede51907 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, thanks for taking a look.=C2=A0 = Apologies, you're right.

I've attached an = updated patch, the problem before was that it was possible for a timer to b= e cancelled when there still existed proced buffers, which broke proced-tog= gle-auto-update.

To reproduce, apply the patch and then type

=C2=A0 M-x proced-toggle-auto-update RET

The result is that the Proced display is not updated every 5 sec as
expected, and the value of proced-auto-update-timer is nil.

I've tested this with the new patch, and it work= s for me.

Thanks, Laurence
--0000000000001edb0205ede51907-- --0000000000001edb0605ede51909 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Cancel-proced-auto-update-timer-if-no-proced-buffers.patch" Content-Disposition: attachment; filename="0001-Cancel-proced-auto-update-timer-if-no-proced-buffers.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lap9khrq0 RnJvbSBmYThhZjNmOTBiYzMzZDU1NGIyZDZhOGM2YzRjMzg2NmJlNzdhMmZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW5jZSBXYXJuZSA8bGF1cmVuY2V3YXJuZUBnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMTUgTm92IDIwMjIgMTg6NDg6NDAgKzAwMDAKU3ViamVjdDogW1BBVENI XSBDYW5jZWwgcHJvY2VkIGF1dG8gdXBkYXRlIHRpbWVyIGlmIG5vIHByb2NlZCBidWZmZXJzIGFy ZSBvcGVuCgoqIGxpc3AvcHJvY2VkLmVsIChwcm9jZWQtYXV0by11cGRhdGUtdGltZXIpOiBDYW5j ZWwgdGltZXIgaWYgbm8gcHJvY2VkCmJ1ZmZlcnMgYXJlIG9wZW4uCi0tLQogbGlzcC9wcm9jZWQu ZWwgfCAxOCArKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvY2VkLmVsIGIvbGlzcC9w cm9jZWQuZWwKaW5kZXggYTc3NGYyZGQxZS4uOTFmN2E5NDRmOSAxMDA2NDQKLS0tIGEvbGlzcC9w cm9jZWQuZWwKKysrIGIvbGlzcC9wcm9jZWQuZWwKQEAgLTc0MCwxMiArNzQwLDE4IEBAIHByb2Nl ZAogICAgICAgICAiVHlwZSBcXDxwcm9jZWQtbW9kZS1tYXA+XFxbcXVpdC13aW5kb3ddIHRvIHF1 aXQsIFxcW3Byb2NlZC1oZWxwXSBmb3IgaGVscCIpKSkpKQogCiAoZGVmdW4gcHJvY2VkLWF1dG8t dXBkYXRlLXRpbWVyICgpCi0gICJBdXRvLXVwZGF0ZSBQcm9jZWQgYnVmZmVycyB1c2luZyBgcnVu LWF0LXRpbWUnLiIKLSAgKGRvbGlzdCAoYnVmIChidWZmZXItbGlzdCkpCi0gICAgKHdpdGgtY3Vy cmVudC1idWZmZXIgYnVmCi0gICAgICAoaWYgKGFuZCAoZXEgbWFqb3ItbW9kZSAncHJvY2VkLW1v ZGUpCi0gICAgICAgICAgICAgICBwcm9jZWQtYXV0by11cGRhdGUtZmxhZykKLSAgICAgICAgICAo cHJvY2VkLXVwZGF0ZSB0IHQpKSkpKQorICAiQXV0by11cGRhdGUgUHJvY2VkIGJ1ZmZlcnMgdXNp bmcgYHJ1bi1hdC10aW1lJy4KKworSWYgdGhlcmUgYXJlIG5vIHByb2NlZCBidWZmZXJzLCBjYW5j ZWwgdGhlIHRpbWVyLiIKKyAgKHVubGVzcyAoc2VxLWZpbHRlciAobGFtYmRhIChidWYpCisgICAg ICAgICAgICAgICAgICAgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBidWYKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgKHdoZW4gKGVxIG1ham9yLW1vZGUgJ3Byb2NlZC1tb2RlKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICh3aGVuIHByb2NlZC1hdXRvLXVwZGF0ZS1mbGFnCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvY2VkLXVwZGF0ZSB0IHQpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHQpKSkKKyAgICAgICAgICAgICAgICAgICAgICAoYnVmZmVyLWxp c3QpKQorICAgIChjYW5jZWwtdGltZXIgcHJvY2VkLWF1dG8tdXBkYXRlLXRpbWVyKQorICAgIChz ZXRxIHByb2NlZC1hdXRvLXVwZGF0ZS10aW1lciBuaWwpKSkKIAogKGRlZnVuIHByb2NlZC10b2dn bGUtYXV0by11cGRhdGUgKGFyZykKICAgIkNoYW5nZSB3aGV0aGVyIHRoaXMgUHJvY2VkIGJ1ZmZl ciBpcyB1cGRhdGVkIGF1dG9tYXRpY2FsbHkuCi0tIAoyLjMwLjIKCg== --0000000000001edb0605ede51909--