From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Laurence Warne Newsgroups: gmane.emacs.bugs Subject: bug#59842: [PATCH] Make proced-update Preserve Refinements Date: Thu, 8 Dec 2022 19:06:35 +0000 Message-ID: References: <83y1rk5sod.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000012538e05ef55bd19" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37270"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59842@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 20:07:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3MEq-0009UO-3y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 20:07:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3MEb-0004om-2n; Thu, 08 Dec 2022 14:07:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3MEY-0004n7-Rn for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 14:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3MEY-0008Kt-Jv for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 14:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3MEY-0002Se-2M for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 14:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Laurence Warne Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59842-submit@debbugs.gnu.org id=B59842.16705264159448 (code B ref 59842); Thu, 08 Dec 2022 19:07:02 +0000 Original-Received: (at 59842) by debbugs.gnu.org; 8 Dec 2022 19:06:55 +0000 Original-Received: from localhost ([127.0.0.1]:58483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3MER-0002SK-1X for submit@debbugs.gnu.org; Thu, 08 Dec 2022 14:06:55 -0500 Original-Received: from mail-ua1-f46.google.com ([209.85.222.46]:40556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3MEO-0002SE-H5 for 59842@debbugs.gnu.org; Thu, 08 Dec 2022 14:06:53 -0500 Original-Received: by mail-ua1-f46.google.com with SMTP id q22so696890uap.7 for <59842@debbugs.gnu.org>; Thu, 08 Dec 2022 11:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/n0gDgGODE2OHQq+pXON3gtFRGIA8hQeLzQlqcr5Owk=; b=osWB8FmW1cN9eDFsQZ7wnDqz7s5h+97SbXqL8sXiO7sjbwrCv898v6RWyHdDAiBowm +ubFIWoEgkmVV2/SmUQjFGYTn6taO7k1wskD1tYRAYIIFknqxNe8TYUpaRPvi5gb+JCz JVb133yY9ICwb6/SdfluDHKodBmpTKoEWyrbt/NO5+4GWm9Kap4YCh0l7M09Ts5fc4cm ahOt5V9ggpf4g04PbD44pRfPjY4jheUg9WLdxaiL9WWBavpIPhe1Bhm8weUqbk8i5xtg Ej89idR5nqO8p6TZNTlH5KulfK3H4MQFmMwT6HC4qyMzO8l+h335LoV2xzxpQOYdX4jH PrnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/n0gDgGODE2OHQq+pXON3gtFRGIA8hQeLzQlqcr5Owk=; b=TXt5acBZHIThXyRldB6zBTEgl+AohlG1Gd0gppAQgQXbvPa4la1YTIjXhVFRszCO+X MM4zyTW9talaukQmVTdvOaxwpiU0MMvThPa0YaB1UPmRpC/khAbX+nbDiZIJJUcevjRQ DjqrxRT8Acz3Ib2t/Jh66U0lkdsJS9nVtshrtgg3kTBM8Z3gTjidYecB174cffoaVS2w vC0bHYi35P3jqEvS43987YKfZbTNMYZgisOYSVkLAeIzVOndXr3MKPnheINa3CT7BLKt 3SlCgSjcpIZSGZqENcUMdgOPylDZ2JmfyMJSz7zjD92nFNW3Sukg/tvNIxAyubshKSJm YgQw== X-Gm-Message-State: ANoB5plR5hm+XV/246eNvQK6HeCHZjx9eqh+lco2JKBwWBTTH4bOcaar LPzsdma3kDAy+3lcjyFx/prmPz4oPwAYocBjMlQpWL9t9tmplw== X-Google-Smtp-Source: AA0mqf6rJBy15Sr0CAY7iagmipjf2JWIb2mvfP6LbgtosLjgrwAwK40MBHtw+kSMua1ou4qOOvv20DiIaAF6rfdoEJU= X-Received: by 2002:ab0:b8e:0:b0:404:3611:fb13 with SMTP id c14-20020ab00b8e000000b004043611fb13mr51068505uak.54.1670526406894; Thu, 08 Dec 2022 11:06:46 -0800 (PST) In-Reply-To: <83y1rk5sod.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250327 Archived-At: --00000000000012538e05ef55bd19 Content-Type: multipart/alternative; boundary="00000000000012538c05ef55bd17" --00000000000012538c05ef55bd17 Content-Type: text/plain; charset="UTF-8" > Thanks. Unfortunately, we don't have a test suite for proced.el, so > non-trivial changes to it always ruin the risk of producing regressions. > How to test this, and how did you test it? If it's helpful, I've attached a (seperate) patch containing a test suite (or at least the start of) for proced.el (though some parts are somewhat awkward - mainly testing the proced buffer contains strings we would expect - of course comments on the approach welcome), the last test there: 'proced-refine-with-update-test' fails without the original patch. I didn't want to conflate the original patch with it, I can open a new report with it if you prefer. > What happens if that process did exit? Shouldn't we reset > proced-refinements to nil? This could lead to bad behaviour if multiple refinements are active in a buffer, for example if I refine by CPU usage of process A (which makes proced only show processes with usage >= process A's) and then again by the CPU usage of process B, if process A exits, our second refinement is still valid (given process B is still running) eventhough the first isn't. We could remove the refinement from the list, but it wouldn't change the behaviour. Thanks, Laurence --00000000000012538c05ef55bd17 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Thanks.=C2=A0 Unfortunately, we don&= #39;t have a test suite for proced.el, so
> non-trivial changes to it always ruin the risk of producing regression= s.
> How to test this, and how did you test it?

<= /div>
If it's helpful, I've attached a (seperate) patch contain= ing a test suite (or at least the start of) for proced.el (though some part= s are somewhat awkward - mainly testing the proced buffer contains strings = we would expect - of course comments on the approach welcome), the last tes= t there: 'proced-refine-with-update-test' fails without the origina= l patch.=C2=A0 I didn't want to conflate the original patch with it, I = can open a new report with it if you prefer.

&= gt; What happens if that process did exit?=C2=A0 Shouldn't we reset
> proced-refinements to nil?

This could lead to= bad behaviour if multiple refinements are active in a buffer, for example = if I refine by CPU usage of process A (which makes proced only show process= es with usage >=3D process A's) and then again by the CPU usage of p= rocess B, if process A exits, our second refinement is still valid (given p= rocess B is still running) eventhough the first isn't.=C2=A0 We could r= emove the refinement from the list, but it wouldn't change the behaviou= r.

Thanks, Laurence
--00000000000012538c05ef55bd17-- --00000000000012538e05ef55bd19 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-proced-update-preserve-refinements.patch" Content-Disposition: attachment; filename="0001-Make-proced-update-preserve-refinements.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbfflmik1 RnJvbSA0NDNkN2NkOWNjODJiMGQ4ZDkwZjM2MzQ3NWIxOWMxZWQ4ODg4M2YwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW5jZSBXYXJuZSA8bGF1cmVuY2V3YXJuZUBnbWFpbC5j b20+CkRhdGU6IFNhdCwgMyBEZWMgMjAyMiAyMTo0MTo1NyArMDAwMApTdWJqZWN0OiBbUEFUQ0hd IE1ha2UgcHJvY2VkLXVwZGF0ZSBwcmVzZXJ2ZSByZWZpbmVtZW50cwoKTWFrZSBwcm9jZWQtdXBk YXRlIHByZXNlcnZlIHJlZmluZW1lbnRzIGJ5IGNyZWF0aW5nIGEgbmV3IGJ1ZmZlciBsb2NhbAp2 YXJpYWJsZSBwcm9jZWQtcmVmaW5lbWVudHMgd2hpY2ggc3RvcmVzIGluZm9ybWF0aW9uIGFib3V0 IHRoZSBjdXJyZW50CnJlZmluZW1lbnRzIGFuZCBpcyB1c2VkIGJ5IHByb2NlZC11cGRhdGUgdG8g ZnVydGhlciByZWZpbmUKcHJvY2VkLXByb2Nlc3MtYWxpc3QgaW4gdGhlIGNhc2UgaXQgaXMgbm9u LW5pbC4gIFRoZSByZXN1bHQgaXMgdGhhdApyZWZpbmVtZW50cyBhcmUgbm90IGltbWVkaWF0ZWx5 IGNsZWFyZWQgd2hlbiBhIHByb2NlZCBidWZmZXIgaXMKdXBkYXRlZCB3aXRoIHByb2NlZC1hdXRv LXVwZGF0ZS1mbGFnIG5vbi1uaWwuICBwcm9jZWQtcmV2ZXJ0Cm1haW50YWlucyBpdHMgY3VycmVu dCBiZWhhdmlvdXIgb2YgY2xlYXJpbmcgYW55IGFjdGl2ZSByZWZpbmVtZW50cy4KCiogbGlzcC9w cm9jZWQuZWwgKHByb2NlZC1yZWZpbmVtZW50cyk6IE5ldyBidWZmZXIgbG9jYWwgdmFyaWFibGUK d2hpY2ggdHJhY2tzIHRoZSBjdXJyZW50IHJlZmluZW1lbnRzLgoocHJvY2VkLXJlZmluZSk6IFNl dCAncHJvY2VkLXJlZmluZW1lbnRzJyB2YXJpYWJsZSBhbmQgZGVmZXIgc2V0dGluZyBvZgoncHJv Y2VkLXByb2Nlc3MtYWxpc3QnIHRvICdwcm9jZWQtdXBkYXRlJy4KKHByb2NlZC11cGRhdGUpOiBU YWtlIGludG8gYWNjb3VudCAncHJvY2VkLXJlZmluZW1lbnRzJyB3aGVuIHNldHRpbmcKJ3Byb2Nl ZC1wcm9jZXNzLWFsaXN0Jy4KKHByb2NlZC1yZXZlcnQpOiBTZXQgJ3Byb2NlZC1yZWZpbmVtZW50 cycgdG8gbmlsIHByaW9yIHRvIGNhbGxpbmcKJ3Byb2NlZC11cGRhdGUnLgotLS0KIGxpc3AvcHJv Y2VkLmVsIHwgNTIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9saXNwL3Byb2NlZC5lbCBiL2xpc3AvcHJvY2VkLmVsCmluZGV4IGM3NDE5 Mjg4ZWQuLmMwOWVlMThhOGIgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvY2VkLmVsCisrKyBiL2xpc3Av cHJvY2VkLmVsCkBAIC02NTYsNiArNjU2LDE0IEBAIHByb2NlZC1tb2RlLW1hcAogICApCiAocHV0 ICdwcm9jZWQtbWFyayA6YWR2ZXJ0aXNlZC1iaW5kaW5nICJtIikKIAorKGRlZnZhci1sb2NhbCBw cm9jZWQtcmVmaW5lbWVudHMgbmlsCisgICJJbmZvcm1hdGlvbiBhYm91dCB0aGUgY3VycmVudCBi dWZmZXIgcmVmaW5lbWVudHMuCisKK0l0IHNob3VsZCBiZSBhIGxpc3Qgb2YgZWxlbWVudHMgb2Yg dGhlIGZvcm0gKFJFRklORVIgUElEIEtFWSBHUkFNTUFSKSwgd2hlcmUKK1JFRklORVIgYW5kIEdS QU1NQVIgYXJlIGFzIGRlc2NyaWJlZCBpbiBgcHJvY2VkLWdyYW1tYXItYWxpc3QnLCBQSUQgaXMg dGhlCitwcm9jZXNzIElEIG9mIHRoZSBwcm9jZXNzIHVzZWQgdG8gY3JlYXRlIHRoZSByZWZpbmVt ZW50LCBhbmQgS0VZIHRoZSBhdHRyaWJ1dGUKK29mIHRoZSBwcm9jZXNzLiAgQSB2YWx1ZSBvZiBu aWwgaW5kaWNhdGVzIHRoYXQgdGhlcmUgYXJlIG5vIGFjdGl2ZSByZWZpbmVtZW50cy4iKQorCiAo ZWFzeS1tZW51LWRlZmluZSBwcm9jZWQtbWVudSBwcm9jZWQtbW9kZS1tYXAKICAgIlByb2NlZCBN ZW51LiIKICAgYCgiUHJvY2VkIgpAQCAtMTMzNywyMCArMTM0NSw3IEBAIHByb2NlZC1yZWZpbmUK ICAgICAgICAgKGxldCogKChncmFtbWFyIChhc3NxIGtleSBwcm9jZWQtZ3JhbW1hci1hbGlzdCkp CiAgICAgICAgICAgICAgICAocmVmaW5lciAobnRoIDcgZ3JhbW1hcikpKQogICAgICAgICAgICh3 aGVuIHJlZmluZXIKLSAgICAgICAgICAgIChjb25kICgoZnVuY3Rpb25wIChjYXIgcmVmaW5lcikp Ci0gICAgICAgICAgICAgICAgICAgKHNldHEgcHJvY2VkLXByb2Nlc3MtYWxpc3QgKGZ1bmNhbGwg KGNhciByZWZpbmVyKSBwaWQpKSkKLSAgICAgICAgICAgICAgICAgICgoY29uc3AgcmVmaW5lcikK LSAgICAgICAgICAgICAgICAgICAobGV0ICgocHJlZGljYXRlIChudGggNCBncmFtbWFyKSkKLSAg ICAgICAgICAgICAgICAgICAgICAgICAocmVmIChjZHIgKGFzc3Ega2V5IChjZHIgKGFzc3EgcGlk IHByb2NlZC1wcm9jZXNzLWFsaXN0KSkpKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICB2YWwg bmV3LWFsaXN0KQotICAgICAgICAgICAgICAgICAgICAgKGRvbGlzdCAocHJvY2VzcyBwcm9jZWQt cHJvY2Vzcy1hbGlzdCkKLSAgICAgICAgICAgICAgICAgICAgICAgKHNldHEgdmFsIChmdW5jYWxs IHByZWRpY2F0ZSAoY2RyIChhc3NxIGtleSAoY2RyIHByb2Nlc3MpKSkgcmVmKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgKGlmIChjb25kICgobm90IHZhbCkgKG50aCAyIHJlZmluZXIpKQotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChlcSB2YWwgJ2VxdWFsKSAobnRoIDEgcmVm aW5lcikpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodmFsIChjYXIgcmVmaW5l cikpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgKHB1c2ggcHJvY2VzcyBuZXctYWxpc3Qp KSkKLSAgICAgICAgICAgICAgICAgICAgIChzZXRxIHByb2NlZC1wcm9jZXNzLWFsaXN0IG5ldy1h bGlzdCkpKSkKLSAgICAgICAgICAgIDs7IERvIG5vdCByZXZlcnQgbGlzdGluZy4KKyAgICAgICAg ICAgIChhZGQtdG8tbGlzdCAncHJvY2VkLXJlZmluZW1lbnRzIChsaXN0IHJlZmluZXIgcGlkIGtl eSBncmFtbWFyKSB0KQogICAgICAgICAgICAgKHByb2NlZC11cGRhdGUpKSkKICAgICAgIChtZXNz YWdlICJObyByZWZpbmVyIGRlZmluZWQgaGVyZS4iKSkpKQogCkBAIC0xODU5LDEwICsxODU0LDI5 IEBAIHByb2NlZC11cGRhdGUKICAgICAgICAgICAgICAgICAgICAgICAgIlVwZGF0aW5nIHByb2Nl c3MgZGlzcGxheS4uLiIpKSkKICAgKGlmIHJldmVydCA7OyBldmFsdWF0ZSBhbGwgcHJvY2Vzc2Vz CiAgICAgICAoc2V0cSBwcm9jZWQtcHJvY2Vzcy1hbGlzdCAocHJvY2VkLXByb2Nlc3MtYXR0cmli dXRlcykpKQotICA7OyBmaWx0ZXJpbmcgYW5kIHNvcnRpbmcKKyAgOzsgZmlsdGVyaW5nCisgIChz ZXRxIHByb2NlZC1wcm9jZXNzLWFsaXN0IChwcm9jZWQtZmlsdGVyIHByb2NlZC1wcm9jZXNzLWFs aXN0IHByb2NlZC1maWx0ZXIpKQorICA7OyByZWZpbmVtZW50cworICAocGNhc2UtZG9saXN0IChg KCxyZWZpbmVyICxwaWQgLGtleSAsZ3JhbW1hcikgcHJvY2VkLXJlZmluZW1lbnRzKQorICAgIDs7 IEl0J3MgcG9zc2libGUgdGhlIHByb2Nlc3MgaGFzIGV4aXRlZCBzaW5jZSB0aGUgcmVmaW5lbWVu dCB3YXMgbWFkZQorICAgICh3aGVuIChhc3NxIHBpZCBwcm9jZWQtcHJvY2Vzcy1hbGlzdCkKKyAg ICAgIChjb25kICgoZnVuY3Rpb25wIChjYXIgcmVmaW5lcikpCisgICAgICAgICAgICAgKHNldHEg cHJvY2VkLXByb2Nlc3MtYWxpc3QgKGZ1bmNhbGwgKGNhciByZWZpbmVyKSBwaWQpKSkKKyAgICAg ICAgICAgICgoY29uc3AgcmVmaW5lcikKKyAgICAgICAgICAgICAobGV0ICgocHJlZGljYXRlIChu dGggNCBncmFtbWFyKSkKKyAgICAgICAgICAgICAgICAgICAocmVmIChjZHIgKGFzc3Ega2V5IChj ZHIgKGFzc3EgcGlkIHByb2NlZC1wcm9jZXNzLWFsaXN0KSkpKSkKKyAgICAgICAgICAgICAgICAg ICB2YWwgbmV3LWFsaXN0KQorICAgICAgICAgICAgICAgKGRvbGlzdCAocHJvY2VzcyBwcm9jZWQt cHJvY2Vzcy1hbGlzdCkKKyAgICAgICAgICAgICAgICAgKHNldHEgdmFsIChmdW5jYWxsIHByZWRp Y2F0ZSAoY2RyIChhc3NxIGtleSAoY2RyIHByb2Nlc3MpKSkgcmVmKSkKKyAgICAgICAgICAgICAg ICAgKHdoZW4gKGNvbmQgKChub3QgdmFsKSAobnRoIDIgcmVmaW5lcikpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICgoZXEgdmFsICdlcXVhbCkgKG50aCAxIHJlZmluZXIpKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAodmFsIChjYXIgcmVmaW5lcikpKQorICAgICAgICAgICAg ICAgICAgIChwdXNoIHByb2Nlc3MgbmV3LWFsaXN0KSkpCisgICAgICAgICAgICAgICAoc2V0cSBw cm9jZWQtcHJvY2Vzcy1hbGlzdCBuZXctYWxpc3QpKSkpKSkKKworICA7OyBzb3J0aW5nCiAgIChz ZXRxIHByb2NlZC1wcm9jZXNzLWFsaXN0Ci0gICAgICAgIChwcm9jZWQtc29ydCAocHJvY2VkLWZp bHRlciBwcm9jZWQtcHJvY2Vzcy1hbGlzdCBwcm9jZWQtZmlsdGVyKQotICAgICAgICAgICAgICAg ICAgICAgcHJvY2VkLXNvcnQgcHJvY2VkLWRlc2NlbmQpKQorICAgICAgICAocHJvY2VkLXNvcnQg cHJvY2VkLXByb2Nlc3MtYWxpc3QgcHJvY2VkLXNvcnQgcHJvY2VkLWRlc2NlbmQpKQogCiAgIDs7 IGRpc3BsYXkgYXMgcHJvY2VzcyB0cmVlPwogICAoc2V0cSBwcm9jZWQtcHJvY2Vzcy1hbGlzdApA QCAtMTk3Niw3ICsxOTkwLDkgQEAgcHJvY2VkLXVwZGF0ZQogCiAoZGVmdW4gcHJvY2VkLXJldmVy dCAoJnJlc3QgX2FyZ3MpCiAgICJSZWV2YWx1YXRlIHRoZSBwcm9jZXNzIGxpc3RpbmcgYmFzZWQg b24gdGhlIGN1cnJlbnRseSBydW5uaW5nIHByb2Nlc3Nlcy4KLVByZXNlcnZlcyBwb2ludCBhbmQg bWFya3MuIgorUHJlc2VydmVzIHBvaW50IGFuZCBtYXJrcywgYnV0IG5vdCByZWZpbmVtZW50cyAo c2VlIGBwcm9jZWQtcmVmaW5lJyBmb3IKK2luZm9ybWF0aW9uIG9uIHJlZmluZW1lbnRzKS4iCisg IChzZXRxIHByb2NlZC1yZWZpbmVtZW50cyBuaWwpCiAgIChwcm9jZWQtdXBkYXRlIHQpKQogCiAo ZGVmdW4gcHJvY2VkLW1hcmtlZC1wcm9jZXNzZXMgKCkKLS0gCjIuMzAuMgoK --00000000000012538e05ef55bd19 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-tests-for-proced.patch" Content-Disposition: attachment; filename="0001-Add-tests-for-proced.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbfg57bg1 RnJvbSAzNjZiMThjZWU3YjcxMGY2ZDBlZTdiZDg2NDk3YzIxZmMwNzI5MjQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW5jZSBXYXJuZSA8bGF1cmVuY2V3YXJuZUBnbWFpbC5j b20+CkRhdGU6IFRodSwgOCBEZWMgMjAyMiAxMzozOTowMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hd IEFkZCB0ZXN0cyBmb3IgcHJvY2VkCgoqIHRlc3QvbGlzcC9wcm9jZWQtdGVzdHMuZWw6IE5ldyBm aWxlLgotLS0KIHRlc3QvbGlzcC9wcm9jZWQtdGVzdHMuZWwgfCAxMDkgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxMDkgaW5zZXJ0aW9ucygr KQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9wcm9jZWQtdGVzdHMuZWwKCmRpZmYgLS1n aXQgYS90ZXN0L2xpc3AvcHJvY2VkLXRlc3RzLmVsIGIvdGVzdC9saXNwL3Byb2NlZC10ZXN0cy5l bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi43OGQxYjZhYTQwCi0tLSAv ZGV2L251bGwKKysrIGIvdGVzdC9saXNwL3Byb2NlZC10ZXN0cy5lbApAQCAtMCwwICsxLDEwOSBA QAorOzs7IHByb2NlZC10ZXN0cy5lbCAtLS0gVGVzdCBzdWl0ZSBmb3IgcHJvY2VkLmVsIC0qLSBs ZXhpY2FsLWJpbmRpbmc6IHQgLSotCisKKzs7IENvcHlyaWdodCAoQykgMjAyMiBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb24sIEluYy4KKworOzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEVtYWNz LgorCis7OyBHTlUgRW1hY3MgaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yIG1vZGlmeQorOzsgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKzs7IHRoZSBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCis7OyAoYXQgeW91 ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCis7OyBHTlUgRW1hY3MgaXMgZGlzdHJpYnV0 ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKzs7IGJ1dCBXSVRIT1VUIEFO WSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OyBNRVJD SEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl Cis7OyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCis7OyBZ b3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMg TGljZW5zZQorOzsgYWxvbmcgd2l0aCBHTlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93 d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCis7OzsgQ29kZToKKyhyZXF1aXJlICdlcnQpCisocmVx dWlyZSAncHJvY2VkKQorCisoY2wtZGVmbWFjcm8gcHJvY2VkLS13aXRoaW4tYnVmZmVyIChmb3Jt YXQgZmlsdGVyICZib2R5IGJvZHkpCisgICJFeGVjdXRlIEJPRFkgd2l0aGluIGEgcHJvY2VkIGJ1 ZmZlciB1c2luZyBmb3JtYXQgRk9STUFUIGFuZCBmaWx0ZXIgRklMVEVSLiIKKyAgYChsZXQgKChw cm9jZWQtZm9ybWF0ICxmb3JtYXQpCisgICAgICAgICAocHJvY2VkLWZpbHRlciAsZmlsdGVyKQor ICAgICAgICAgKHByb2NlZC1hdXRvLXVwZGF0ZS1mbGFnIG5pbCkKKyAgICAgICAgIChpbmhpYml0 LW1lc3NhZ2UgdCkpCisgICAgIChwcm9jZWQpCisgICAgICh1bndpbmQtcHJvdGVjdAorICAgICAg ICAgKHdpdGgtY3VycmVudC1idWZmZXIgIipQcm9jZWQqIgorICAgICAgICAgICAsQGJvZHkpCisg ICAgICAgKGtpbGwtYnVmZmVyICIqUHJvY2VkKiIpKSkpCisKKyhkZWZ1biBwcm9jZWQtLWFzc2Vy dC1lbWFjcy1waWQtaW4tYnVmZmVyICgpCisgICJGYWlsIHVubGVzcyB0aGUgcHJvY2VzcyBJRCBv ZiB0aGUgY3VycmVudCBFbWFjcyBwcm9jZXNzIGV4aXN0cyBpbiBidWZmZXIuIgorICAoc2hvdWxk IChzdHJpbmctbWF0Y2gtcAorICAgICAgICAgICAobnVtYmVyLXRvLXN0cmluZyAoZW1hY3MtcGlk KSkKKyAgICAgICAgICAgKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJvcGVydGllcyAocG9pbnQtbWlu KSAocG9pbnQtbWF4KSkpKSkKKworKGRlZnVuIHByb2NlZC0tbW92ZS10by1jb2x1bW4gKGF0dHJp YnV0ZSkKKyAgIk1vdmUgdG8gdGhlIGNvbHVtbiB1bmRlciBBVFRSSUJVVEUgaW4gdGhlIGN1cnJl bnQgcHJvY2VkIGJ1ZmZlci4iCisgIChtb3ZlLXRvLWNvbHVtbiAoc3RyaW5nLW1hdGNoIGF0dHJp YnV0ZSBwcm9jZWQtaGVhZGVyLWxpbmUpKSkKKworKGVydC1kZWZ0ZXN0IHByb2NlZC1mb3JtYXQt dGVzdCAoKQorICAoc2tpcC11bmxlc3MgKG1lbXEgc3lzdGVtLXR5cGUgJyhnbnUvbGludXggZ251 L2tmcmVlYnNkIGRhcndpbikpKQorICAoZG9saXN0IChmb3JtYXQgJyhzaG9ydCBtZWRpdW0gbG9u ZyB2ZXJib3NlKSkKKyAgICAocHJvY2VkLS13aXRoaW4tYnVmZmVyCisgICAgIGZvcm1hdAorICAg ICAndXNlcgorICAgICAocHJvY2VkLS1hc3NlcnQtZW1hY3MtcGlkLWluLWJ1ZmZlcikpKSkKKwor KGVydC1kZWZ0ZXN0IHByb2NlZC11cGRhdGUtdGVzdCAoKQorICAoc2tpcC11bmxlc3MgKG1lbXEg c3lzdGVtLXR5cGUgJyhnbnUvbGludXggZ251L2tmcmVlYnNkIGRhcndpbikpKQorICAocHJvY2Vk LS13aXRoaW4tYnVmZmVyCisgICAnc2hvcnQKKyAgICd1c2VyCisgICAocHJvY2VkLXVwZGF0ZSkK KyAgIChwcm9jZWQtLWFzc2VydC1lbWFjcy1waWQtaW4tYnVmZmVyKSkpCisKKyhlcnQtZGVmdGVz dCBwcm9jZWQtcmV2ZXJ0LXRlc3QgKCkKKyAgKHNraXAtdW5sZXNzIChtZW1xIHN5c3RlbS10eXBl ICcoZ251L2xpbnV4IGdudS9rZnJlZWJzZCBkYXJ3aW4pKSkKKyAgKHByb2NlZC0td2l0aGluLWJ1 ZmZlcgorICAgJ3Nob3J0CisgICAndXNlcgorICAgKHByb2NlZC1yZXZlcnQpCisgICAocHJvY2Vk LS1hc3NlcnQtZW1hY3MtcGlkLWluLWJ1ZmZlcikpKQorCisoZXJ0LWRlZnRlc3QgcHJvY2VkLWNv bG9yLXRlc3QgKCkKKyAgKHNraXAtdW5sZXNzIChtZW1xIHN5c3RlbS10eXBlICcoZ251L2xpbnV4 IGdudS9rZnJlZWJzZCBkYXJ3aW4pKSkKKyAgKGxldCAoKHByb2NlZC1lbmFibGUtY29sb3ItZmxh ZyB0KSkKKyAgICAocHJvY2VkLS13aXRoaW4tYnVmZmVyCisgICAgICdzaG9ydAorICAgICAndXNl cgorICAgICAocHJvY2VkLS1hc3NlcnQtZW1hY3MtcGlkLWluLWJ1ZmZlcikpKSkKKworKGVydC1k ZWZ0ZXN0IHByb2NlZC1yZWZpbmUtdGVzdCAoKQorICAoc2tpcC11bmxlc3MgKG1lbXEgc3lzdGVt LXR5cGUgJyhnbnUvbGludXggZ251L2tmcmVlYnNkIGRhcndpbikpKQorICAocHJvY2VkLS13aXRo aW4tYnVmZmVyCisgICAnbWVkaXVtCisgICAndXNlcgorICAgOzsgV2hlbiByZWZpbmluZyBvbiBB cmdzIGZvciBwcm9jZXNzIEEsIGEgcHJvY2VzcyBpcyBrZXB0IGlmIGFuZCBvbmx5CisgICA7OyBp ZiBpdHMgYXJncyBhcmUgdGhlIHNhbWUgYXMgcHJvY2VzcyBBLCB3aGljaCBtb3JlIG9yIGxlc3Mg Z3VhcmVudGVlcworICAgOzsgdGhlIHJlZmluZW1lbnQgd2lsbCByZW1vdmUgc29tZSBwcm9jZXNz ZXMuCisgICAocHJvY2VkLS1tb3ZlLXRvLWNvbHVtbiAiQXJncyIpCisgICAobGV0ICgoYXJncyAo YnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludCkgKGxpbmUtZW5kLXBvc2l0aW9u KSkpKQorICAgICAocHJvY2VkLXJlZmluZSkKKyAgICAgKHdoaWxlIChub3QgKGVvYnApKQorICAg ICAgIChwcm9jZWQtLW1vdmUtdG8tY29sdW1uICJBcmdzIikKKyAgICAgICAoc2hvdWxkIChzdHJp bmc9IGFyZ3MgKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJvcGVydGllcyAocG9pbnQpIChsaW5lLWVu ZC1wb3NpdGlvbikpKSkKKyAgICAgICAoZm9yd2FyZC1saW5lKSkpKSkKKworKGVydC1kZWZ0ZXN0 IHByb2NlZC1yZWZpbmUtd2l0aC11cGRhdGUtdGVzdCAoKQorICAoc2tpcC11bmxlc3MgKG1lbXEg c3lzdGVtLXR5cGUgJyhnbnUvbGludXggZ251L2tmcmVlYnNkIGRhcndpbikpKQorICAocHJvY2Vk LS13aXRoaW4tYnVmZmVyCisgICAnbWVkaXVtCisgICAndXNlcgorICAgKHByb2NlZC0tbW92ZS10 by1jb2x1bW4gIkFyZ3MiKQorICAgKGxldCAoKGFyZ3MgKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJv cGVydGllcyAocG9pbnQpIChsaW5lLWVuZC1wb3NpdGlvbikpKSkKKyAgICAgKHByb2NlZC1yZWZp bmUpCisgICAgIChwcm9jZWQtdXBkYXRlIHQpCisgICAgICh3aGlsZSAobm90IChlb2JwKSkKKyAg ICAgICAocHJvY2VkLS1tb3ZlLXRvLWNvbHVtbiAiQXJncyIpCisgICAgICAgKHNob3VsZCAoc3Ry aW5nPSBhcmdzIChidWZmZXItc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMgKHBvaW50KSAobGluZS1l bmQtcG9zaXRpb24pKSkpCisgICAgICAgKGZvcndhcmQtbGluZSkpKSkpCisKKyhwcm92aWRlICdw cm9jZWQtdGVzdHMpCis7OzsgcHJvY2VkLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4zMC4yCgo= --00000000000012538e05ef55bd19--