From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Laurence Warne Newsgroups: gmane.emacs.bugs Subject: bug#64800: [PATCH] Fix unstable Proced Refine Tests Date: Sun, 23 Jul 2023 14:20:33 +0100 Message-ID: References: <83tttvsz5x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000008f1db80601275dd5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20751"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64800@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 15:21:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNZ1T-0005Hh-W8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 15:21:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNZ1E-0005Gu-Bv; Sun, 23 Jul 2023 09:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNZ1C-0005FY-Ar for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:21:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNZ1C-0006SV-39 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNZ1B-0002uG-VY for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Laurence Warne Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64800-submit@debbugs.gnu.org id=B64800.169011845311150 (code B ref 64800); Sun, 23 Jul 2023 13:21:01 +0000 Original-Received: (at 64800) by debbugs.gnu.org; 23 Jul 2023 13:20:53 +0000 Original-Received: from localhost ([127.0.0.1]:39013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZ12-0002tm-J6 for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:20:52 -0400 Original-Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:53258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZ10-0002tY-Qr for 64800@debbugs.gnu.org; Sun, 23 Jul 2023 09:20:51 -0400 Original-Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-76ae5b44426so119404685a.2 for <64800@debbugs.gnu.org>; Sun, 23 Jul 2023 06:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690118445; x=1690723245; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VBkiVrgYp7EwUZyX+daBqamntWbshY2FZBQLYwVi/Ro=; b=fTHh4KtagbIuJ0ZJ6urI6UMYEHe7qhxzIDOFg+JWKxHHbXWrhLg376qOFH1KDDYeW5 2vwr6iOf0ltuvBlxMejQIV6g66LucEz3Jl7mMvnPynX1Ucy1nRMtvCTqCXd/xwrU+QzL ynP3bVPuILRL5pSJrOGBwNU0bhXXsHza8m0jbHnHecGhZxoO1NbQ0wJw+Rlk8sckGJ1Y MAAuE0Yub4d1lxdTHl3QvdQf0IA2BBC24ZRy7ERIyQ6pEWrkaFIHRTD9PGcJFnXebclv 0Sqz6WonHerWizSTHFmkYNUKapYqnIgFmGQZ3fsZDabhprfoTYwD7GHd7UTiav1UTelS veAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690118445; x=1690723245; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VBkiVrgYp7EwUZyX+daBqamntWbshY2FZBQLYwVi/Ro=; b=hvbRWGBOeoGXqwY4VzV2beQ3zCF7ePuC2Tcs928lXJR0BL11KDkOFXzzonKwNM1tmt VS+rqB7L1R41cMUBX6VszAFomA3Z7ehNTl/fLhGrArG+d/qCDvDhRcG+OaiJzoQMxUT7 4JwZU3FWJ/R4uli9mZqJpJ/aU9mExwz2PcKYYl8/XegDLWMpQeaMz0vbyjBBb+jIN5Yk zHZAo9/0eJ0A2ZQT0COy8H0TW7MqhivNqHLQVULXtTtREfWw0ETvugSOmz9bYwJWXEtN /f7E4y7FY9zm0Oc3gL7LIkhtzPTGr1dLLua5EWhcj1clthG8kl6jDnc0e0jks1n16CU9 iu+w== X-Gm-Message-State: ABy/qLbI/YnVit97yYeCanBZkDWS+wYbfwyjavroH2mMCDS5WYpzdu+m fDGg5Z1MwSOBFEneicEVdkUatv5hwUlPOxmwZqY= X-Google-Smtp-Source: APBJJlHDQBgj5T9h+bAfCgXhrRP2kIhek7cK5Nfe6NCJ/mLYhbuRH2IHj1ba1kjRvQau76K+o//eNW04lmUToaiiUfc= X-Received: by 2002:a05:620a:2017:b0:767:182e:52af with SMTP id c23-20020a05620a201700b00767182e52afmr4458080qka.32.1690118445169; Sun, 23 Jul 2023 06:20:45 -0700 (PDT) In-Reply-To: <83tttvsz5x.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265900 Archived-At: --0000000000008f1db80601275dd5 Content-Type: multipart/alternative; boundary="0000000000008f1db60601275dd3" --0000000000008f1db60601275dd3 Content-Type: text/plain; charset="UTF-8" With non-nix systems, that's a fair point I guess session id might not be supported (though if you're on a nix system my guess would be you're using a proced format with session id omitted, in general the tests should guard against this by setting the format for duration of the test). I've attached a new patch which makes the tests still check against PID, but also makes the tests check if PPID matches as a fallback before failing. Thanks, Laurence --0000000000008f1db60601275dd3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
With non-nix systems, that's a fair point I guess sess= ion id might not be supported (though if you're on a nix system my gues= s would be you're using a proced format with session id omitted, in gen= eral the tests should guard against this by setting the format for duration= of the test).=C2=A0 I've attached a new patch which makes the tests st= ill check against PID, but also makes the tests check if PPID matches as a = fallback before failing.

Thanks, Laurence
--0000000000008f1db60601275dd3-- --0000000000008f1db80601275dd5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-unstable-Proced-refine-tests.patch" Content-Disposition: attachment; filename="0001-Fix-unstable-Proced-refine-tests.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lkfgiynk0 RnJvbSAzODI2ZTdiNWZlOThjMjA1MWRlZGViNGExZDZiNzY4Y2I2YzAxOGFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW5jZSBXYXJuZSA8bGF1cmVuY2V3YXJuZUBnbWFpbC5j b20+CkRhdGU6IFNhdCwgMjIgSnVsIDIwMjMgMjA6NDc6MjEgKzAxMDAKU3ViamVjdDogW1BBVENI XSBGaXggdW5zdGFibGUgUHJvY2VkIHJlZmluZSB0ZXN0cwoKKiB0ZXN0L2xpc3AvcHJvY2VkLXRl c3RzLmVsIChwcm9jZWQtcmVmaW5lLXRlc3QpCihwcm9jZWQtcmVmaW5lLXdpdGgtdXBkYXRlLXRl c3QpOiBBbHNvIGNoZWNrIGlmIHRoZSBwYXJlbnQgcHJvY2VzcyBpZApvZiBlYWNoIHByb2Nlc3Mg bWF0Y2hlcyB0aGUgcHJvY2VzcyBpZCByZWZpbmVkIG9uIGJlZm9yZSBmYWlsaW5nLApzaW5jZSB0 aGUgcmVmaW5lciBmb3IgcHJvY2VzcyBpZCByZXR1cm5zIHRoZSBjaGlsZHJlbiBvZiBhIHByb2Nl c3MgaW4KYWRkaXRpb24gdG8gdGhlIHByb2Nlc3MgaXRzZWxmLgotLS0KIHRlc3QvbGlzcC9wcm9j ZWQtdGVzdHMuZWwgfCAyNSArKysrKysrKysrKysrKysrKy0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMTcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0L2xp c3AvcHJvY2VkLXRlc3RzLmVsIGIvdGVzdC9saXNwL3Byb2NlZC10ZXN0cy5lbAppbmRleCBkNTNm MjViMDBkOC4uYmZmYmY1NDg2ZDMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9wcm9jZWQtdGVzdHMu ZWwKKysrIGIvdGVzdC9saXNwL3Byb2NlZC10ZXN0cy5lbApAQCAtNDQsNiArNDQsMTcgQEAgcHJv Y2VkLS1tb3ZlLXRvLWNvbHVtbgogICAiTW92ZSB0byB0aGUgY29sdW1uIHVuZGVyIEFUVFJJQlVU RSBpbiB0aGUgY3VycmVudCBwcm9jZWQgYnVmZmVyLiIKICAgKG1vdmUtdG8tY29sdW1uIChzdHJp bmctbWF0Y2ggYXR0cmlidXRlIHByb2NlZC1oZWFkZXItbGluZSkpKQogCisoZGVmdW4gcHJvY2Vk LS1hc3NlcnQtcHJvY2Vzcy12YWxpZC1waWQtcmVmaW5lbWVudCAocGlkKQorICAiRmFpbCB1bmxl c3MgdGhlIHByb2Nlc3MgYXQgcG9pbnQgY291bGQgYmUgcHJlc2VudCBhZnRlciBhIHJlZmlubWVu dCB1c2luZyBQSUQuIgorICAocHJvY2VkLS1tb3ZlLXRvLWNvbHVtbiAiUElEIikKKyAgKGxldCAo KHBpZC1lcXVhbCAoc3RyaW5nPSBwaWQgKHdvcmQtYXQtcG9pbnQpKSkpCisgICAgKHNob3VsZAor ICAgICAob3IgcGlkLWVxdWFsCisgICAgICAgICA7OyBHdWFyZCBhZ2FpbnN0IHRoZSB1bmxpa2Vs eSBldmVudCBhIHBsYXRmb3JtIGRvZXNuJ3Qgc3VwcG9ydCBQUElECisgICAgICAgICAod2hlbiAo c3RyaW5nLW1hdGNoICJQUElEIiBwcm9jZWQtaGVhZGVyLWxpbmUpCisgICAgICAgICAgIChwcm9j ZWQtLW1vdmUtdG8tY29sdW1uICJQUElEIikKKyAgICAgICAgICAgKHN0cmluZz0gcGlkICh3b3Jk LWF0LXBvaW50KSkpKSkpKQorCiAoZXJ0LWRlZnRlc3QgcHJvY2VkLWZvcm1hdC10ZXN0ICgpCiAg IChkb2xpc3QgKGZvcm1hdCAnKHNob3J0IG1lZGl1bSBsb25nIHZlcmJvc2UpKQogICAgIChwcm9j ZWQtLXdpdGhpbi1idWZmZXIKQEAgLTc1LDIyICs4NiwyMSBAQCBwcm9jZWQtY29sb3ItdGVzdAog KGVydC1kZWZ0ZXN0IHByb2NlZC1yZWZpbmUtdGVzdCAoKQogICA7Oyhza2lwLXVubGVzcyAobWVt cSBzeXN0ZW0tdHlwZSAnKGdudS9saW51eCBnbnUva2ZyZWVic2QgZGFyd2luKSkpCiAgIChwcm9j ZWQtLXdpdGhpbi1idWZmZXIKLSAgICdtZWRpdW0KKyAgICd2ZXJib3NlCiAgICAndXNlcgogICAg OzsgV2hlbiByZWZpbmluZyBvbiBQSUQgZm9yIHByb2Nlc3MgQSwgYSBwcm9jZXNzIGlzIGtlcHQg aWYgYW5kIG9ubHkKLSAgIDs7IGlmIGl0cyBQSUQgYXJlIHRoZSBzYW1lIGFzIHByb2Nlc3MgQSwg d2hpY2ggbW9yZSBvciBsZXNzIGd1YXJlbnRlZXMKLSAgIDs7IHRoZSByZWZpbmVtZW50IHdpbGwg cmVtb3ZlIHNvbWUgcHJvY2Vzc2VzLgorICAgOzsgaWYgaXRzIFBJRCBpcyB0aGUgc2FtZSBhcyBw cm9jZXNzIEEsIG9yIGl0cyBwYXJlbnQgcHJvY2VzcyBpcworICAgOzsgcHJvY2VzcyBBLgogICAg KHByb2NlZC0tbW92ZS10by1jb2x1bW4gIlBJRCIpCiAgICAobGV0ICgocGlkICh3b3JkLWF0LXBv aW50KSkpCiAgICAgIChwcm9jZWQtcmVmaW5lKQogICAgICAod2hpbGUgKG5vdCAoZW9icCkpCi0g ICAgICAgKHByb2NlZC0tbW92ZS10by1jb2x1bW4gIlBJRCIpCi0gICAgICAgKHNob3VsZCAoc3Ry aW5nPSBwaWQgKHdvcmQtYXQtcG9pbnQpKSkKKyAgICAgICAocHJvY2VkLS1hc3NlcnQtcHJvY2Vz cy12YWxpZC1waWQtcmVmaW5lbWVudCBwaWQpCiAgICAgICAgKGZvcndhcmQtbGluZSkpKSkpCiAK IChlcnQtZGVmdGVzdCBwcm9jZWQtcmVmaW5lLXdpdGgtdXBkYXRlLXRlc3QgKCkKICAgKHByb2Nl ZC0td2l0aGluLWJ1ZmZlcgotICAgJ21lZGl1bQorICAgJ3ZlcmJvc2UKICAgICd1c2VyCiAgICAo cHJvY2VkLS1tb3ZlLXRvLWNvbHVtbiAiUElEIikKICAgIChsZXQgKChwaWQgKHdvcmQtYXQtcG9p bnQpKSkKQEAgLTEwMSw4ICsxMTEsNyBAQCBwcm9jZWQtcmVmaW5lLXdpdGgtdXBkYXRlLXRlc3QK ICAgICAgOzsgcHJvY2Vzc2VzIGFnYWluLCBjYXVzaW5nIHRoZSB0ZXN0IHRvIGZhaWwuCiAgICAg IChwcm9jZWQtdXBkYXRlKQogICAgICAod2hpbGUgKG5vdCAoZW9icCkpCi0gICAgICAgKHByb2Nl ZC0tbW92ZS10by1jb2x1bW4gIlBJRCIpCi0gICAgICAgKHNob3VsZCAoc3RyaW5nPSBwaWQgKHdv cmQtYXQtcG9pbnQpKSkKKyAgICAgICAocHJvY2VkLS1hc3NlcnQtcHJvY2Vzcy12YWxpZC1waWQt cmVmaW5lbWVudCBwaWQpCiAgICAgICAgKGZvcndhcmQtbGluZSkpKSkpCiAKIChlcnQtZGVmdGVz dCBwcm9jZWQtdXBkYXRlLXByZXNlcnZlcy1waWQtYXQtcG9pbnQtdGVzdCAoKQotLSAKMi4zMC4y Cgo= --0000000000008f1db80601275dd5--