From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robin Campbell Joy Newsgroups: gmane.emacs.bugs Subject: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Date: Thu, 23 May 2024 08:22:37 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000008414cc0619191486" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34137"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71107@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 23 08:24:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sA1sJ-0008gw-28 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 May 2024 08:24:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA1rx-0008OZ-RI; Thu, 23 May 2024 02:24:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA1ro-0008N2-MS for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 02:23:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sA1ro-0004QR-Br for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 02:23:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sA1ru-0007Bz-GS for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 02:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robin Campbell Joy Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 May 2024 06:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71107 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71107-submit@debbugs.gnu.org id=B71107.171644538627625 (code B ref 71107); Thu, 23 May 2024 06:24:02 +0000 Original-Received: (at 71107) by debbugs.gnu.org; 23 May 2024 06:23:06 +0000 Original-Received: from localhost ([127.0.0.1]:58487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA1qz-0007BV-Iv for submit@debbugs.gnu.org; Thu, 23 May 2024 02:23:05 -0400 Original-Received: from mail-pl1-f174.google.com ([209.85.214.174]:44534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA1qv-0007B8-DS for 71107@debbugs.gnu.org; Thu, 23 May 2024 02:23:04 -0400 Original-Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f32448e8fbso10900215ad.1 for <71107@debbugs.gnu.org>; Wed, 22 May 2024 23:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716445369; x=1717050169; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xrUj6GsiNES4pC8w6X24eBIChPQ7xqaiaZiqlEI9tBM=; b=Nz2ZmNN8I9NPTl/13iAPAgtRY/3iDQiGCbn3uSpKtAUiCu8edp6LybS60HHRRt/egr XD3kzOV7rsd1kXE+FjSRTyFl0rxvhyG78d8T5AseAGhwvjq7a6n01E4a3vM8pGelAqCw HIbKOsw+afMET2YcPq2z11F6fEC5yo8qRhimhDWvoyNNGvf7NBi9hLpAyr7qALG7RMzS Fjjd6dvReyL50h4qidfAY+mYOwMIJscfjMDndAfQDssQTFIG9QWfKBoP6FIRW9YqtrnI kVg+5vyPowKjEyy3TW5w3fudMCDPMFhUA4yxRRcdj4eBkhhZE9lTDh+SuMM90c1MjXCj TV7A== X-Gm-Message-State: AOJu0YwbtnKDPm7h0dPNeUZBaomnLn/UElTDM87RVAzZXovqJyLoVpBV UzHuD6zzeS6uBx6qyIk9qlqvuegv3asmy4aDdtJEnWoC4l12N3BxjxtPna0bqTqsxvoQBM4IovB tpvLGLSqs4CKRbdhy2WtpQZQyhG8+VnCwN2YU1jqv1D0LiIRq X-Google-Smtp-Source: AGHT+IGUdlqw8LwZp5Ewu2Fj1LH88QNBSAa8yPbSQRrelvlAx0VqvZKDodv/ncPzXpV1r4UUjivWH5L+e7s65Q41I4c= X-Received: by 2002:a17:902:64d7:b0:1f3:2204:c4e5 with SMTP id d9443c01a7336-1f32204c607mr37922435ad.17.1716445369327; Wed, 22 May 2024 23:22:49 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285678 Archived-At: --0000000000008414cc0619191486 Content-Type: multipart/alternative; boundary="0000000000008414cb0619191484" --0000000000008414cb0619191484 Content-Type: text/plain; charset="UTF-8" On Thu, 23 May 2024 at 06:35, Jim Porter wrote: > I believe this should already be fixed by commit 7b0f24ab1f9 from > bug#63360. > > However, I didn't bother to account for the case where there may be > multiple entries to remove (I just added a FIXME note since it seemed > like a low priority). If removing multiple duplicates is important to > you, would you be willing to rebase your patch on top of the master > branch? Thanks either way. > Thanks, not sure why I didn't find this when looking for an existing bug, should have checked master first though. Attached the rebased patch. Thanks for fixing this. --0000000000008414cb0619191484 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, 23 May 2024 at 06:35, Jim Porter = <jporterbugs@gmail.com> = wrote:
I believe this should already be fixed by commit 7b0f24ab1f9 from bug#63360= .

However, I didn't bother to account for the case where there may be multiple entries to remove (I just added a FIXME note since it seemed
like a low priority). If removing multiple duplicates is important to
you, would you be willing to rebase your patch on top of the master
branch? Thanks either way.

Thanks, not = sure why I didn't find this when looking for an existing bug, should ha= ve checked master first though.

Attached the rebas= ed patch. Thanks for fixing this.=C2=A0
--0000000000008414cb0619191484-- --0000000000008414cc0619191486 Content-Type: application/octet-stream; name="eshell-hist-ignoredups.patch" Content-Disposition: attachment; filename="eshell-hist-ignoredups.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwiv7rw70 ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwgYi9saXNwL2VzaGVsbC9lbS1oaXN0 LmVsCmluZGV4IDIxMDI5ZWFlMWJjLi5iMTcxYTI4NTBmZiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hl bGwvZW0taGlzdC5lbAorKysgYi9saXNwL2VzaGVsbC9lbS1oaXN0LmVsCkBAIC0zOTgsMTEgKzM5 OCw5IEBAIGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9yeQogICAgICAgICAgICAgIChwY2FzZSBl c2hlbGwtaGlzdC1pZ25vcmVkdXBzCiAgICAgICAgICAgICAgICAoJ25pbCB0KSAgICAgICAgICAg ICAgICAgOyBBbHdheXMgYWRkIHRvIGhpc3RvcnkKICAgICAgICAgICAgICAgICgnZXJhc2UgICAg ICAgICAgICAgICAgICA7IEFkZCwgcmVtb3ZpbmcgYW55IG9sZCBvY2N1cnJlbmNlcwotICAgICAg ICAgICAgICAgICh3aGVuLWxldCAoKG9sZC1pbmRleCAocmluZy1tZW1iZXIgZXNoZWxsLWhpc3Rv cnktcmluZyBpbnB1dCkpKQotICAgICAgICAgICAgICAgICAgOzsgUmVtb3ZlIHRoZSBvbGQgb2Nj dXJyZW5jZSBvZiB0aGlzIGlucHV0IHNvIHdlIGNhbgotICAgICAgICAgICAgICAgICAgOzsgYWRk IGl0IHRvIHRoZSBlbmQuICBGSVhNRTogU2hvdWxkIHdlIHRyeSB0bwotICAgICAgICAgICAgICAg ICAgOzsgcmVtb3ZlIG11bHRpcGxlIG9sZCBvY2N1cnJlbmNlcywgZS5nLiBpZiB0aGUgdXNlcgot ICAgICAgICAgICAgICAgICAgOzsgcmVjZW50bHkgY2hhbmdlZCB0byB1c2luZyBgZXJhc2UnPwor ICAgICAgICAgICAgICAgICh3aGlsZS1sZXQgKChvbGQtaW5kZXggKHJpbmctbWVtYmVyIGVzaGVs bC1oaXN0b3J5LXJpbmcgaW5wdXQpKSkKKyAgICAgICAgICAgICAgICAgIDs7IFJlbW92ZSB0aGUg b2xkIG9jY3VycmVuY2VzIG9mIHRoaXMgaW5wdXQgc28gd2UgY2FuCisgICAgICAgICAgICAgICAg ICA7OyBhZGQgaXQgdG8gdGhlIGVuZC4KICAgICAgICAgICAgICAgICAgIChyaW5nLXJlbW92ZSBl c2hlbGwtaGlzdG9yeS1yaW5nIG9sZC1pbmRleCkpCiAgICAgICAgICAgICAgICAgdCkKICAgICAg ICAgICAgICAgIChfICAgICAgICAgICAgICAgICAgICAgICA7IEFkZCBpZiBub3QgYWxyZWFkeSB0 aGUgbGF0ZXN0IGVudHJ5CmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVz dHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVzdHMuZWwKaW5kZXggYTRlMWUwMWIx MjQuLjQwZTZmOTA0NzhkIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVz dHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1oaXN0LXRlc3RzLmVsCkBAIC0xNjMsNiAr MTYzLDIzIEBAIGVtLWhpc3QtdGVzdC9hZGQtdG8taGlzdG9yeS9lcmFzZS1kdXBzCiAgICAgIChz aG91bGQgKGVxdWFsIChyaW5nLWVsZW1lbnRzIGVzaGVsbC1oaXN0b3J5LXJpbmcpCiAgICAgICAg ICAgICAgICAgICAgICcoImVjaG8gaGkiICJlY2hvIGJ5ZSIpKSkpKSkKIAorKGVydC1kZWZ0ZXN0 IGVtLWhpc3QtdGVzdC9hZGQtdG8taGlzdG9yeS9lcmFzZS1leGlzdGluZy1kdXBzICgpCisgICJU ZXN0IGFkZGluZyB0byBoaXN0b3J5LCBlcmFzaW5nIGFueSBvbGQgZHVwcyBhZnRlciBzd2l0Y2hp bmcgdG8gJ2VyYXNlLiIKKyAgKGxldCAoKGVzaGVsbC1oaXN0LWlnbm9yZWR1cHMgbmlsKSkKKyAg ICAod2l0aC10ZW1wLWVzaGVsbAorICAgICAoZXNoZWxsLWluc2VydC1jb21tYW5kICJlY2hvIGhp IikKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29tbWFuZCAiZWNobyBieWUiKQorICAgICAoZXNoZWxs LWluc2VydC1jb21tYW5kICJlY2hvIGJ5ZSIpCisgICAgIChlc2hlbGwtaW5zZXJ0LWNvbW1hbmQg ImVjaG8gaGkiKQorICAgICAoZXNoZWxsLWluc2VydC1jb21tYW5kICJlY2hvIGJ5ZSIpCisgICAg IChzZXRxIGVzaGVsbC1oaXN0LWlnbm9yZWR1cHMgJ2VyYXNlKQorICAgICAoZXNoZWxsLWluc2Vy dC1jb21tYW5kICJlY2hvIGhpIikKKyAgICAgKHNob3VsZCAoZXF1YWwgKHJpbmctZWxlbWVudHMg ZXNoZWxsLWhpc3RvcnktcmluZykKKyAgICAgICAgICAgICAgICAgICAgJygiZWNobyBoaSIgImVj aG8gYnllIiAiZWNobyBieWUiICJlY2hvIGJ5ZSIpKSkKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29t bWFuZCAiZWNobyBieWUiKQorICAgICAoc2hvdWxkIChlcXVhbCAocmluZy1lbGVtZW50cyBlc2hl bGwtaGlzdG9yeS1yaW5nKQorICAgICAgICAgICAgICAgICAgICAnKCJlY2hvIGJ5ZSIgImVjaG8g aGkiKSkpKSkpCisKIChwcm92aWRlICdlbS1oaXN0LXRlc3QpCiAKIDs7OyBlbS1oaXN0LXRlc3Rz LmVsIGVuZHMgaGVyZQo= --0000000000008414cc0619191486--