From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#74132: Acknowledgement (31.0.50; thing-at-pt, ffap and Github markdown) Date: Sat, 2 Nov 2024 15:04:19 -0700 Message-ID: References: <20241031.160649.1619221016115134543.enometh@meer.net> <20241101.110842.137608817097414398.enometh@meer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6199"; mail-complaints-to="usenet@ciao.gmane.io" To: Madhu , 74132@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 02 23:06:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7MGI-0001UM-Pt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Nov 2024 23:06:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7MFx-0006xv-A7; Sat, 02 Nov 2024 18:06:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7MFw-0006xh-05 for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 18:06:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7MFv-0006xU-NR for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 18:06:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=PsAMJ7B6QzHJuWbtAywGf7mcVEFcITmX33kNuSHfNUw=; b=aPvkMj8AcokgqRDhpxc9zaz0xYyby3279HjlynqZSyif8Dk2laFU8sylGrmbQog1UFwOerPNT/87Ozg+45w+E0/KoVX9YqSCnSuryfk6cj+5rXS6d7GpTKAXBNczCNj8BG08le9UMZ4uKQ5159X3vM+6keUZXgTOUl2ujTDwfYExXae5Nrv+242uwLJQ0ubcxlIGth4yvaUPbog20MbHrCKGdk/khUAw6FkAeBuVejECaWYNhgSxJLo8AA7vmdJOWHsdR2o4ZN3wHGPeCMNhVq3AkQwF4bS6ozIhgR8yEBk2m3b4SH3chg8kU12ZAfHdDVGAjbBq+JND0dXvdRwQHg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t7MFu-0002cT-H4 for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 18:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Nov 2024 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74132-submit@debbugs.gnu.org id=B74132.173058512410045 (code B ref 74132); Sat, 02 Nov 2024 22:06:02 +0000 Original-Received: (at 74132) by debbugs.gnu.org; 2 Nov 2024 22:05:24 +0000 Original-Received: from localhost ([127.0.0.1]:55896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7MFH-0002bx-Tj for submit@debbugs.gnu.org; Sat, 02 Nov 2024 18:05:24 -0400 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:42235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7MFF-0002br-40 for 74132@debbugs.gnu.org; Sat, 02 Nov 2024 18:05:22 -0400 Original-Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5cece886771so832954a12.0 for <74132@debbugs.gnu.org>; Sat, 02 Nov 2024 15:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730585060; x=1731189860; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=PsAMJ7B6QzHJuWbtAywGf7mcVEFcITmX33kNuSHfNUw=; b=O9DLTOiCUIXMeBQncNpUw9pR0pJISYe8k/H1xH30gCMZGP1FPVoqeeMPCb5vmUn12w 9tRU2qc7zsQyfgMQ1/22JMgn02OBZbEAywIAW3NAyMWK/ZEXYk8mLTwwXvvgx9EYmYeA hJo69XUlghOcwsKXaHozPvrvDcEjjv2Opl3G0+HyUnuQD1r2UdAu3rhT8xm7o3MzAH73 IAGpD9ThyFrOxf/Z07ev/Or5Mr5asBGsMZ53+4mXvKeKKbflweB1NhkdW5rP0UhOrqck Bs2X2Cm+1RvSM5K2pWIDrfSPTl0G1vherGKYrxvoLt1wHyBrjl4d0ekggul/YItpmW5N YMMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730585060; x=1731189860; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PsAMJ7B6QzHJuWbtAywGf7mcVEFcITmX33kNuSHfNUw=; b=SXV1VSjAEeXNqDl3UW1fQ+Kzd8cj/hWBhe/ND5iqO2AtU3pPvnqalSE2htJfDFHgDo BBQaBSRW4AzRSiPvL5PNiEDeBR/tCy6bn1s4ZutScYsE4wyWyfQTn9i0QoDBqjcvmFVk OeZIEcfQZsWLbTozCak+wqFUCyxy61/iR3bRgp9nWx9QilenebaDvEUM/uuiIuHaHr8y jfyRj+2BQPzpyg+4CzRS5vJfs7SH4Kmny48XhlZICUvAiUzmVc5rw+DeJEk5xZt5kiij p4DwMttgXZF9yutZxh3ORp0oLQGpQPXlu2KZ5KIlWPcJW+e1J88v+6IpVJNt728EAkKk Gncw== X-Forwarded-Encrypted: i=1; AJvYcCVlpgh0bIGTRpaud950PYSpV/tTeE72m2TVIM53us28UJclYj0zJ2TCGQqdcuTFKy5OrJd8pQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YymbF8xp9jUOMMTxFe8wEoeu/TTKNeW7tubUwJtzfe/+9vXqfGB /aPVPLay/pzb6x5B9u6kNsO8nEd49DlkPMMrRMsHJWmtwUoC0sgUdXEY0mH0jEvNgZ8e1uiRHP2 Pt7/LBu3b/b8MllN5D+Tz5jh1V2u80A== X-Google-Smtp-Source: AGHT+IECYDKOxnnBJvBQR1rK4yNUk7s1WyTSwRSmJzuU5L3xi5xc8vO6afwaAFIgMJcnxoEviEkeUkFf9V6/MEFe1v0= X-Received: by 2002:a05:6402:40c2:b0:5ce:b120:a080 with SMTP id 4fb4d7f45d1cf-5ceb120a12cmr9186825a12.13.1730585060111; Sat, 02 Nov 2024 15:04:20 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Nov 2024 15:04:19 -0700 In-Reply-To: <20241101.110842.137608817097414398.enometh@meer.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294776 Archived-At: Madhu writes: > There was a typo in the patch I posted. It should instead look like this Could you please resend the amended patch as an attachment? Also, how about having some tests for this? > ``` > diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el > --- a/lisp/thingatpt.el > +++ b/lisp/thingatpt.el > @@ -502,9 +502,15 @@ thing-at-point-bounds-of-url-at-point > (let* ((allowed-chars "--:=&?$+@-Z_[:alpha:]~#,%;*()!'[]") > (skip-before "^[0-9a-zA-Z]") > (skip-after ":;.,!?'") > + (hard-beg (and thing-at-point-beginning-of-url-regexp > + (save-excursion > + (and > + (re-search-backward > + thing-at-point-beginning-of-url-regexp nil t) > + (point))))) > (pt (point)) > (beg (save-excursion > - (skip-chars-backward allowed-chars) > + (skip-chars-backward allowed-chars hard-beg) > (skip-chars-forward skip-before pt) > (point))) > (end (save-excursion > ```