From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59793: 29.0.60; subr.elc is not compiled correctly Date: Sun, 10 Sep 2023 12:26:00 -0700 Message-ID: References: <87lenpne48.fsf@163.com> <83cz90erqg.fsf@gnu.org> <87359wr08z.fsf@disroot.org> <0D6CA055-C9DD-425D-9D0B-03B555227E72@gnu.org> <87v8mspfuo.fsf@disroot.org> <83sfhwcq9h.fsf@gnu.org> <87zgc31kov.fsf@disroot.org> <87iliraxlg.fsf@miha-pc> <83k0379ine.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15056"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tumashu@163.com, 59793@debbugs.gnu.org, akib@disroot.org, miha@kamnitnik.top To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 21:27:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfQ5P-0003j8-5N for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 21:27:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfQ5E-0004ZF-Hp; Sun, 10 Sep 2023 15:27:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfQ5D-0004YB-4c for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 15:26:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfQ5C-0000f9-T4 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 15:26:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfQ5G-0004LZ-G6 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 15:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59793 X-GNU-PR-Package: emacs Original-Received: via spool by 59793-submit@debbugs.gnu.org id=B59793.169437397316646 (code B ref 59793); Sun, 10 Sep 2023 19:27:02 +0000 Original-Received: (at 59793) by debbugs.gnu.org; 10 Sep 2023 19:26:13 +0000 Original-Received: from localhost ([127.0.0.1]:51352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfQ4T-0004KL-2E for submit@debbugs.gnu.org; Sun, 10 Sep 2023 15:26:13 -0400 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:51205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfQ4Q-0004Jy-KR for 59793@debbugs.gnu.org; Sun, 10 Sep 2023 15:26:12 -0400 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bf66a32f25so40517341fa.2 for <59793@debbugs.gnu.org>; Sun, 10 Sep 2023 12:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694373961; x=1694978761; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/miTGS4H7iwbChKvYLTQ8AcsMfRPOd/rtoYLjO6xgPI=; b=RKpgkZMtKgLessJXjSR+IqsfvrTxFEFIujEO5SNvHOKKbvq/TN7fjn1ijBOXr0eXFv h6+FauJ6Byn/94PERpOitZ7HWiergCXbzKNEMJXjxel4Ieybwxtp6rwODDN28s/scqqm mTr0AuIQGczIQu8yDJV/CT43pitVysGJdJyTt3jkm+8RPK3Cgpmd7ZN6rfELO8qvJrMq ZzJGPcfehwBMcsSmw5nyly9gTN3gIeJYfzNmjF5B8WDMckZyWYBLh2GkYW/di2JyOf67 O3rg253n+KFeaLkvf0Nz/lp8WNmWa8cYxvvJryieZiPtHT5tmO2/nq4XjNzFwglV6rJW 7ipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694373961; x=1694978761; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/miTGS4H7iwbChKvYLTQ8AcsMfRPOd/rtoYLjO6xgPI=; b=E+ijoG/ZvEyZfZigEG5k8pypg/YCqktJ6guuZZLxEIwlWr9/Zxd+QWkyej5h5ZIYKX CrBmNLTA6v41ycSL+d49YPJRCaeV303qBIOqwOt6JJ5sEfDjPdQAR9MykdLzIzcEZ71V 6kgG9tcIlpqSZYRL00UElgCjyVrCeN+FwxBMkNof3uyBx8pezfwLyQXIUMpwtsuVj5fb TrKiSE7sWtUxnVQqQrAhFhvkqLJ383ATxl618Nmt16Fbq8xHxsF5aJ+6MN7WbN9jqVkw iBh4/h8xd8ESKkLdu70tu2TsfKSCeE980XM85S793t+bollPp1zW/Y0UHl7nn3y4RttI KJxA== X-Gm-Message-State: AOJu0Ywz8dz2KVjvP1Jx2yc+TM/rSD7TH1OQ163sndsN/ApgwKMtEMCz jetUXchu7swMKnqdxDGbq69kQzmmUUx9GXscGiA= X-Google-Smtp-Source: AGHT+IGhL+AVccu/AVrKeAQ3f0fuJ2ZyZhpgDc0Rqvgc5ekaORCjbNQlyoXysJ6GyeZiUFh7XGcunLKBBhY/u1QHpv4= X-Received: by 2002:a05:6512:3b88:b0:500:9734:b415 with SMTP id g8-20020a0565123b8800b005009734b415mr7551873lfv.30.1694373960869; Sun, 10 Sep 2023 12:26:00 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 12:26:00 -0700 In-Reply-To: <83k0379ine.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Dec 2022 19:35:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270000 Archived-At: tags 59793 + notabug close 59793 thanks Eli Zaretskii writes: >> From: miha@kamnitnik.top >> Cc: tumashu@163.com, 59793@debbugs.gnu.org >> Date: Sun, 04 Dec 2022 18:27:07 +0100 >> >> In Emacs 29.0.50, I checked M-x disassemble RET insert-for-yank-1 RET >> and it looks like it uses an 'insert' bytcode operation instead of >> funcalling the 'insert' function. I think this is what prevents >> overriding of 'insert' from working on byte-compiled code, as explained >> in '(elisp) Advice and Byte Code'. > > Of course! And the same can happen with other function calls that the byte > compiler converts into bytecode operations. > > That is why this technique is unreliable and shouldn't be used. This bug report was about redefining built-in functions that have opcodes and then wondering why the bytecode behavior differs from the interpreted. The answer is: don't do that, use add-advice instead. So I'm closing this bug report.