From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master a34650a: Fix sloppy base64 acceptance of some multibyte characters Date: Mon, 20 Dec 2021 13:39:44 -0800 Message-ID: References: <20211220192409.9991.97982@vcs0.savannah.gnu.org> <20211220192410.6BF64209AC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23593"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 20 22:43:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzQRq-0005yh-DJ for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Dec 2021 22:43:58 +0100 Original-Received: from localhost ([::1]:58292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzQRp-000300-9n for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Dec 2021 16:43:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzQNo-000795-GO for emacs-devel@gnu.org; Mon, 20 Dec 2021 16:39:48 -0500 Original-Received: from [2607:f8b0:4864:20::629] (port=41600 helo=mail-pl1-x629.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzQNn-0002hB-33 for emacs-devel@gnu.org; Mon, 20 Dec 2021 16:39:48 -0500 Original-Received: by mail-pl1-x629.google.com with SMTP id z3so4345118plg.8 for ; Mon, 20 Dec 2021 13:39:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=YYz9rq5peUw+xGiisjtDqCkknQvBlgoQzSsoEMJyZYY=; b=ndqkUEEvMaEDZaKyL9DKqEwMZy7jnzFQ8Mt4H0hQPDJeXKkhzg6d7pPdKdR8+MRQfI o9iYl6koozNtGUK+14fD2ndxbn9JZjOxh5yQi8rEtUQg3DXiP6S1A0U6JBAmOfRmraiA FlJhMzvEMREP1xIfVaW/2QvC1w+7rJfJpVV+YcK64M6qdl/AjjcYVn07LPkdiw5VSimv x8FrFOt2PF3aVliNWIlsgP0GrwWyaYY1xWwPOwCFY5nsNnUzoAl3S8aDWx70ASa4fX5U WwotDX6NBeaUylnMq9G2JzX/IEulL/QcIZhGFQG+ZGAhyedCkopodjU0gRqnkFhZR8rt UfIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=YYz9rq5peUw+xGiisjtDqCkknQvBlgoQzSsoEMJyZYY=; b=eRaCKF5wkcCeeS1o74PMsjoCt7hVADOVOpcEkxGUR0lpeE5DernbZQlkKCq6WcnwKk 1s2vWmCLAbnfbjWd0oP51Fo509wTburjb4OxUwejxls6FLysr0pn2RDrfDLqLChl2cy0 +32cHAkuMYWYM6+jAmYVwxPGZ4Z0Nr7DuMtTl7ahShNHrj1IcXbIJgils9qHYnuqUB+c JUnCsML19uY3q4G9cLxnEUcOJ0vYrS0HntE6UaCsq3itcvGFSLEFRNuhNFjSQm4HChSX g3nPk1neJMoTTM1JKaV0c1SO6CMIKqpqOwHc6PpPv900udjV9mdlyUp2s3d4poUN6O4u wb2A== X-Gm-Message-State: AOAM533U+tsJeck6yLijoAOjBjKEY2JRZlI8f2hEdIZ4NTNpdJnz2nTO wSAHEn/OS3mXIdJOeOQw7DGHV0UuGLjaFf8wHME= X-Google-Smtp-Source: ABdhPJxeCFzB4dePmhOjk2+U+Fqx+1TDvVeM7H3nrD5625t2CKl22pQvY8WtDQTrN6gIR4GXjX62X6+ZVd0e9R5uOZ4= X-Received: by 2002:a17:90a:1bc5:: with SMTP id r5mr37345pjr.133.1640036385493; Mon, 20 Dec 2021 13:39:45 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Dec 2021 13:39:45 -0800 In-Reply-To: <20211220192410.6BF64209AC@vcs0.savannah.gnu.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::629 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282542 Archived-At: mattiase@acm.org (Mattias Engdeg=C3=A5rd) writes: > branch: master > commit a34650acff3740980ef23d900d35004bcfe2ef04 > Author: Mattias Engdeg=C3=A5rd > Commit: Mattias Engdeg=C3=A5rd > > Fix sloppy base64 acceptance of some multibyte characters This change (or some other recent change) resulted in these test failures: Running 2 tests (2021-12-20 22:36:49+0100, selector =E2=80=98(not (or (tag :expensive-test) (tag :unstable)))=E2=80=99) Test sasl-scram-sha-1-test backtrace: signal(error ("Multibyte character in data for base64 encoding")) apply(signal (error ("Multibyte character in data for base64 encodin #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name sasl-scram-sha-1-test :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/sasl-scram-rfc-t command-line() normal-top-level() Test sasl-scram-sha-1-test condition: (error "Multibyte character in data for base64 encoding") FAILED 1/2 sasl-scram-sha-1-test (0.143742 sec) Test sasl-scram-sha-256-test backtrace: signal(error ("Multibyte character in data for base64 encoding")) apply(signal (error ("Multibyte character in data for base64 encodin #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name sasl-scram-sha-256-test :documentatio ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/sasl-scram-rfc-t command-line() normal-top-level() Test sasl-scram-sha-256-test condition: (error "Multibyte character in data for base64 encoding") FAILED 2/2 sasl-scram-sha-256-test (0.211032 sec) Ran 2 tests, 0 results as expected, 2 unexpected (2021-12-20 22:36:50+0100, 0.526378 sec) 2 unexpected results: FAILED sasl-scram-sha-1-test FAILED sasl-scram-sha-256-test make[3]: *** [Makefile:187: lisp/net/sasl-scram-rfc-tests.log] Error 1