bug#3479: rgrep sends directories needlessly to grep

bug#3479: rgrep sends directories needlessly to grep

[jidanni]

Gentlemen, I used the same string as e.g.,
(rgrep "bla" "*" "~/mediawiki/")
produced, and instead appended fgrep, and found
$ find . \( -path \*/CVS -o -path \*/.svn -o -path \*/\{arch\} -o -path \*/.hg -o -path \*/_darcs -o -path \*/.git -o -path \*/.bzr \) -prune -o  -type f \( -name \* \)|fgrep -c .svn
62
That's right, 62 .svn's, when you thought you had eliminated them. They
are all directories.

OK, now putting the print inside ( ),
$ cd ~/mediawiki/;find  . -path \*/.svn  -prune -o \( -type f \( -name \* \) -print \)|fgrep .svn
./math/.svnignore
./tests/.svnignore
Which were put there by the staff, so we have indeed eliminated what we
need to!

Therefore consider putting your ...-print0 inside a ( )!

Also only one space is needed between "-o  -type f".

(Of course grep doesn't give an error when given a directory.)

bug#3479: rgrep sends directories needlessly to grep

[Stefan Kangas]

jidanni@jidanni.org writes:

> Gentlemen, I used the same string as e.g.,
> (rgrep "bla" "*" "~/mediawiki/")
> produced, and instead appended fgrep, and found
> $ find . \( -path \*/CVS -o -path \*/.svn -o -path \*/\{arch\} -o -path \*/.hg -o -path \*/_darcs -o -path \*/.git -o -path \*/.bzr \) -prune -o  -type f \( -name \* \)|fgrep -c .svn
> 62
> That's right, 62 .svn's, when you thought you had eliminated them. They
> are all directories.
>
> OK, now putting the print inside ( ),
> $ cd ~/mediawiki/;find  . -path \*/.svn  -prune -o \( -type f \( -name \* \) -print \)|fgrep .svn
> ./math/.svnignore
> ./tests/.svnignore
> Which were put there by the staff, so we have indeed eliminated what we
> need to!
>
> Therefore consider putting your ...-print0 inside a ( )!

This was reported 10 years ago.  If you still remember what it's
about, could you please explain how to reproduce whatever issue this
is inside Emacs?  And what is the issue here exactly?  I'm not sure I
understand.

Thanks in advance.

Best regards,
Stefan Kangas

bug#3479: rgrep sends directories needlessly to grep

[積丹尼 Dan Jacobson]

SK> This was reported 10 years ago.  If you still remember what it's
SK> about, could you please explain how to reproduce whatever issue this
SK> is inside Emacs?  And what is the issue here exactly?  I'm not sure I
SK> understand.

Hard for me to remember too. So I'll close it.

bug#3479: rgrep sends directories needlessly to grep

[Stefan Kangas]

Dan Jacobson <jidanni@jidanni.org> writes:
> Hard for me to remember too. So I'll close it.

Thanks.