From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36453: [PATCH] Delegate to rectangle version in delim-col when appropriate Date: Mon, 1 Jul 2019 01:40:24 +0200 Message-ID: References: <87woj1anpx.fsf@tcd.ie> <87woj117h2.fsf@tcd.ie> <87bm0boifx.fsf@tcd.ie> <87lfz1i3yj.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c2bc49058c930973" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="11012"; mail-complaints-to="usenet@blaine.gmane.org" To: 36453@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 01 01:41:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhjRl-0002kV-8K for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Jul 2019 01:41:25 +0200 Original-Received: from localhost ([::1]:46964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhjRj-0008B3-Jd for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 19:41:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38711) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhjRY-0008Aw-NB for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:41:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhjRT-0000uH-Lr for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:41:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33944) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhjRO-0000sd-K4 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:41:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhjRO-00060C-GS for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 23:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156193805123045 (code B ref -1); Sun, 30 Jun 2019 23:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jun 2019 23:40:51 +0000 Original-Received: from localhost ([127.0.0.1]:47488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhjRC-0005zd-Qu for submit@debbugs.gnu.org; Sun, 30 Jun 2019 19:40:51 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhjRB-0005zW-9v for submit@debbugs.gnu.org; Sun, 30 Jun 2019 19:40:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38660) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhjRA-0008Ae-2k for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:40:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhjR8-0000ks-O8 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:40:48 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:41068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhjR6-0000gG-N2 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 19:40:46 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id c2so11727882wrm.8 for ; Sun, 30 Jun 2019 16:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3qeo2GdumNk/G+YOI4WJMW20FtYYqgc9I+gmMfgVdHA=; b=aCQban8R2tg7TxcqrZvECqoEM3RInaoZ1kRdrLyoAfCtwlIoVDNzFzmTbyghy3STsq iTNFyXgTmp1EWC9DHLnCLebBMuyNHfNKFYMr3bQVFF9gOBC5W1YF2lgbrr3cjMsPdh48 0KIPJZYS4/yJMG6LwUrSGspmTBadEwX8YiIjo94W6vtsIr6ea0EOybV8dufomarsI8ep Tv2lMT3S4stbxAi+PRpdG2LD5RxQumk80GmmxTJ+Ifs3mShIK35dEDAzMh2HFnB62BD6 u3ztEAdg2S1CP3wMXKCREmCNr1APhCO+HmegsMJqJWp8nr8oVfOX62qfE2zh6/xrsn2n p/fw== X-Gm-Message-State: APjAAAUpzzghnQKImIKagm2/63BngvRZUGhBCmypAKfI3nPy618nGAYo EppgxOTX21+5GDs6KVzSJ4btpUS8EsDBNNqJIQCbyA== X-Google-Smtp-Source: APXvYqzABMPSyl2nH5ctXoaDord4o66aanQNWI7gqWZJ1Y1f6GcsJ1LiJnN2OWlKc83qSWnCtn06xrvKi0Kvs6/Vfco= X-Received: by 2002:a5d:4810:: with SMTP id l16mr15121490wrq.48.1561938035381; Sun, 30 Jun 2019 16:40:35 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161919 Archived-At: --000000000000c2bc49058c930973 Content-Type: text/plain; charset="UTF-8" Forwarding this from emacs-devel so it doesn't get lost. Thanks, Stefan Kangas ---------- Forwarded message --------- From: Stefan Kangas Date: tors 30 maj 2019 kl 20:20 Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el Basil L. Contovounesios writes: > > Stefan Monnier writes: > >> BTW, it would be nice to make it so that delimit-columns-region > >> delegates to delimit-columns-rectangle when called with a rectangular > >> region (i.e. using rectangle-mark-mode). > > > > Good idea. How about the second patch attached here? > I'm personally fine with this, but I think NEWS entries usually comprise > a summary on the first line, followed by an elaboration in the body. > I'm not very good at writing these, but here's one way to do that: > > Here's another possibility to reuse an existing NEWS entry under > "Editing Changes": Good thinking. I think the version where we bundle this with other changes is better. But I would suggest to skip the implementation details. See attached patch. Thanks, Stefan Kangas --000000000000c2bc49058c930973 Content-Type: application/x-patch; name="0001-Delegate-to-rectangle-version-in-delim-col-when-appr-2.patch" Content-Disposition: attachment; filename="0001-Delegate-to-rectangle-version-in-delim-col-when-appr-2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwazg88l0 RnJvbSBjZjEyYmFiZmEyN2JlOGY2NDY1NDQ3NGVkOWJiMzIxYzQzNjA5NDhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDExIE1heSAyMDE5IDEyOjE3OjE4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RGVsZWdhdGUgdG8gcmVjdGFuZ2xlIHZlcnNpb24gaW4gZGVsaW0tY29sIHdoZW4gYXBwcm9wcmlh dGUKCiogbGlzcC9kZWxpbS1jb2wuZWwgKGRlbGltaXQtY29sdW1ucy1yZWdpb24pOiBEZWxlZ2F0 ZSB0bwpgZGVsaW1pdC1jb2x1bW5zLXJlY3RhbmdsZScgd2hlbiBjYWxsZWQgd2l0aCBhIHJlY3Rh bmd1bGFyIHJlZ2lvbi4KLS0tCiBldGMvTkVXUyAgICAgICAgICB8ICAzICstCiBsaXNwL2RlbGlt LWNvbC5lbCB8IDkyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgNDUgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA4MTAwNDI3NDAz Li4zYTI0NDEwYzQ1IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNDEz LDcgKzQxMyw4IEBAIGludGVyZmFjZSB0aGF0J3MgbW9yZSBsaWtlIGZ1bmN0aW9ucyBsaWtlICdz ZWFyY2gtZm9yd2FyZCcuCiAKIC0tLQogKiogTW9yZSBjb21tYW5kcyBzdXBwb3J0IG5vbmNvbnRp Z3VvdXMgcmVjdGFuZ3VsYXIgcmVnaW9ucywgbmFtZWx5Ci0ndXBjYXNlLWR3aW0nLCAnZG93bmNh c2UtZHdpbScsICdyZXBsYWNlLXN0cmluZycsICdyZXBsYWNlLXJlZ2V4cCcuCisndXBjYXNlLWR3 aW0nLCAnZG93bmNhc2UtZHdpbScsICdyZXBsYWNlLXN0cmluZycsICdyZXBsYWNlLXJlZ2V4cCcs CithbmQgJ2RlbGltaXQtY29sdW1ucy1yZWdpb24nLgogCiArKysKICoqIFdoZW4gYXNrZWQgdG8g dmlzaXQgYSBsYXJnZSBmaWxlLCBFbWFjcyBub3cgb2ZmZXJzIHZpc2l0aW5nIGl0IGxpdGVyYWxs eS4KZGlmZiAtLWdpdCBhL2xpc3AvZGVsaW0tY29sLmVsIGIvbGlzcC9kZWxpbS1jb2wuZWwKaW5k ZXggM2UzMDllOTE3ZC4uYjNhNzczZTViMCAxMDA2NDQKLS0tIGEvbGlzcC9kZWxpbS1jb2wuZWwK KysrIGIvbGlzcC9kZWxpbS1jb2wuZWwKQEAgLTI2MCw1MCArMjYwLDU0IEBAIGRlbGltaXQtY29s dW1ucy1yZWdpb24KIAogU1RBUlQgYW5kIEVORCBkZWxpbWl0IHRoZSB0ZXh0IHJlZ2lvbi4iCiAg IChpbnRlcmFjdGl2ZSAiKnIiKQotICAobGV0ICgoZGVsaW1pdC1jb2x1bW5zLXN0ci1iZWZvcmUK LQkgKGRlbGltaXQtY29sdW1ucy1zdHIgZGVsaW1pdC1jb2x1bW5zLXN0ci1iZWZvcmUpKQotCShk ZWxpbWl0LWNvbHVtbnMtc3RyLXNlcGFyYXRvcgotCSAoZGVsaW1pdC1jb2x1bW5zLXN0ciBkZWxp bWl0LWNvbHVtbnMtc3RyLXNlcGFyYXRvcikpCi0JKGRlbGltaXQtY29sdW1ucy1zdHItYWZ0ZXIK LQkgKGRlbGltaXQtY29sdW1ucy1zdHIgZGVsaW1pdC1jb2x1bW5zLXN0ci1hZnRlcikpCi0JKGRl bGltaXQtY29sdW1ucy1iZWZvcmUKLQkgKGRlbGltaXQtY29sdW1ucy1zdHIgZGVsaW1pdC1jb2x1 bW5zLWJlZm9yZSkpCi0JKGRlbGltaXQtY29sdW1ucy1hZnRlcgotCSAoZGVsaW1pdC1jb2x1bW5z LXN0ciBkZWxpbWl0LWNvbHVtbnMtYWZ0ZXIpKQotCShkZWxpbWl0LWNvbHVtbnMtc3RhcnQKLSAg ICAgICAgIChpZiAobmF0bnVtcCBkZWxpbWl0LWNvbHVtbnMtc3RhcnQpCi0JICAgICBkZWxpbWl0 LWNvbHVtbnMtc3RhcnQKLQkgICAwKSkKLQkoZGVsaW1pdC1jb2x1bW5zLWVuZAotCSAoaWYgKGlu dGVnZXJwIGRlbGltaXQtY29sdW1ucy1lbmQpCi0JICAgICBkZWxpbWl0LWNvbHVtbnMtZW5kCi0J ICAgMTAwMDAwMCkpCi0JKGRlbGltaXQtY29sdW1ucy1saW1pdCAobWFrZS1tYXJrZXIpKQotCSh0 aGUtZW5kIChjb3B5LW1hcmtlciBlbmQpKQotCWRlbGltaXQtY29sdW1ucy1tYXgpCi0gICAgKHdo ZW4gKDw9IGRlbGltaXQtY29sdW1ucy1zdGFydCBkZWxpbWl0LWNvbHVtbnMtZW5kKQotICAgICAg KHNhdmUtZXhjdXJzaW9uCi0JKGdvdG8tY2hhciBzdGFydCkKLQkoYmVnaW5uaW5nLW9mLWxpbmUp Ci0JOzsgZ2V0IG1heGltdW0gbGVuZ3RoIGZvciBlYWNoIGNvbHVtbgotCShhbmQgZGVsaW1pdC1j b2x1bW5zLWZvcm1hdAotCSAgICAgKHNhdmUtZXhjdXJzaW9uCi0JICAgICAgICh3aGlsZSAoPCAo cG9pbnQpIHRoZS1lbmQpCi0JCSAoZGVsaW1pdC1jb2x1bW5zLXJlY3RhbmdsZS1tYXgKLQkJICAo cHJvZzEKLQkJICAgICAgKHBvaW50KQotCQkgICAgKGVuZC1vZi1saW5lKSkpCi0JCSAoZm9yd2Fy ZC1jaGFyIDEpKSkpCi0JOzsgcHJldHRpZnkgY29sdW1ucwotCSh3aGlsZSAoPCAocG9pbnQpIHRo ZS1lbmQpCi0JICAoZGVsaW1pdC1jb2x1bW5zLXJlY3RhbmdsZS1saW5lCi0JICAgKHByb2cxCi0J ICAgICAgIChwb2ludCkKLQkgICAgIChlbmQtb2YtbGluZSkpKQotCSAgKGZvcndhcmQtY2hhciAx KSkKLQk7OyBudWxsaWZ5IG1hcmtlcnMKLQkoc2V0LW1hcmtlciBkZWxpbWl0LWNvbHVtbnMtbGlt aXQgbmlsKQotCShzZXQtbWFya2VyIHRoZS1lbmQgbmlsKSkpKSkKKyAgKGlmIHJlY3RhbmdsZS1t YXJrLW1vZGUKKyAgICAgIDs7IERlbGVnYXRlIHRvIGRlbGltaXQtY29sdW1ucy1yZWN0YW5nbGUg d2hlbiBjYWxsZWQgd2l0aCBhCisgICAgICA7OyByZWN0YW5ndWxhciByZWdpb24uCisgICAgICAo ZGVsaW1pdC1jb2x1bW5zLXJlY3RhbmdsZSBzdGFydCBlbmQpCisgICAgKGxldCAoKGRlbGltaXQt Y29sdW1ucy1zdHItYmVmb3JlCisgICAgICAgICAgIChkZWxpbWl0LWNvbHVtbnMtc3RyIGRlbGlt aXQtY29sdW1ucy1zdHItYmVmb3JlKSkKKyAgICAgICAgICAoZGVsaW1pdC1jb2x1bW5zLXN0ci1z ZXBhcmF0b3IKKyAgICAgICAgICAgKGRlbGltaXQtY29sdW1ucy1zdHIgZGVsaW1pdC1jb2x1bW5z LXN0ci1zZXBhcmF0b3IpKQorICAgICAgICAgIChkZWxpbWl0LWNvbHVtbnMtc3RyLWFmdGVyCisg ICAgICAgICAgIChkZWxpbWl0LWNvbHVtbnMtc3RyIGRlbGltaXQtY29sdW1ucy1zdHItYWZ0ZXIp KQorICAgICAgICAgIChkZWxpbWl0LWNvbHVtbnMtYmVmb3JlCisgICAgICAgICAgIChkZWxpbWl0 LWNvbHVtbnMtc3RyIGRlbGltaXQtY29sdW1ucy1iZWZvcmUpKQorICAgICAgICAgIChkZWxpbWl0 LWNvbHVtbnMtYWZ0ZXIKKyAgICAgICAgICAgKGRlbGltaXQtY29sdW1ucy1zdHIgZGVsaW1pdC1j b2x1bW5zLWFmdGVyKSkKKyAgICAgICAgICAoZGVsaW1pdC1jb2x1bW5zLXN0YXJ0CisgICAgICAg ICAgIChpZiAobmF0bnVtcCBkZWxpbWl0LWNvbHVtbnMtc3RhcnQpCisgICAgICAgICAgICAgICBk ZWxpbWl0LWNvbHVtbnMtc3RhcnQKKyAgICAgICAgICAgICAwKSkKKyAgICAgICAgICAoZGVsaW1p dC1jb2x1bW5zLWVuZAorICAgICAgICAgICAoaWYgKGludGVnZXJwIGRlbGltaXQtY29sdW1ucy1l bmQpCisgICAgICAgICAgICAgICBkZWxpbWl0LWNvbHVtbnMtZW5kCisgICAgICAgICAgICAgMTAw MDAwMCkpCisgICAgICAgICAgKGRlbGltaXQtY29sdW1ucy1saW1pdCAobWFrZS1tYXJrZXIpKQor ICAgICAgICAgICh0aGUtZW5kIChjb3B5LW1hcmtlciBlbmQpKQorICAgICAgICAgIGRlbGltaXQt Y29sdW1ucy1tYXgpCisgICAgICAod2hlbiAoPD0gZGVsaW1pdC1jb2x1bW5zLXN0YXJ0IGRlbGlt aXQtY29sdW1ucy1lbmQpCisgICAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAgIChnb3Rv LWNoYXIgc3RhcnQpCisgICAgICAgICAgKGJlZ2lubmluZy1vZi1saW5lKQorICAgICAgICAgIDs7 IGdldCBtYXhpbXVtIGxlbmd0aCBmb3IgZWFjaCBjb2x1bW4KKyAgICAgICAgICAoYW5kIGRlbGlt aXQtY29sdW1ucy1mb3JtYXQKKyAgICAgICAgICAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAg ICAgICAgICAgICAod2hpbGUgKDwgKHBvaW50KSB0aGUtZW5kKQorICAgICAgICAgICAgICAgICAg IChkZWxpbWl0LWNvbHVtbnMtcmVjdGFuZ2xlLW1heAorICAgICAgICAgICAgICAgICAgICAocHJv ZzEKKyAgICAgICAgICAgICAgICAgICAgICAgIChwb2ludCkKKyAgICAgICAgICAgICAgICAgICAg ICAoZW5kLW9mLWxpbmUpKSkKKyAgICAgICAgICAgICAgICAgICAoZm9yd2FyZC1jaGFyIDEpKSkp CisgICAgICAgICAgOzsgcHJldHRpZnkgY29sdW1ucworICAgICAgICAgICh3aGlsZSAoPCAocG9p bnQpIHRoZS1lbmQpCisgICAgICAgICAgICAoZGVsaW1pdC1jb2x1bW5zLXJlY3RhbmdsZS1saW5l CisgICAgICAgICAgICAgKHByb2cxCisgICAgICAgICAgICAgICAgIChwb2ludCkKKyAgICAgICAg ICAgICAgIChlbmQtb2YtbGluZSkpKQorICAgICAgICAgICAgKGZvcndhcmQtY2hhciAxKSkKKyAg ICAgICAgICA7OyBudWxsaWZ5IG1hcmtlcnMKKyAgICAgICAgICAoc2V0LW1hcmtlciBkZWxpbWl0 LWNvbHVtbnMtbGltaXQgbmlsKQorICAgICAgICAgIChzZXQtbWFya2VyIHRoZS1lbmQgbmlsKSkp KSkpCiAKIAogOzs7IyMjYXV0b2xvYWQKLS0gCjIuMTEuMAoK --000000000000c2bc49058c930973--