From: Stefan Kangas <stefan@marxist.se>
To: 36453@debbugs.gnu.org
Subject: bug#36453: [PATCH] Delegate to rectangle version in delim-col when appropriate
Date: Mon, 1 Jul 2019 01:40:24 +0200 [thread overview]
Message-ID: <CADwFkmnnoOyojAfCSo-RdSrRvw-tGPaRxFN0zYZeaaj1DCB1xQ@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmk0dWk5BpDubsTQ37sc=pnQD3abGxLNPHFL1mAPNNwLqg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Forwarding this from emacs-devel so it doesn't get lost.
Thanks,
Stefan Kangas
---------- Forwarded message ---------
From: Stefan Kangas <stefan@marxist.se>
Date: tors 30 maj 2019 kl 20:20
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Basil L. Contovounesios <contovob@tcd.ie> writes:
> > Stefan Monnier <monnier@iro.umontreal.ca> writes:
> >> BTW, it would be nice to make it so that delimit-columns-region
> >> delegates to delimit-columns-rectangle when called with a rectangular
> >> region (i.e. using rectangle-mark-mode).
> >
> > Good idea. How about the second patch attached here?
> I'm personally fine with this, but I think NEWS entries usually comprise
> a summary on the first line, followed by an elaboration in the body.
> I'm not very good at writing these, but here's one way to do that:
>
> Here's another possibility to reuse an existing NEWS entry under
> "Editing Changes":
Good thinking. I think the version where we bundle this with other changes is
better. But I would suggest to skip the implementation details. See attached
patch.
Thanks,
Stefan Kangas
[-- Attachment #2: 0001-Delegate-to-rectangle-version-in-delim-col-when-appr-2.patch --]
[-- Type: application/x-patch, Size: 4539 bytes --]
next prev parent reply other threads:[~2019-06-30 23:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 20:56 [PATCH] Unit tests and lexical-binding for delim-col.el Stefan Kangas
2019-05-07 22:44 ` Basil L. Contovounesios
2019-05-07 23:03 ` Noam Postavsky
2019-05-08 7:36 ` Stefan Kangas
2019-05-08 12:00 ` Basil L. Contovounesios
2019-05-08 17:20 ` Stefan Kangas
2019-05-08 20:24 ` Stefan Kangas
2019-05-09 13:39 ` Basil L. Contovounesios
2019-05-09 14:38 ` Stefan Monnier
2019-05-11 10:46 ` Stefan Kangas
2019-05-20 14:40 ` Basil L. Contovounesios
2019-05-30 18:20 ` Stefan Kangas
2019-06-30 23:40 ` Stefan Kangas [this message]
2019-07-08 22:52 ` bug#36453: [PATCH] Delegate to rectangle version in delim-col when appropriate Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnnoOyojAfCSo-RdSrRvw-tGPaRxFN0zYZeaaj1DCB1xQ@mail.gmail.com \
--to=stefan@marxist.se \
--cc=36453@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.