From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Date: Sat, 10 Dec 2022 15:26:03 -0800 Message-ID: References: <83v8mkzrvj.fsf@gnu.org> <83o7sczl1x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000014476105ef8198df" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59920@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 00:27:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p49FS-0008Rv-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 00:27:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p49FJ-00026z-Uo; Sat, 10 Dec 2022 18:27:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p49FG-00026S-Kq for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 18:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p49FG-0000CB-CE for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 18:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p49FG-0001SM-83 for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 18:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 23:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59920-submit@debbugs.gnu.org id=B59920.16707147735559 (code B ref 59920); Sat, 10 Dec 2022 23:27:02 +0000 Original-Received: (at 59920) by debbugs.gnu.org; 10 Dec 2022 23:26:13 +0000 Original-Received: from localhost ([127.0.0.1]:45735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p49ES-0001Rb-Qs for submit@debbugs.gnu.org; Sat, 10 Dec 2022 18:26:13 -0500 Original-Received: from mail-oi1-f172.google.com ([209.85.167.172]:38550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p49EQ-0001RU-FH for 59920@debbugs.gnu.org; Sat, 10 Dec 2022 18:26:11 -0500 Original-Received: by mail-oi1-f172.google.com with SMTP id s186so7973544oia.5 for <59920@debbugs.gnu.org>; Sat, 10 Dec 2022 15:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=OCdvR4BZhDYzSzJl9BifXVzpiSK/Xc3Y1rQH5gYuXAQ=; b=WEfbRW2TbeiCTDFtrbwSsJ+LlevhiOrCuBy+cd4OIXBgCllRpNioknvmlmPp5T18N2 J6mK7SfZe8cAZVOoXjgUeEVpCO+Qx5BKXllQ676EeXoCeeydoHB1dwYWsot4FH5tqaU1 mcVW1zG6Shz/VqCzhTP7+NLBKmW7GPJy6ImrSnR2LxUM/XstNxGMnoaFw93lriylQ5AG 9NOi1PNdBkDH76UqObjg7mPO78OXttMdKB/mg1DynPka442rFXj05gREflAT018Mh+lt Q8fy1mPkQ50g1QKAtxufH788Mgu1vUsog1jEP9bimYTor3jD9Ma8D3sPqMRjOevLfBRK RExg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OCdvR4BZhDYzSzJl9BifXVzpiSK/Xc3Y1rQH5gYuXAQ=; b=LPpAcvWhqunJgzWLHMYKzoPHXCBBLC6BtX2gVVlqALt02/LLzzW34vdfxAvwdH1jt8 7vRoVD4C8oU7zaz6Ft3QJWX6TrXcSk3+j+JYJbe8AHXusMpglOOI/6uHkVxZmVr+gVA9 8nT9+dk7WBRwFPTjPnpXKm3Ax25kKHDouENLuksWwSSLALUB5ENfKlDikSLDpMxjsOri Q94waZE8W5ynx8c1G9nUehE4HJ0MvbUPIJIv/n5PB5TlQ3i9sehpGlzsLTz1gYKz/Nl6 zvhTzRYr0Sc3etJULIFti2b/dLhCc1yvXU6L4kTE25LoYu8Vbz0mmSKYR5muoKPXn18B lmKg== X-Gm-Message-State: ANoB5plm/8fRq91x2UZ+tTmG0saZmzsg7qqPAkMNvzb8QkpoGiX1e8QV ZhK+tFA980Wjjn9Ndll3gYI6+dWJPOTDeJKFs3BurIQV X-Google-Smtp-Source: AA0mqf5rL1eoxEsoqUE98eMynJ71KI5fxBW2/WThNHgZ2oweKfjdHTZyC3OOh60JJ3k+96C0Umg4Vewo8DKQANrAnZo= X-Received: by 2002:a05:6808:989:b0:35e:373e:226a with SMTP id a9-20020a056808098900b0035e373e226amr3018336oic.199.1670714764830; Sat, 10 Dec 2022 15:26:04 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 10 Dec 2022 15:26:03 -0800 In-Reply-To: <83o7sczl1x.fsf@gnu.org> X-Hashcash: 1:20:221210:59920@debbugs.gnu.org::ZNMtuFYfysmMgy0T:587q X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250569 Archived-At: --00000000000014476105ef8198df Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > I just think we should allow turning off this warning. Agreed, thanks. I've added that in the attached. --00000000000014476105ef8198df Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Make-checkdoc-warn-if-not-using-lexical-binding.patch" Content-Disposition: attachment; filename="0001-Make-checkdoc-warn-if-not-using-lexical-binding.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 7ac8b61572cf0386_0.1 RnJvbSAxYTkwZDJiNmYzMjQzMjc0YWYzNDdkM2NmMjk2ZjMyMjkzZjY4Y2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDkgRGVjIDIwMjIgMTA6NTg6MjIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIGNoZWNrZG9jIHdhcm4gaWYgbm90IHVzaW5nIGxleGljYWwtYmluZGluZwoKKiBsaXNwL2Vt YWNzLWxpc3AvY2hlY2tkb2MuZWwgKGNoZWNrZG9jLWZpbGUtY29tbWVudHMtZW5naW5lKToKV2Fy biBpZiB0aGVyZSBpcyBubyBsZXhpY2FsLWJpbmRpbmcgY29va2llLgotLS0KIGV0Yy9ORVdTICAg ICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvY2hlY2tkb2Mu ZWwgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNo YW5nZWQsIDQ3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT CmluZGV4IDBjMWZkZmM0NTQuLjFlZDZhMzExOTcgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBi L2V0Yy9ORVdTCkBAIC03Niw2ICs3NiwxNCBAQCB1c2luZyB0aGlzIG5ldyBvcHRpb24uICAoT3Ig c2V0ICdkaXNwbGF5LWJ1ZmZlci1hbGlzdCcgZGlyZWN0bHkuKQogQWZ0ZXIgbWFudWFsbHkgZWRp dGluZyAnZXNoZWxsLWFsaWFzZXMtZmlsZScsIHlvdSBjYW4gdXNlCiAnTS14IGVzaGVsbC1yZWFk LWFsaWFzZXMtbGlzdCcgdG8gbG9hZCB0aGUgZWRpdGVkIGFsaWFzZXMuCiAKKyoqIGNoZWNrZG9j CisKKy0tLQorKioqIE5ldyBjaGVja2RvY2sgd2FybmluZyBpZiBub3QgdXNpbmcgbGV4aWNhbC1i aW5kaW5nLgorQ2hlY2tkb2Mgbm93IHdhcm5zIGlmIHRoZSBmaXJzdCBsaW5lIG9mIGFuIEVtYWNz IExpc3AgZmlsZSBkb2VzIG5vdAorZW5kIHdpdGggYSAiLSotIGxleGljYWwtYmluZGluZzogdCAt Ki0iIGNvb2tpZS4gIEN1c3RvbWl6ZSB0aGUgdXNlcgorb3B0aW9uICdjaGVja2RvYy1sZXhpY2Fs LWJpbmRpbmctZmxhZycgdG8gbmlsIHRvIGRpc2FibGUgdGhpcyB3YXJuaW5nLgorCiAMCiAqIE5l dyBNb2RlcyBhbmQgUGFja2FnZXMgaW4gRW1hY3MgMzAuMQogCmRpZmYgLS1naXQgYS9saXNwL2Vt YWNzLWxpc3AvY2hlY2tkb2MuZWwgYi9saXNwL2VtYWNzLWxpc3AvY2hlY2tkb2MuZWwKaW5kZXgg M2JkZGI5M2I2NC4uMGEyZDk2ODBmZSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2NoZWNr ZG9jLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9jaGVja2RvYy5lbApAQCAtMTIwLDYgKzEyMCwx NCBAQAogOzsgc2ltcGxlIHN0eWxlIHJ1bGVzIHRvIGZvbGxvdyB3aGljaCBjaGVja2RvYyB3aWxs IGF1dG8tZml4IGZvciB5b3UuCiA7OyBgeS1vci1uLXAnIGFuZCBgeWVzLW9yLW5vLXAnIHNob3Vs ZCBhbHNvIGVuZCBpbiAiPyIuCiA7OworOzsgTGV4aWNhbCBiaW5kaW5nOgorOzsKKzs7ICAgV2Ug cmVjb21tZW5kIGFsd2F5cyB1c2luZyBsZXhpY2FsIGJpbmRpbmcgaW4gbmV3IGNvZGUsIGFuZAor OzsgY29udmVydGluZyBvbGQgY29kZSB0byB1c2UgaXQuICBDaGVja2RvYyB3YXJucyBpZiB5b3Ug ZG9uJ3QgaGF2ZQorOzsgdGhlIHJlY29tbWVuZGVkIHN0cmluZyAiLSotIGxleGljYWwtYmluZGlu ZzogdCAtKi0iIGF0IHRoZSB0b3Agb2YKKzs7IHRoZSBmaWxlLiAgWW91IGNhbiBkaXNhYmxlIHRo aXMgY2hlY2sgd2l0aCB0aGUgdXNlciBvcHRpb24KKzs7IGBjaGVja2RvYy1sZXhpY2FsLWJpbmRp bmctZmxhZycuCis7OwogOzsgQWRkaW5nIHlvdXIgb3duIGNoZWNrczoKIDs7CiA7OyAgIFlvdSBj YW4gZXhwZXJpbWVudCB3aXRoIGFkZGluZyB5b3VyIG93biBjaGVja3MgYnkgc2V0dGluZyB0aGUK QEAgLTMzMCw2ICszMzgsMTIgQEAgY2hlY2tkb2MtY29sdW1uLXplcm8tYmFja3NsYXNoLWJlZm9y ZS1wYXJlbgogICA6dHlwZSAnYm9vbGVhbgogICA6dmVyc2lvbiAiMjguMSIpCiAKKyhkZWZjdXN0 b20gY2hlY2tkb2MtbGV4aWNhbC1iaW5kaW5nLWZsYWcgdAorICAiTm9uLW5pbCBtZWFucyBnZW5l cmF0ZSB3YXJuaW5ncyBpZiBmaWxlIGlzIG5vdCB1c2luZyBsZXhpY2FsIGJpbmRpbmcuCitTZWUg SW5mbyBub2RlIGAoZWxpc3ApIENvbnZlcnRpbmcgdG8gTGV4aWNhbCBCaW5kaW5nJyBmb3IgbW9y ZS4iCisgIDp0eXBlICdib29sZWFuCisgIDp2ZXJzaW9uICIyOS4xIikKKwogOzsgVGhpcyBpcyBo b3cgeW91IGNhbiB1c2UgY2hlY2tkb2MgdG8gbWFrZSBtYXNzIGZpeGVzIG9uIHRoZSBFbWFjcwog Ozsgc291cmNlIHRyZWU6CiA7OwpAQCAtMjM2OSw2ICsyMzgzLDMxIEBAIGNoZWNrZG9jLWZpbGUt Y29tbWVudHMtZW5naW5lCiAJICAgICAgKHBvaW50LW1pbikgKHNhdmUtZXhjdXJzaW9uIChnb3Rv LWNoYXIgKHBvaW50LW1pbikpCiAJCQkJCSAgKGxpbmUtZW5kLXBvc2l0aW9uKSkpKQogCSBuaWwp KQorICAgICAgKHdoZW4gY2hlY2tkb2MtbGV4aWNhbC1iaW5kaW5nLWZsYWcKKyAgICAgICAgKHNl dHEKKyAgICAgICAgIGVycgorICAgICAgICAgOzsgTGV4aWNhbCBiaW5kaW5nIGNvb2tpZS4KKyAg ICAgICAgIChpZiAobm90IChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAgICAgICAgICAgICAoc2F2 ZS1yZXN0cmljdGlvbgorICAgICAgICAgICAgICAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1p bikpCisgICAgICAgICAgICAgICAgICAgICAgKG5hcnJvdy10by1yZWdpb24gKHBvaW50KSAocG9z LWVvbCkpCisgICAgICAgICAgICAgICAgICAgICAgKHJlLXNlYXJjaC1mb3J3YXJkCisgICAgICAg ICAgICAgICAgICAgICAgIChyeCAiLSotIiAoKiAoKiBub25sKSAiOyIpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAoKiBzcGFjZSkgImxleGljYWwtYmluZGluZzoiICgqIHNwYWNlKSAidCIg KCogc3BhY2UpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAoKiAiOyIgKCogbm9ubCkpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAiLSotIikKKyAgICAgICAgICAgICAgICAgICAgICAg bmlsIHQpKSkpCisgICAgICAgICAgICAgKGxldCAoKHBvcyAoc2F2ZS1leGN1cnNpb24gKGdvdG8t Y2hhciAocG9pbnQtbWluKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoZ290by1jaGFyIChwb3MtZW9sKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAocG9pbnQpKSkpCisgICAgICAgICAgICAgICAoaWYgKGNoZWNrZG9jLXktb3Itbi1w ICJUaGVyZSBpcyBubyBsZXhpY2FsLWJpbmRpbmcgY29va2llISAgQWRkIG9uZT8iKQorICAgICAg ICAgICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAgICAgICAgICAgKGdvdG8tY2hhciBwb3Mp CisgICAgICAgICAgICAgICAgICAgICAoaW5zZXJ0ICIgIC0qLSBsZXhpY2FsLWJpbmRpbmc6IHQg LSotIikpCisgICAgICAgICAgICAgICAgIChjaGVja2RvYy1jcmVhdGUtZXJyb3IKKyAgICAgICAg ICAgICAgICAgICJUaGUgZmlyc3QgbGluZSBzaG91bGQgZW5kIHdpdGggXCItKi0gbGV4aWNhbC1i aW5kaW5nOiB0IC0qLVwiIgorICAgICAgICAgICAgICAgICAgcG9zICgxKyBwb3MpIHQpKSkKKyAg ICAgICAgICAgbmlsKSkpCiAgICAgICAoc2V0cQogICAgICAgIGVycgogICAgICAgIChvcgotLSAK Mi4zNS4xCgo= --00000000000014476105ef8198df--