From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Sun, 19 Sep 2021 23:09:51 -0700 Message-ID: References: <875yuvlrz3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36072"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen , Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 08:11:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSCWZ-0009CW-H5 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 08:11:31 +0200 Original-Received: from localhost ([::1]:44848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSCWY-0007jr-KH for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 02:11:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSCV2-0005sw-1I for emacs-devel@gnu.org; Mon, 20 Sep 2021 02:09:56 -0400 Original-Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:33737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSCUz-0002xj-8r for emacs-devel@gnu.org; Mon, 20 Sep 2021 02:09:55 -0400 Original-Received: by mail-pg1-x533.google.com with SMTP id u18so16332861pgf.0 for ; Sun, 19 Sep 2021 23:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=dIDCrnwqet9H17hJCv+3aFFNSaxbmQvwHyFplZcG3Kg=; b=HUh7UIDYnHcqP+FMJSgOVSPyVdF+aTz6/W//A2K6ZYdj72+GWZoDp1VC+CVHrYw9cV KrmmlgGETGo9i8dSP9JlFgfOber6AZ70VeZYh6E5I5Qz/MbXlfh0Rp5/vxmhXq/Mm3KS OnzWlcrSXouM1aPKkAU5eAdhuyFlloaIWQbGdIvtKe8wTK22SKksnp2L7rNVcD3o6cpX NRijDi3VZ2bC8VZCOAiUx057MfqaXYI4zSdSVlF90X1ZKXI7zeEMKY0aS+lKZCqxJov/ uG4vI/mtbICnQX8S9KTXfYaD1XcqlnlHjbN0LHmBJetELEzfwb0tNK3Mt269sErfqBN8 oV4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=dIDCrnwqet9H17hJCv+3aFFNSaxbmQvwHyFplZcG3Kg=; b=4NRpVC+XxHbvOeRdPUc7shdHrNJHOgUfQvOwGAYIFkRFgGNc/BJOLuT7Uk/aDJLHjo A0YNp/WActv3Kzpx+CDhpnLjLxo/kQTsWaALcDbJ1GcGcQ7bdjWKP4HBWr7ILCNxF2e+ rVf74MuN1AcQz3qu3Eg/ZdC6GwX6r4JBywLTj8xh7bRK3FfrFDzVaWHYJJkyqU+1HgGt Lr0IVmfLdOqS/5O/I5InarSCikOmk91RSuVkV7FPS91cGvYDwJEex3ACZPbo5aNeJha9 foJZJXB5klJB6veRq5C8sknHHnIZrYBswicCYDtP+JTNQn38cfpNzChUdI151jOgxn77 nEJA== X-Gm-Message-State: AOAM533ojh9dkdxFsnPraB31fCq5T8nn+d52+RDETbXafNUsNT0SbT/t NKzcq/MYngcOIsqJV/mNPft47JgbP1HQDlKzyMU= X-Google-Smtp-Source: ABdhPJxS1x3UdHnfK2fPgbdUpWJvoama+powsxR6JAec6x90zNw2gBDOB+uPKoGZapd6pqu6OYRbMiHBCBw+O1AYtCQ= X-Received: by 2002:a63:a311:: with SMTP id s17mr21564260pge.359.1632118191569; Sun, 19 Sep 2021 23:09:51 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 23:09:51 -0700 In-Reply-To: <875yuvlrz3.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=stefankangas@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275103 Archived-At: Lars Ingebrigtsen writes: > I haven't tried the patch, but this is for showing the source code of > the function/variable in question in the *Help* buffer? I'm not quite > sure I understand the utility of that -- if you want to look at the > source, you can just hit the `s' key. And then you get all the proper > language-related Emacs stuff in that buffer -- looking at sources is > usually nicer in the correct major mode than in other buffers. > > So I don't understand who'd want this. I believe this is a feature in helpful.el: https://github.com/Wilfred/helpful/blob/master/screenshots/helpful_source.png FWIW, I personally also ask myself why/how this is useful. Is it because some users don't know that you can get to the source code? That said, I don't see any reason not to have this as an optional feature, if some users find that it works well for them.