357d273d breaks bootstrap

357d273d breaks bootstrap

[Po Lu]

This happens when building isearch.el:

Loading /home/src/emacs/lisp/international/uni-special-titlecase.el (source)...
File mode specification error: (error Recursive load /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el)

P.S. what is the immediate necessity for these changes?  IMO, removing
such redundant syntax should be delegated to the same priority as
whitespace changes.

Thanks.

Re: 357d273d breaks bootstrap

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> This happens when building isearch.el:
>
> Loading /home/src/emacs/lisp/international/uni-special-titlecase.el (source)...
> File mode specification error: (error Recursive load /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el /home/src/emacs/lisp/international/uni-special-lowercase.el)

I can't reproduce this.  Did you try "make bootstrap"?

Re: 357d273d breaks bootstrap

[Po Lu]

Stefan Kangas <stefankangas@gmail.com> writes:

> Po Lu <luangruo@yahoo.com> writes:

> I can't reproduce this.  Did you try "make bootstrap"?

Yes, I did.  But I just pulled and did "make bootstrap" again, and it
works now.

Thanks.

Re: 357d273d breaks bootstrap

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Po Lu <luangruo@yahoo.com> writes:
>
>> I can't reproduce this.  Did you try "make bootstrap"?
>
> Yes, I did.  But I just pulled and did "make bootstrap" again, and it
> works now.

I've now been able to reproduce it, but I've been struggling to
understand why.  The problem seems to manifest itself when I switch
between the master and emacs-28 branch.

I've therefore reverted any part of that commit that looked even
remotely suspicious to me, and that seems to have fixed it.  If anyone
has built meanwhile are experiencing any issues, I suggest
"make extraclean && make bootstrap", which should resolve it.

Sorry for any trouble this caused.

Re: 357d273d breaks bootstrap

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Date: Fri, 22 Oct 2021 08:34:51 +0800
> 
> P.S. what is the immediate necessity for these changes?  IMO, removing
> such redundant syntax should be delegated to the same priority as
> whitespace changes.

I agree, FWIW.

Re: 357d273d breaks bootstrap

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> I agree, FWIW.

Yes.  Some of these changes make life very difficult for people to find
the source of changes via `git blame', and in general cause me quite the
hassle when rebasing, for instance, the Haiku port I'm working on.

Thanks.

Re: 357d273d breaks bootstrap

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> I agree, FWIW.

Point taken.

Re: 357d273d breaks bootstrap

[Glenn Morris]

Stefan Kangas wrote:

> "make extraclean && make bootstrap", which should resolve it.

Or make bootstrap-clean in admin/unidata/Makefile.in and elsewhere run
gen-clean, as I have previously recommended.