From: Stefan Kangas <stefan@marxist.se>
To: Juri Linkov <juri@linkov.net>
Cc: 52518@debbugs.gnu.org
Subject: bug#52518: Log only vc-command-messages
Date: Thu, 16 Dec 2021 10:01:22 -0800 [thread overview]
Message-ID: <CADwFkmnkrYoLE4ocQR9bUHkpw9iSG5z1ykNwjXx_a9mP4vEQfw@mail.gmail.com> (raw)
In-Reply-To: <8635ms8ryd.fsf@mail.linkov.net>
Juri Linkov <juri@linkov.net> writes:
> I agree these should be refactored. I was unsure if selected-window
> changes during function execution, but this would be better:
Thanks. Some documentation comments:
> diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el
> index 346974bdba..4adc01fbfc 100644
> --- a/lisp/vc/vc-dispatcher.el
> +++ b/lisp/vc/vc-dispatcher.el
> @@ -127,8 +127,12 @@ vc-delete-logbuf-window
> :group 'vc)
>
> (defcustom vc-command-messages nil
> - "If non-nil, display run messages from back-end commands."
> - :type 'boolean
> + "If non-nil, log run messages from back-end commands.
> +If `log', messages are logged to the *Messages* buffer, but not displayed.
> +Other non-nil values also display run messages in the echo area."
Would this be simpler?
If non-nil, display and log run messages from back-end commands.
If `log', messages are logged to the *Messages* buffer but not
displayed.
> + :type '(choice (const :tag "No display and no log" nil)
> + (const :tag "Display and log messages" t)
> + (const :tag "Only log messages without displaying" log))
Perhaps the first one could be:
No messages
Perhaps the last one could be:
Log messages
next prev parent reply other threads:[~2021-12-16 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 17:31 bug#52518: Log only vc-command-messages Juri Linkov
2021-12-15 22:02 ` Stefan Kangas
2021-12-16 17:15 ` Juri Linkov
2021-12-16 18:01 ` Stefan Kangas [this message]
2021-12-16 19:17 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnkrYoLE4ocQR9bUHkpw9iSG5z1ykNwjXx_a9mP4vEQfw@mail.gmail.com \
--to=stefan@marxist.se \
--cc=52518@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.