From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59137: [PATCH] To minor changes related to overlays Date: Wed, 30 Nov 2022 02:28:09 +0100 Message-ID: References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> <87h6yhpd1b.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier , 59137@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 02:29:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0Bui-00032F-W2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 02:29:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0BuL-00087W-J2; Tue, 29 Nov 2022 20:29:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0BuJ-00086l-9u for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 20:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0BuJ-0001EF-1g for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 20:29:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0BuI-0005g5-TY for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 20:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 01:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59137 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59137-submit@debbugs.gnu.org id=B59137.166977170821789 (code B ref 59137); Wed, 30 Nov 2022 01:29:02 +0000 Original-Received: (at 59137) by debbugs.gnu.org; 30 Nov 2022 01:28:28 +0000 Original-Received: from localhost ([127.0.0.1]:57646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Btk-0005fN-C8 for submit@debbugs.gnu.org; Tue, 29 Nov 2022 20:28:28 -0500 Original-Received: from mail-oi1-f179.google.com ([209.85.167.179]:38589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Bti-0005fG-A2 for 59137@debbugs.gnu.org; Tue, 29 Nov 2022 20:28:27 -0500 Original-Received: by mail-oi1-f179.google.com with SMTP id b126so2740168oif.5 for <59137@debbugs.gnu.org>; Tue, 29 Nov 2022 17:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PetJYibxEklc8SWkRozOG3JQ/IfyGGxVT7BvIAzWB6E=; b=IcLiVs9AVsImPPM8yu5lT9PRrFc+5XF+2qJIhpdNa1ezl3IJQcdpcjT/B0oHPzrkv+ Mib8xGnM7HqAfXbf9G2zuh/xuBn1j1iOzZips3cxrC+KFs1eUuA8ofTR0Z3dL8tVlFtp +H9YYg9AkPWxo6PAWhNMrUvYxaa00uaBh5GAhbdbmDxwsDOE7/xU2si9oxBUG6hwPOCz vzlaxh+JnjKnzYr+BnzQ/d/9kcem2QIIokJLyOUwJdsrnXj4sLEHAKvpeoYOmhAYeXNI pkyaXBOy63tXG2ms5YE9ItDyp5eNEkUu9ArXcuVb+QW1aINO+/jEZwHi556Bj8DCdhbf QltA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PetJYibxEklc8SWkRozOG3JQ/IfyGGxVT7BvIAzWB6E=; b=d5/0jm2JFUvvAIGGENqLnN3toqsYqLAQKusxf52IhTfDSAw/tJCzVH0p2Rb769X+OS 3/ZM60uU+c3+Jg7QPbpNEQNMt/IlPW4Qg/brcBLeWYosl+tf3hcJNASAZLEa3Krg3bZ1 Q+mpko99SZlXg98MODcqdrubZjMIOObEctnXiX26xwx465TU31G3p/eyGa8Nt+lFkNoQ bUdOii5LNKDUvclIQdVa+AyU4SjtppfdMRqHjEMXkyRQndUXJEmO2ZkVYCcmxdc7kinL YJVrcbNsoriCrzn0CNHT4ESXbrosnGhiU0F14ddrK1BUd8cyoG8wxp3ds7FtP0Er3ftk 1Vkw== X-Gm-Message-State: ANoB5pkph0czBI3r+ksCpzZYUOvnRgbALrjpBe+ml7F1hhNteoCZZ2Vf D70E/N431iRfPYVtAI+uaz/1LVOYEVBdYQqOTQg= X-Google-Smtp-Source: AA0mqf4kifkJyeNXrw+n8DoBovc11RpGlRVCQGKAP2dTXeoI1K4pu0/WDG5ZfqS8qLMPf+wcqrFbwhfSHUrdfxGjzyU= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr19702156oiw.92.1669771700478; Tue, 29 Nov 2022 17:28:20 -0800 (PST) In-Reply-To: <87h6yhpd1b.fsf@rfc20.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249461 Archived-At: Matt Armstrong writes: > The admittedly redundant NULL check done by itree_empty_p does not > change semantics or cause harm. mark_overlays in alloc.c is a recursive > function so it handles NULL itself, hence the NULL check was omitted in > the original code. Thanks. I guess as this is a minor cleanup this should go to master at this point.