From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Date: Fri, 9 Dec 2022 04:42:00 -0800 Message-ID: References: <83v8mkzrvj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30250"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59920@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 13:44:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3cjk-0007bb-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 13:44:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3cjP-0003wj-Nz; Fri, 09 Dec 2022 07:43:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ciU-0003kT-Fx for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 07:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3ciU-0005hK-6U for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 07:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3ciT-0001EG-SL for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 07:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59920-submit@debbugs.gnu.org id=B59920.16705897284716 (code B ref 59920); Fri, 09 Dec 2022 12:43:01 +0000 Original-Received: (at 59920) by debbugs.gnu.org; 9 Dec 2022 12:42:08 +0000 Original-Received: from localhost ([127.0.0.1]:35896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3chc-0001E0-69 for submit@debbugs.gnu.org; Fri, 09 Dec 2022 07:42:08 -0500 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:45953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3cha-0001Dd-LD for 59920@debbugs.gnu.org; Fri, 09 Dec 2022 07:42:07 -0500 Original-Received: by mail-ot1-f50.google.com with SMTP id l8-20020a056830054800b006705fd35eceso2690686otb.12 for <59920@debbugs.gnu.org>; Fri, 09 Dec 2022 04:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=aFD+rulNV+mlC4gkJB8FzKzm6w3eEYRqwnypL6fk+10=; b=lwy1a1Aok+BaOqG4S8122yhQDEdKASyIBDoLmMDXqwJC63edmUXB4ZGbHTu0QCe27W kQneK23y9LnPN9DpA6oke7ZoGmFptReeXkS+CY7br6tRLAy63E0s0THBXWf7WxcCEzZc u+t7afihjfPQMIWdBnXXisnCFBFNh5vCzL+1fzgj2o/4p+K2zJZ8Ku9vtLlXlt5Zwo9y WnfJL+2oB+HTCGm0tKMrt7c4nJ5pbL42DU6HzwmCH6fgoURZuSUPlctQd8ZqxYDZ1jk5 Mjyt7MOxRVdx1Zh9T7XOLttwgJzu6bIIDryElERufoBQeLWkcBZbzImAZsNNZk9IZyPt LRNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aFD+rulNV+mlC4gkJB8FzKzm6w3eEYRqwnypL6fk+10=; b=vPbvD4MvYHRT8jpx5JPiqa50O/dYvMSw4RzS+ORh+ksT0rSYxgJE+bcZ96N3YkgbMe FDA8ksqae/HBQyOQyev3iDuZP2gmDO5HMg0YtJmNIT99SMAj+18TdbtK85ntdmfagM7Y Ol+g9DOw0WD6HKoIitf2pWuRm4ncToJiRvByj3LSyhJgrMX+7B8y/tNUfx+Rny/f9T0b ApWd4zECWnNVnspXVtIbs64MaTk3DBR9ScSZ+v+mvCc6BeyxtOkmpUHZN80LFzi3kpc/ tr5LKMJZhuQj9YGusuwcxWWmf3m/xy1nDDF8vslTvUmDMN7fJeAd8YBGNnYKpOSuhowM qJkA== X-Gm-Message-State: ANoB5pk6/UF+k2RxboW0YIO7LYigi68uzEcY3xgdb93Fe0QfGwshW7zG kYM6xczdk6kgdAX63SU45PA1p6xEU4DceZGPbdepmDdY X-Google-Smtp-Source: AA0mqf7hQm/yU6qEZpBJjnC9PfLAVIMzb5fbn+rYqxvK2ezdtUj/lCQHZmfWuPotCULRgYXOEyItg3nPeunUF6xJojw= X-Received: by 2002:a05:6830:11cd:b0:66e:7741:ed1d with SMTP id v13-20020a05683011cd00b0066e7741ed1dmr10884609otq.224.1670589721012; Fri, 09 Dec 2022 04:42:01 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Dec 2022 04:42:00 -0800 In-Reply-To: <83v8mkzrvj.fsf@gnu.org> X-Hashcash: 1:20:221209:eliz@gnu.org::BIqeb5rE2E+PIYJE:C5yR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250390 Archived-At: Eli Zaretskii writes: > Thanks, but I think this should be optional behavior. checkdoc is not > only used by us. The idea here is to encourage others to upgrade to lexical-binding, as we are already done (at least in emacs.git, if not yet in GNU ELPA). I'm actually more concerned that this check will not reach enough users. So while I think an option is a good idea, the best default is IMO to have it enabled.