From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36707: [PATCH] Signal user-error on duplicate package refresh Date: Mon, 12 Aug 2019 02:35:28 +0200 Message-ID: References: <874l3j11v4.fsf@tcd.ie> <87lfw3qjle.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197317"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "Basil L. Contovounesios" , 36707@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 12 02:36:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwyJj-000p9k-W2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Aug 2019 02:36:08 +0200 Original-Received: from localhost ([::1]:42236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwyJi-00009R-Dv for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 20:36:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47759) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwyJe-000096-O3 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 20:36:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwyJd-0002W6-SO for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 20:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwyJd-0002W1-Pe for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 20:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwyJd-0002HN-Mt for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 20:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Aug 2019 00:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36707-submit@debbugs.gnu.org id=B36707.15655701518741 (code B ref 36707); Mon, 12 Aug 2019 00:36:01 +0000 Original-Received: (at 36707) by debbugs.gnu.org; 12 Aug 2019 00:35:51 +0000 Original-Received: from localhost ([127.0.0.1]:45930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwyJS-0002Gu-Jj for submit@debbugs.gnu.org; Sun, 11 Aug 2019 20:35:50 -0400 Original-Received: from mail-pf1-f180.google.com ([209.85.210.180]:44844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwyJN-0002GB-Dn for 36707@debbugs.gnu.org; Sun, 11 Aug 2019 20:35:47 -0400 Original-Received: by mail-pf1-f180.google.com with SMTP id t16so48833908pfe.11 for <36707@debbugs.gnu.org>; Sun, 11 Aug 2019 17:35:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uonQlQYnwWP3mhSaOCh1uPK3u1g0tXPG9H6DFN2Xcfw=; b=TnLLEjCTfrEIaj5DGj/ghCPEaMts9PXHky0rZ6Hg698AcR3pRWiCvNEgP+a6G2CVK6 TlL0Iu3uHicOVajcbv71G+yg5zWid5+UOTpPBUIci7nqt8BM77bi4hgAkysv/NN/Bx93 i5QYzCcJVMOBHoPgamjGFhlFwv179D9i/8QupIe83a5EuRxq4v9ONOnI4ctN3u8uzOHZ ut1NMoct4qonYPuVrTjywvEIs9BPeOhJEWq5/cb+I7AnPP8+jZptVzegm1dtlEATcRJ+ XQKU0OO34NiKBksP9xIiY+2qsyLBMD4yODorbIcgpHrHNaMXrsecRW94OoEM6p10Z0YS IjOw== X-Gm-Message-State: APjAAAVLrFWOR82OLkU+xVNuZBvx0PhqdLi+pa2M6xxiMpGpQU+up+7y 7IgX9JzePdF2bpdrxz2jDjaqTtxAcd8Xzl7YZI4= X-Google-Smtp-Source: APXvYqy3hyQ7G4IdD+VHxPCw1t86CCzJuQM3IkRHEJ6bfCEWsB+8N6YrnDmBQwbkfTzBgvu4pCmMX92ejrrqUOuNTZ0= X-Received: by 2002:a63:5f01:: with SMTP id t1mr2107757pgb.200.1565570139702; Sun, 11 Aug 2019 17:35:39 -0700 (PDT) In-Reply-To: <87lfw3qjle.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164899 Archived-At: Noam Postavsky writes: > "Basil L. Contovounesios" writes: > > > Stefan Kangas writes: > > > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times > >> it will try to initiate more refreshes even if the first one has not finished > >> yet. This is unnecessary and potentially confusing. > >> > >> This patch makes it check if there is already an refresh in progress and signal > >> a user-error if there is one. > > > > Would it not be possible/better to discard the existing refresh and > > start a new one, instead of signalling an error? This would help > > e.g. when a refresh hangs for whatever reason. > > Not sure if it's better, supposing the user is hitting "r" repeatedly, > that just interrupts the pending refreshes, preventing any progress. I > would expect hanging to be cancelled by a timeout anyway. I agree with Noam that a timeout would make more sense. Not sure if it already exists or if that's a separate issue. Thanks, Stefan Kangas