all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Noam Postavsky <npostavs@gmail.com>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, 36707@debbugs.gnu.org
Subject: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Mon, 12 Aug 2019 02:35:28 +0200	[thread overview]
Message-ID: <CADwFkmncYgGq2mGrpzbdZLXSOzwb0Ufr4=tSjp7qMr7S5MhWXA@mail.gmail.com> (raw)
In-Reply-To: <87lfw3qjle.fsf@gmail.com>

Noam Postavsky <npostavs@gmail.com> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
> > Stefan Kangas <stefan@marxist.se> writes:
> >
> >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
> >> it will try to initiate more refreshes even if the first one has not finished
> >> yet.  This is unnecessary and potentially confusing.
> >>
> >> This patch makes it check if there is already an refresh in progress and signal
> >> a user-error if there is one.
> >
> > Would it not be possible/better to discard the existing refresh and
> > start a new one, instead of signalling an error?  This would help
> > e.g. when a refresh hangs for whatever reason.
>
> Not sure if it's better, supposing the user is hitting "r" repeatedly,
> that just interrupts the pending refreshes, preventing any progress.  I
> would expect hanging to be cancelled by a timeout anyway.

I agree with Noam that a timeout would make more sense.  Not sure if
it already exists or if that's a separate issue.

Thanks,
Stefan Kangas





  reply	other threads:[~2019-08-12  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 18:02 bug#36707: [PATCH] Signal user-error on duplicate package refresh Stefan Kangas
2019-07-17 18:10 ` Stefan Kangas
2019-07-18 21:14 ` Basil L. Contovounesios
2019-08-09  0:16   ` Noam Postavsky
2019-08-12  0:35     ` Stefan Kangas [this message]
2019-08-18 18:18       ` Stefan Kangas
2019-08-22 17:04         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmncYgGq2mGrpzbdZLXSOzwb0Ufr4=tSjp7qMr7S5MhWXA@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=36707@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.