From: Stefan Kangas <stefan@marxist.se>
To: 41385@debbugs.gnu.org
Cc: larsi@gnus.org
Subject: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty
Date: Mon, 18 May 2020 17:51:06 -0700 [thread overview]
Message-ID: <CADwFkmn_N69_=diF=Ck91fitWT3AFe_dguL_Eg5=Ab0TR51EPg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
Severity: minor
X-Debbugs-CC: larsi@gnus.org
Please see the attached patch which fixes a minor annoyance with
eww-list-bookmarks.
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]
From ff5c8120955a8c0a23cafe5e0cb6821dc154f72a Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 19 May 2020 02:43:16 +0200
Subject: [PATCH] Show eww bookmarks buffer only if it's not empty
* lisp/net/eww.el (eww-list-bookmarks): Don't show buffer if there
are no bookmarks.
---
lisp/net/eww.el | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index a6c1abdbb1..f24ada6287 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1754,8 +1754,13 @@ eww-read-bookmarks
(defun eww-list-bookmarks ()
"Display the bookmarks."
(interactive)
- (pop-to-buffer "*eww bookmarks*")
- (eww-bookmark-prepare))
+ (let ((buf (get-buffer-create "*eww bookmarks*")) no-error)
+ (unwind-protect
+ (progn
+ (pop-to-buffer buf)
+ (eww-bookmark-prepare)
+ (setq no-error t))
+ (when (not no-error) (kill-buffer buf)))))
(defun eww-bookmark-prepare ()
(eww-read-bookmarks)
--
2.26.2
next reply other threads:[~2020-05-19 0:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 0:51 Stefan Kangas [this message]
2020-05-19 12:34 ` bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty Lars Ingebrigtsen
2020-05-20 3:44 ` Stefan Kangas
2020-06-10 15:25 ` Lars Ingebrigtsen
2020-07-17 1:24 ` Lars Ingebrigtsen
2020-07-29 10:29 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmn_N69_=diF=Ck91fitWT3AFe_dguL_Eg5=Ab0TR51EPg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=41385@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.