From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62751: 29.0.90; New libraries that still need to be assigned to packages Date: Sun, 1 Oct 2023 10:46:13 -0700 Message-ID: References: <87zg7fyjka.fsf@bernoul.li> <87wmwobgk6.fsf@bernoul.li> <87msxjzeyq.fsf@bernoul.li> <83jzs68n08.fsf@gnu.org> <83il7q8evg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17105"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jonas@bernoul.li, monnier@iro.umontreal.ca, 62751@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 01 19:47:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qn0X2-00044W-P5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Oct 2023 19:47:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qn0Wl-0000v8-S6; Sun, 01 Oct 2023 13:46:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qn0Wk-0000uv-HU for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2023 13:46:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qn0Wk-0005RZ-91 for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2023 13:46:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qn0X0-0002Q3-2I for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2023 13:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Oct 2023 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62751 X-GNU-PR-Package: emacs Original-Received: via spool by 62751-submit@debbugs.gnu.org id=B62751.16961824009263 (code B ref 62751); Sun, 01 Oct 2023 17:47:02 +0000 Original-Received: (at 62751) by debbugs.gnu.org; 1 Oct 2023 17:46:40 +0000 Original-Received: from localhost ([127.0.0.1]:35242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn0We-0002PH-Au for submit@debbugs.gnu.org; Sun, 01 Oct 2023 13:46:40 -0400 Original-Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:45310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn0Wb-0002P0-LO for 62751@debbugs.gnu.org; Sun, 01 Oct 2023 13:46:38 -0400 Original-Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c12ae20a5cso244686801fa.2 for <62751@debbugs.gnu.org>; Sun, 01 Oct 2023 10:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696182375; x=1696787175; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=RDT0FO2WmWry1NL7XguKYRm7DpMahEsgX02BHeWbcOg=; b=JE9ATchJ0d6FAyW0zle3+WJarucsJlgb45FXyCyJt3O81yTxoCFjvhtHug41myI1Ep 0kKaK+ey/kTt7kHRibg6uky0blUnA5ref8XBvfk9If6w83aXwtYVPMNOgwAS82asJRqt sMRWCJ0yeQdqjFkchJvs6j+wSHAuMuwGyPDeBI04MA3tVhRgjBC8AFvTUTkfdOvgz7Ml EILUsSbjorIuPWyBc4VDyGHnVYZmY97jGj6V1M7dH+6B7xKFaRiCTz8hH0awENrEWg+x zVxiZhYBMuCTOqULXn6c+bMIXli4EdVodm6HuSLPLs5V4sdxGzMOYVrCuPjJJHVX+xjP fKWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696182375; x=1696787175; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RDT0FO2WmWry1NL7XguKYRm7DpMahEsgX02BHeWbcOg=; b=muKEXtUt8e1jpoow9e8cO4qDkhtCIPg7bnFaV81z4bGT6jE5JRc3d8pCAaJjF3eHa4 KX88Ln6+AI0rzeLIvP19Yd0Mp0asS5Xh2NnX79S0S0sCAHEXxRSvvLQG86d73ob4Jg5B 4la2YDojKKxEgUgX7j4wVAayH4PY17xC0eROg3AcpDmOCgMm72mQGsRYN91TUTdxd242 ZCk429i2arCLld7jpnWIkHdzoekXF3ngCs1Nyi7N6wLabACAJXV+YOVY920v/ET4FROp i2VKxerXZeue8utHJoQoMquimIk54PjM4ga1SoO86fTm2b9GKF4mZ2cLG7EebuKFWsZe PZOA== X-Gm-Message-State: AOJu0Yyp8fvnuHwX/wHkT1tWv0oDjs4sraRiOJUtWZX5mm9ptP4wbroA b8datxdxQPBwb9iCUuRFZH9C7jHO6P2oJDwObsM= X-Google-Smtp-Source: AGHT+IFl1TG3uKFAIy7hVzzeYtSdzKSbPbIbXb32orpu3P1COw4vv5ojJrezTmW0L7vHk96dojA8Sa/zWxLj/bnXv7M= X-Received: by 2002:a2e:9945:0:b0:2bd:d34:f892 with SMTP id r5-20020a2e9945000000b002bd0d34f892mr8362426ljj.3.1696182374468; Sun, 01 Oct 2023 10:46:14 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 1 Oct 2023 10:46:14 -0700 In-Reply-To: <83il7q8evg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271633 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Sun, 1 Oct 2023 08:46:46 -0700 >> Cc: jonas@bernoul.li, 62751@debbugs.gnu.org, monnier@iro.umontreal.ca >> >> Eli Zaretskii writes: >> >> >> +4. Check that all new Lisp libraries belong to sensible packages. >> >> + Run "make -C lisp finder-data" and check the diff of the generated >> >> + file against the previously released Emacs version to see what has >> >> + changed. >> >> + >> > >> > This could benefit from some criteria for what is and isn't reasonable >> > in these diffs, or what to do with the differences. Because otherwise >> > "check the diff" doesn't tell how to check it. >> >> I didn't put anything, because I don't know how to summarize that in a >> few short words. Ideas for how to do that are welcome. > > Well, if you tell it in as many words as you need (or point me to > where it was already described up-thread), I could try suggesting a > concise version. Here's a typical excerpt of the difference between emacs-29 and master: --- emacs-release/lisp/finder-inf.el 2023-09-29 11:44:34.000000000 +0200 +++ emacs/lisp/finder-inf.el 2023-10-01 19:36:12.000000000 +0200 @@ -120,17 +120,18 @@ (ediff . [(2 81 6) nil "a comprehensive visual interface to diff & patch"]) (edmacro . [nil nil "keyboard macro editor"]) (edt . [nil nil "enhanced EDT keypad mode emulation for GNU Emacs"]) - (eglot . [(1 12 29) nil "The Emacs Client for LSP servers"]) + (eglot . [(1 15) nil "The Emacs Client for LSP servers"]) (ehelp . [nil nil "bindings for electric-help mode"]) (eieio . [(1 4) nil "Enhanced Implementation of Emacs Interpreted Objects"]) (eieio-core . [(1 4) nil "Core implementation for eieio"]) - (eldoc . [(1 13 0) nil "Show function arglist or variable docstring in echo area"]) + (eldoc . [(1 14 0) nil "Show function arglist or variable docstring in echo area"]) (elec-pair . [nil nil "Automatic parenthesis pairing"]) (electric . [nil nil "window maker and Command loop for `electric' modes"]) (elide-head . [nil nil "hide headers in files"]) (elint . [nil nil "Lint Emacs Lisp"]) + (elixir-ts-mode . [nil nil "Major mode for Elixir with tree-sitter support"]) (elp . [nil nil "Emacs Lisp Profiler"]) - (emacs . [(29 1 50) nil "the extensible text editor"]) + (emacs . [(30 0 50) nil "the extensible text editor"]) (emacs-authors-mode . [nil nil "font-locking for etc/AUTHORS"]) (emacs-lock . [nil nil "protect buffers against killing or exiting"]) (emacs-news-mode . [nil nil "major mode to edit and view the NEWS file"]) We have here two cases: 1. eglot, eldoc, and emacs just have new versions, and therefore need no action. 2. elixir-ts-mode is a new package, and we need to consider if that package makes sense. In this case, I'd say it does, but I'm not sure how to summarize the reasons why in a precise way. Perhaps one could say something along the lines of "it functions as a standalone feature". In Emacs 29.1, we had several new packages named something like: use-package-bind-key use-package-core use-package-diminish [...] use-package In this case, the new packages did _not_ make sense and had to be consolidated into just one package: use-package. Again, it is hard for me to summarize the reasons why. I suppose it has something to do with them not working without each other, and thus should better be treated as one functional whole.