From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Wed, 13 Oct 2021 15:33:19 +0200 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <831r4pp0ms.fsf@gnu.org> <83h7dlnjeo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 13 15:44:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maeYO-0003VY-Iu for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 15:44:20 +0200 Original-Received: from localhost ([::1]:52244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maeYN-0001vS-Ey for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 09:44:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maeNy-0001sU-HG for emacs-devel@gnu.org; Wed, 13 Oct 2021 09:33:35 -0400 Original-Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:55273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maeNx-00073K-1H; Wed, 13 Oct 2021 09:33:34 -0400 Original-Received: by mail-pj1-x102e.google.com with SMTP id np13so2216599pjb.4; Wed, 13 Oct 2021 06:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/N1T2KHeIkmm1HmWs9m3/97kdKSGwPlRZZBIDawtGaw=; b=aQ+hTAVYdlgzndfhZDjMFiNcnP3zd8ai9x9AmCpOI3xqfkxzumYLf+eUwoEwD7Ft3h S7xKIHEZcM4EUeg0iPsJysQTz71j3MyHbnymTUl/xfGAC4d17S6G477YYWXBxAGaUEY8 gw6GUxRmKM9ypNdHZKpDDBLx3d8tvlLsC+Ss45pfwH1CgzF7Fu/Spah9sjzxJvkLMHij /XKiqoCVSZCpxi3yjmJo0SMAPSg2hjS7ooG+t058eXDz4JwCchJVRnRBrbICZS9C/AVc MchcYbDtqhIAMtu+pV7uS8QR3beeGEZ22oO8cLNLxFthhouHtzdaoaMqwBqHEjmuZphJ P3vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/N1T2KHeIkmm1HmWs9m3/97kdKSGwPlRZZBIDawtGaw=; b=qRdKeX0fuINPTu37FlVKh4tz5mZ+aUdhotYT7aiKPudiZB6yC0s7AhEHs2AkZvWSA6 MfBdYZy69pxAYWKzOs0lJcklHXHyJa5Zg84X4SjNum7TPcBF5MFDIAEjRz2YuMbcNb+n 4Up+5WIGCbWQ5voI3SBDEeJmdfgGSJLxHL2jzfKjiyc6LJ15O4cF5bl6fLnHio9ECrdC 3k0LoemDircecu20HnSbqJid7D53MG51z2QCb4HZpMuNN0iHOE4mCwcW8RRYZnUBAoMW /xkGpATJc82NW2+DEfvZe8+guKazVZNgtvqI01v4lVFFwogoi9tcKI15zBh5DhRWin+g Uj7w== X-Gm-Message-State: AOAM531VN3tal2d30dGnETELq2mDaTOeT8UkdMK3z/jYa+ueXe6UQlo4 hLEa+ES59CEmbJND8a0LPgvbcS+0D+60R+lJawwEjAfQ X-Google-Smtp-Source: ABdhPJz+IgnthUKMskR/X1qcqGP2ixIMIWIqG5647igwPDrNdZ4jvgXYpMUkAz0gLFfMLZmYY5X9fDsmCSi9if0zO68= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr35563199pls.71.1634132011221; Wed, 13 Oct 2021 06:33:31 -0700 (PDT) In-Reply-To: <83h7dlnjeo.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=stefankangas@gmail.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276900 Archived-At: Eli Zaretskii writes: > I didn't say anything has changed, I asked why you didn't leave the > original "C-x a" intact. Ah, now I see what you mean. No reason, it just happened that way as I wrote this patch up rather quickly. I'll revert to the old form as there's no reason to change it. > Precisely because there could be mistakes, we should not adapt what > should happen to what did happen, we should keep the previous results > where we had them. If I understand you correctly, you are saying that we want kbd to behave in exactly the same way as before. I very much agree, there should be no functional change (a.k.a. bug for bug compatibility). The method I see for ensuring that is to develop all tests using the old version of kbd (I use Emacs 27.2 for testing) and then make sure that the new code passes the same tests.