From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65481: Replace defadvice with advice-add in Tramp manual Date: Thu, 24 Aug 2023 01:09:03 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24574"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de To: 65481@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 01:10:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYwzN-0006Ay-Dh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 01:10:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYwzB-0000bq-3R; Wed, 23 Aug 2023 19:10:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYwz9-0000a4-11 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:09:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYwz8-0002xf-P2 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:09:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYwzC-0005DQ-3l; Wed, 23 Aug 2023 19:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: michael.albinus@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65481 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs X-Debbugs-Original-Xcc: michael.albinus@gmx.de Original-Received: via spool by submit@debbugs.gnu.org id=B.169283217420001 (code B ref -1); Wed, 23 Aug 2023 23:10:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Aug 2023 23:09:34 +0000 Original-Received: from localhost ([127.0.0.1]:35535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYwyj-0005CW-KE for submit@debbugs.gnu.org; Wed, 23 Aug 2023 19:09:33 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:53332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYwyf-0005CG-Jc for submit@debbugs.gnu.org; Wed, 23 Aug 2023 19:09:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYwyW-0000GU-Lv for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:09:20 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYwyS-0002tN-UK for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:09:20 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4fe8c16c1b4so9453164e87.2 for ; Wed, 23 Aug 2023 16:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692832155; x=1693436955; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=a53Ldrsg0dxjXjykGNmReHNOr+El6/zf8o4SD777PZc=; b=l1Yk/pKh/TiKiDVW7JVbz8zDSYSBD+YyACOaEjSmFkXCKL0oaq/nl1ArzYIoPaXh4S geCqNeiKzgecrvfZxh7jVFEXBML/nE6VaKuOPFtRCAahGKKD9wkqYX4QBy7lY/aLJ2B4 bqJPkpmsPwNpgtprtMnzeMvpMPm39voANvqUtQG+NmRRMmY5D+3tAKLl1tl2fT9ymfqh RMsCgVsGNYxGag7zUOhxwXPqzeTI4wg8uLF6LAPLJFbVlQoa0Zgd7XHGyq5RhWQ0tGtN nWosm+gdqOQVToc4aGvYSLQd74K3UTmeWPeZ0OZBpul7sE3t9lb4wBA6akAM7mNSx4E7 Yiow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692832155; x=1693436955; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a53Ldrsg0dxjXjykGNmReHNOr+El6/zf8o4SD777PZc=; b=F7ONpK1hUCnh1cvZ+mNiZ+Nv4yY+eYMDg4biTbqSUIcNPlWCvDHnZzsZzKr6SA+1Uh BfqRr+aO1bdJ1ULDdxQDAPz7TgDBMOEQdJlkqWtzv4Cj2f4LbBMh8zzLWIkS5YYF1eQF Nzr3/u81Dpx2PLUJVijsvPGZ8fE6kmuomW7TMN49WCBZuctCasnFKA/5UTzfatOpCqHj a75wKO0foAk+G+xuV646qoelHAgf7TJdIJ/5vO2+AZKA9dIdbznXLidTaoLpbwD96mQh yxA0K9Lp2oKK3QT9mlauv1dzVe3VoSBLUzX7RJD3etffpyQC03FIv4yXC3RupreVbdGc 4qyg== X-Gm-Message-State: AOJu0YycvAZv7p9C45dSGtDBkFt3BeyjaAFY5HlbBO6O7PN0+TCSNIEw H79kJOrmvn7jzK9nFS6J4ADRUj/oqCmYAjizHF7x7injtJg= X-Google-Smtp-Source: AGHT+IEtnGSsO5udoADc1dFSAJBADg7WTUSx66vL4kpsoK2fasN0aSbA5m5jXYXtCv/vQ98UHoNrFD/7uM7K1UJzzWY= X-Received: by 2002:ac2:4e0a:0:b0:4fb:8948:2b28 with SMTP id e10-20020ac24e0a000000b004fb89482b28mr13169197lfr.63.1692832154772; Wed, 23 Aug 2023 16:09:14 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=stefankangas@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268279 Archived-At: Severity: wishlist X-Debbugs-CC: michael.albinus@gmx.de The Tramp manual recommends `defadvice', but it is now obsolete (commit 27ed565ec6). How about changing the below examples to use `advice-add' instead? ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents ./misc/tramp.texi:5531:(defadvice minibuffer-complete