From: Stefan Kangas <stefan@marxist.se>
To: Alan Mackenzie <acm@muc.de>, emacs-devel@gnu.org
Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning.
Date: Wed, 7 Apr 2021 05:06:04 -0500 [thread overview]
Message-ID: <CADwFkmnUou3pAhVV3fPvtg6Cby4L3uKt0GMO8Rx2_scEV4-FKA@mail.gmail.com> (raw)
In-Reply-To: <YG17goRa+2k1AzVt@ACM>
Alan Mackenzie <acm@muc.de> writes:
> In Emacs 28, easy-menu-add is now compiled to `ignore'. This isn't
> friendly, particularly as in Emacs 27.2 and earlier, it just worked,
> without any warnings of impending obsoletion.
What does "working" mean here? In Emacs 27.1, I have here:
easy-menu-add is an alias for ‘ignore’ in ‘easymenu.el’.
> Why have we not followed the normal procedure here, by marking the
> function as obsolete, yet leaving it working, for one or two major
> versions, and only then removing it?
It is my understanding that this has followed the normal procedure for
obsoletion.
> This sudden removal of easy-menu-add will cause unnecessary annoyance
> amongst maintainers whose sources still use it. Even in the Emacs
> sources there are 25 uses of the function.
This function is only relevant in XEmacs, so if this is important to you
I recommend changing any such call to say:
(when (featurep 'xemacs)
(easy-menu-add foo-menu))
The Emacs sources should already be updated accordingly.
> The warning message Emacs 28.1 gives out is particularly unfriendly and
> unhelpful. It looks like this:
>
> cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function
> (as of 28.1); use `ignore' instead.
Yes, we could improve that message.
Perhaps it could say: "it is not needed, so just remove it"
next prev parent reply other threads:[~2021-04-07 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:29 Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 10:06 ` Stefan Kangas [this message]
2021-04-07 11:24 ` Ulrich Mueller
2021-04-07 11:37 ` Eli Zaretskii
2021-04-07 14:14 ` Ulrich Mueller
2021-04-07 14:24 ` Eli Zaretskii
2021-04-07 14:30 ` XEmacs compatibility (was: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning) Stefan Monnier
2021-04-07 11:58 ` Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 12:43 ` Stefan Kangas
2021-04-07 11:41 ` Eli Zaretskii
2021-04-07 12:32 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnUou3pAhVV3fPvtg6Cby4L3uKt0GMO8Rx2_scEV4-FKA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.