From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master d378615: Cancel timer when world-clock buffer is killed Date: Sun, 6 Sep 2020 15:38:10 +0000 Message-ID: References: <20200903105449.22858.36474@vcs0.savannah.gnu.org> <20200903105450.8CD2D20A15@vcs0.savannah.gnu.org> <87sgbzrn0l.fsf@tcd.ie> <87k0x9sw1c.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 06 17:38:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEwkn-0006wY-J0 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Sep 2020 17:38:53 +0200 Original-Received: from localhost ([::1]:36988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEwkm-0003Fa-M4 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Sep 2020 11:38:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEwkB-0002Ot-8Q for emacs-devel@gnu.org; Sun, 06 Sep 2020 11:38:15 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:42466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEwk8-0002ve-UB for emacs-devel@gnu.org; Sun, 06 Sep 2020 11:38:14 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id l63so10262610edl.9 for ; Sun, 06 Sep 2020 08:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=wWqcQ5gf3ZAAaCeBSaB0aM/fQxIP2mwiA1kP9iz5cgk=; b=PUDzzrrJChaMyOWYwJt+wJyS3X9rZmR0CF+IPtJorJ2zF9kpfJZ0LEfXSGZ9jaxf++ qwZp6XCHwUXNye25bavW8VjFhBFIytvd2B1ss9V2gFS5XyrjDSQjT6VnvlWrYabw54GZ olfsFKR93AROzY04gWJWmZzNC2dkvypoA2CFhLjfOYk0p9ie55lD5z2DLqzGpm0PABgZ 6T7TVCqLmr3w/wj5o25aqcxCN8EXneJgaeC+D0WBTeMeBnNX+/1V9B01B2a/2P/UOeGI LvHuwWLZ5aQ+iBuEHlxDWOSGOXiGrgT49ykfm2o/oOSKlSApBbImnK0Q6Xggpph3MjFl Yuzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=wWqcQ5gf3ZAAaCeBSaB0aM/fQxIP2mwiA1kP9iz5cgk=; b=OxOmiwEvbsgbTdMXgkb4UNb/pG2f2LbqB10qkaBdBdzu2lCf+85dKZfnim/cRUnkox LS+6OD5qjffc+EkUy/a83RsOZvafX/TCp9QDNyeQxCH9+UQG8/2Ll6Ku/tg848hCofkX 8yxXa217r1aE7+fLkmc3tQ0wHfXza6dsOrgWx+BRloNX/nYYRovLdjTRowAboLWVz1DA 44tN7os0urjFmebM+piuUto69WCq/r/hFQiMOr6znn/fMk4fKgDGcDlGCHVDxNoqqC8W /ocFyS9YjwUU91xyirRmoirfF2hFpdzTjoIxfkjNulOb/MeHaAt4X3cnyUfPfDsMfXm0 GaTg== X-Gm-Message-State: AOAM532qCEe95XLU6N12UOzqeFcrHPkHXrDfNvRRkqbw58UVu3xDu5gU 3BiFLOTSsDOvOKVY6I4EjaUQY3OVkAU/Ay2u5G8= X-Google-Smtp-Source: ABdhPJwEB8ILLJMuKynnDuMwTxzcm/pDLeLHnXLhEZd2LgtSC3BStVYGgUp66WRkme6Hvu1NcD+HI7MzCQovT2Kx/dY= X-Received: by 2002:a50:ce06:: with SMTP id y6mr17043268edi.273.1599406690840; Sun, 06 Sep 2020 08:38:10 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 6 Sep 2020 15:38:10 +0000 In-Reply-To: <87k0x9sw1c.fsf@tcd.ie> Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x534.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254567 Archived-At: "Basil L. Contovounesios" writes: > Why not keep the (internal) variable and pass it to cancel-timer > directly instead of searching through timer-list for a particular entry? Thanks for your attention to detail. It's a matter of taste, I suppose. While mucking around with this, I saw two timers at one point, so I just kept that code as is. (Although the particular issue causing two timers should be fixed now.) Perhaps this should just use `cancel-function-timers' though... Are there any strong reasons why keeping it in a variable is better? Maybe we just prefer that style?