From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master f896c5e8cab: ; Fix coding style of last change Date: Sun, 9 Jun 2024 04:53:57 -0700 Message-ID: References: <171789547948.26161.15918757774801688043@vcs2.savannah.gnu.org> <20240609011119.F1942C1F9FF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27673"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 09 13:54:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGH8Q-0006x6-O6 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jun 2024 13:54:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGH7l-0001us-0B; Sun, 09 Jun 2024 07:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGH7e-0001uX-VR for emacs-devel@gnu.org; Sun, 09 Jun 2024 07:54:07 -0400 Original-Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGH7Z-0005q3-G9 for emacs-devel@gnu.org; Sun, 09 Jun 2024 07:54:06 -0400 Original-Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2e95a75a90eso38842861fa.2 for ; Sun, 09 Jun 2024 04:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717934039; x=1718538839; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=oUPmMF4lk6Pv90EWOScuIiInOzbZr8XJE+e/bSf0RgQ=; b=jvLF5bD5LfsuC9DNU308LvVnGZdEg3pwB+uXpS3zc25e6SlVgirnKFqPoQYTd4JoKE Pg37r3gVoNsxjqINTySqoNL3izAq3MzN0kkdya7RY/vgPr4QwcFCSTLZqBvunJ1H6ToB Mt1onCeTmqSkQRd2COByx76Q7eReKt0FAtIaxs6tnXop3Dgg9i/vHJwZV0DOp196NSWb BQu4YWTb+a9DRykPDlffm6tfHbDoy4Bkb+ZhFcuygbf2LEaw7tNL/IsbGqNm8mJMUCRZ QbNTgro4QUf20Zf7fBC6lMG3x6O/VfwVuWtZENO7hj13dtrMNZXiRjlwBgTmKmgUmBf3 kdMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717934039; x=1718538839; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oUPmMF4lk6Pv90EWOScuIiInOzbZr8XJE+e/bSf0RgQ=; b=cFrfn5MctGUia5ZVjuEjBoI0ebqofQaHrLu1RkDhWy9bQxxvB5+RPZeURX/N170XRb Z3fe57iYggmWbJorRODR4ryRrZiksxFvUS4CwgJ3QPagaStl5NKF6abysaOEG5TrNsI5 lB4V48SVzuG8LxVsB9qeQSsvM/P1xrUscHmD/lHpYKlj30GRLQd+0nTnr+E/tgy+2YCK t+gxgVdG8HPx80MplaWwLC8iZUE9DJ8336/SPA96XyWyvOKyB6cb7W3hKPX1IpkEhJcb pl2OGd6ZiLAN1ZJ4bkN2+3MP0hN9MS8NNN8sfAMvJhkGKqQdE6eA0uRJyPx+j8jL1LFU iUMg== X-Forwarded-Encrypted: i=1; AJvYcCXd6Yt7+mOPmv0zHIJMTpKpC2rAWGLutwKF/4aH/eUwTnWIMjwmPF4UGVCd6AmG2BYXqbWwMblcYvn003mLJRggYzHn X-Gm-Message-State: AOJu0Yy6WHQcmsl7Nai7xEPDUN3Kw81K1MT4KCtu8gLNbp9T5x4eoy44 udvOKxdbdotCRiGTPo34pvylXm/m/DdpzdGtOowlwJxWAyOb8xmH9D1P4wFKIsoN2M0mjellB5u 5D2otp2I6jKaB+dlaHs4JodBpT4x0OkFm X-Google-Smtp-Source: AGHT+IEXosUtcOz8XJkGVbhomT+RW4jIGDmoC4On0K+hQFnUFYeA68CQH6qDh1fOCrwrVIsgn/gUJdFjFLHG+yCei+U= X-Received: by 2002:a2e:8015:0:b0:2ea:cf86:c0a8 with SMTP id 38308e7fff4ca-2eadce7158emr47881991fa.37.1717934038568; Sun, 09 Jun 2024 04:53:58 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Jun 2024 04:53:57 -0700 In-Reply-To: <20240609011119.F1942C1F9FF@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=stefankangas@gmail.com; helo=mail-lj1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319926 Archived-At: Po Lu via Mailing list for Emacs changes writes: > -static void > -read_and_dispose_of_process_output (struct Lisp_Process *p, char *chars, > - ssize_t nbytes, > - struct coding_system *coding); > +static void read_and_dispose_of_process_output (struct Lisp_Process *, char *, > + ssize_t, > + struct coding_system *); I thought we preferred the above style? > -static void read_and_insert_process_output (struct Lisp_Process *p, char *buf, > - ssize_t nread, > - struct coding_system *process_coding) > +static void > +read_and_insert_process_output (struct Lisp_Process *p, char *buf, > + ssize_t nread, > + struct coding_system *process_coding) But here we change to the other one? Could someone please explain what I'm missing?