From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#8275: 24.0.50; Intro to Emacs Lisp Issue Date: Thu, 21 Oct 2021 12:42:54 -0700 Message-ID: References: <871v25d4zl.fsf@notengoamigos.org> <87zkoqwz4w.fsf@stupidchicken.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24583"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 8275-done@debbugs.gnu.org, Chong Yidong , Jason Earl To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 21:44:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mddz5-000662-Mi for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 21:44:15 +0200 Original-Received: from localhost ([::1]:54676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mddz3-0006t8-VV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 15:44:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mddys-0006rA-V8 for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 15:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mddys-0001Yq-Mh for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 15:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mddys-00057u-Lj for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 15:44:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 8275 X-GNU-PR-Package: emacs Mail-Followup-To: 8275@debbugs.gnu.org, stefan@marxist.se, jearl@notengoamigos.org Original-Received: via spool by 8275-done@debbugs.gnu.org id=D8275.163484539119583 (code D ref 8275); Thu, 21 Oct 2021 19:44:02 +0000 Original-Received: (at 8275-done) by debbugs.gnu.org; 21 Oct 2021 19:43:11 +0000 Original-Received: from localhost ([127.0.0.1]:58594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mddy2-00055m-PN for submit@debbugs.gnu.org; Thu, 21 Oct 2021 15:43:11 -0400 Original-Received: from mail-pj1-f46.google.com ([209.85.216.46]:56034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mddxs-00054v-MD for 8275-done@debbugs.gnu.org; Thu, 21 Oct 2021 15:43:09 -0400 Original-Received: by mail-pj1-f46.google.com with SMTP id om14so1265150pjb.5 for <8275-done@debbugs.gnu.org>; Thu, 21 Oct 2021 12:43:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=BTeGoPoXrVJDhNXthDLLQibgX3xMWM2Jdl2skyiMYkw=; b=mL6CVPz5mRPfsEe+wQGt7dNOQsHFEK6QtHmNR9FGyxymkK7zBFyM4YdHcGzJiSedQu 2iTij84e0aAGWfenewJSjvgQ3y546LYKGQKW2dHtrab3UEbLGQihRoKAJ/dxtKtLyYRE oT3BH+qvT0oliEERmH46D3MMxPKtovro657JaKtwX8TgTvbiJsUXu9jaLJbNlB+AaJsY qMV9V1Cwqoa2ks5Zzy+DvhnR5od/61/hUSwhDabhOmyhhZB8PQPmX9QIqYgUSqQqpyTn Ee+TLLlgB/3xUKJ0Gsg58RqPGn3lDP7g2wagizrMTrC0eKYnngD883cZhFgUZbvoStYM aWZw== X-Gm-Message-State: AOAM5307j9t9Yjow12qDLN5K4lYbxuL24iNugHq10/Nfjnu/1TsrD4dB 9FxgTT14twxNWg0JY94W6nSd/EAhFqToBW+6NoA= X-Google-Smtp-Source: ABdhPJwzLV+mI9FOFExwXH4U7PZoilSSSwrepk9wLukHZvFYvZlam1GKmgwslbV3S8oR+ezlhhD6j2g5xA4az0O2kD8= X-Received: by 2002:a17:90a:245:: with SMTP id t5mr8753968pje.133.1634845374852; Thu, 21 Oct 2021 12:42:54 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 21 Oct 2021 12:42:54 -0700 In-Reply-To: (Stefan Monnier's message of "Sat, 19 Mar 2011 23:34:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217806 Archived-At: Stefan Monnier writes: >> Do you want to fix this, or shall I try? The problem is that >> append-to-buffer now uses let* and with-current-buffer, so this might >> break the flow of the text. At this point in the book, let* and >> with-current-buffer are not yet introduced. > > Here are some thoughts: > - I don't think it's of any importance that the example code be > identical to the currently used code. > - append-to-buffer might not be the best example since AFAICT copying > text from one buffer to another is not a common operation and in most > cases this is done via buffer-substring + insert (often with some > processing on the string between the two) rather than with > insert-buffer-substring which is a rarely used function. > - yes, I think the text would benefit from some rethink to try and present > with-current-buffer in preference to set-buffer, but it's not > a simple fix. I've now added the above comments to a comment in the file itself. If anyone intends to review that section, they will find the comment and a pointer to this bug report.