bug#37053: 26.2; window.el does not (provide 'window)

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Noam Postavsky <npostavs@gmail.com> writes:

> >> (use-package window
> >>   :custom (split-height-threshold nil "Minimum height for splitting windows sensibly."))
> >
> > For builtin variables like this, you can just do
> >
> > (use-package emacs
> >    :custom (split-height-threshold nil "Minimum height for splitting windows sensibly."))
>
> Oh, (use-package "window" ...) should work as well.  See also
> https://debbugs.gnu.org/25026 for a similar report about isearch.el.

Since the third party package use-package by John Wiegley is gaining
popularity in the Emacs community, perhaps we should make life a bit
easier for these users.  The attached patch is simple enough.  Does
anyone disagree with making such a change?

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-lisp-window.el-Add-provide-statement.-Bug-37053.patch --]
[-- Type: text/x-patch, Size: 601 bytes --]

From daed6b4e6e67bb3c38acf7ed07ed25e997741902 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 21 Aug 2019 05:00:36 +0200
Subject: [PATCH] * lisp/window.el: Add provide statement.  (Bug#37053)

---
 lisp/window.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/window.el b/lisp/window.el
index 80dbd64f18..ed94d34c8b 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -9870,4 +9870,6 @@ ctl-x-map
 (define-key ctl-x-map "+" 'balance-windows)
 (define-key ctl-x-4-map "0" 'kill-buffer-and-window)
 
+(provide 'window)
+
 ;;; window.el ends here
-- 
2.20.1