all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: "Per Starbäck" <starback@cl.lingfil.uu.se>
Cc: 43298@debbugs.gnu.org
Subject: bug#43298: 27.1; Do font locking for Python 3, not 2
Date: Mon, 11 Oct 2021 06:25:26 -0700	[thread overview]
Message-ID: <CADwFkmnQekQNyoCJeghx8eqDmTQVo43nMSGKuPEUW75kj1p8EA@mail.gmail.com> (raw)
In-Reply-To: <sa5wo12ol0e.fsf@numerus.lingfil.uu.se> ("Per Starbäck"'s message of "Wed, 09 Sep 2020 20:36:17 +0200")

close 43298 29.1
thanks

Per Starbäck <starback@cl.lingfil.uu.se> writes:

> In GNU Emacs 27.1:
>
> 	$ emacs -Q -f /tmp/new.py
>         for RET print RET len RET
>
> "print" gets the same colour as "for", that is as a keyword.
> I think it should get the same as "len", that is as a builtin
> function.
>
> Python.el has a section
>
>           ;; Python 2:
>           "print" "exec"
>
> because in Python 2 these two were keywords. But in Python 3 they are built-in
> functions.

Thanks for the bug report!  Your reasoning makes sense to me, so I have
now fixed this on master (commit 9f9c9f934a).  This change will be in
Emacs 29.

Feel free to verify that this fix works for you, but for now I'm closing this
bug report.  If you see anything that is wrong, please reply to this
email (use "Reply to all" in your email client) and we can reopen the
bug report.

> I think it's overkill to try to determine if the buffer contains Python 2 or 3
> and highlight them differently. Using the same fontlocking is good enough,
> since it's not a big problem to get these in the wrong colour.
> But now when Python 2 is officially discontinued I think it's time to
> let it follow Python 3 and get the small inconvenience when editing old
> code and not when editing current code.

Agreed.





      parent reply	other threads:[~2021-10-11 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 18:36 bug#43298: 27.1; Do font locking for Python 3, not 2 Per Starbäck
2020-09-10 17:23 ` Kévin Le Gouguec
2021-10-11 13:25 ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnQekQNyoCJeghx8eqDmTQVo43nMSGKuPEUW75kj1p8EA@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=43298@debbugs.gnu.org \
    --cc=starback@cl.lingfil.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.