From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#34093: auto-save prevents quitting emacs on read-only filesystem Date: Tue, 18 Aug 2020 17:52:24 +0000 Message-ID: References: <87pnsx8fw7.fsf@lausen.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c6558e05ad2a8cde" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14729"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 34093@debbugs.gnu.org To: Leonard Lausen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 18 19:53:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k85nK-0003jX-EU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 19:53:10 +0200 Original-Received: from localhost ([::1]:53010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k85nJ-0007xj-GX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 13:53:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k85nC-0007wu-8w for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 13:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k85nB-00012s-VC for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 13:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k85nB-0003u2-UP for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 13:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Aug 2020 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34093 X-GNU-PR-Package: emacs Original-Received: via spool by 34093-submit@debbugs.gnu.org id=B34093.159777315614970 (code B ref 34093); Tue, 18 Aug 2020 17:53:01 +0000 Original-Received: (at 34093) by debbugs.gnu.org; 18 Aug 2020 17:52:36 +0000 Original-Received: from localhost ([127.0.0.1]:36878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k85ml-0003tO-Sr for submit@debbugs.gnu.org; Tue, 18 Aug 2020 13:52:36 -0400 Original-Received: from mail-yb1-f194.google.com ([209.85.219.194]:38189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k85mh-0003sv-8b for 34093@debbugs.gnu.org; Tue, 18 Aug 2020 13:52:32 -0400 Original-Received: by mail-yb1-f194.google.com with SMTP id e187so11857671ybc.5 for <34093@debbugs.gnu.org>; Tue, 18 Aug 2020 10:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=I3iPFhrY+gLG/aSkjzGd2FK1gSVk9uxpVuZ87dEmCLY=; b=FO/YsFCKEJnCESGgR3n47Jf3QL3xorCqXqoh4owdUqHX9dvZ1SYAmOQBG1lirPeGEo yENshVTL3YaCe+7rccDcBTFbqzZP8vHJfjjVnKJqEQkae8coQh3kbZ+e25zjQp7po+bW UYyuBF0CtvngCoobSGahUFk6tHlHEj2eAvHKyNjSoWpbJrhsyiCTrue5S8dF/pzwjFPg Zzdo+PeQpgnni+8KqqZ6GXLLOBgdk+cLefvpPrCt80iXtVT2NOCCNQxZDdztAC3Rgkj+ P48XgWdWrvk/onqKjFnWI4gxiPypVzcbvJaEYjL9dW+X4jHI/QUqdleth3oRg8rn+y7A 61Yg== X-Gm-Message-State: AOAM533ys2ubI9BUdfVAhzUakam3E/TT5sbyjLyVLBiYZszw8jwbhbML FpCIjT1Ll7++/BEnx5Ixu8KuxbgmtHBfLfr+iPs= X-Google-Smtp-Source: ABdhPJwUJ0IZKmP3sqiovXaENk8wgM7q72mzR/l8FQL5w96/JCGQ0hwbmmtCPWfRSr63clMajIYOm/t8bYe+OYL/eXg= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr29980535ybb.129.1597773145584; Tue, 18 Aug 2020 10:52:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 18 Aug 2020 17:52:24 +0000 In-Reply-To: <87pnsx8fw7.fsf@lausen.nl> (Leonard Lausen's message of "Wed, 16 Jan 2019 03:01:28 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185527 Archived-At: --000000000000c6558e05ad2a8cde Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 34093 + patch thanks Leonard Lausen writes: > Recently my filesystem had to be emergency remounted as read-only. I > observed that I could not kill-emacs anymore. The following showed up in > my log upon trying to quit emacs: > > ``` > company-statistics--save: Opening output file: Read-only file system, /ho= me/leonard/.emacs.d/.cache/company-statistics-cache.el > Error running timer =E2=80=98savehist-autosave=E2=80=99: (file-error "Ope= ning output file" "Read-only file system" "/home/leonard/.emacs.d/.cache/sa= vehist") > ``` > > This prevented quitting emacs. > > I am not sure if `company-statistics--save` prevented the shutdown, or > just warned about the read-only file system. Possibly the behavior of > `company-statistics--save` is sane and only `savehist-autosave` is at > fault. Maybe both are at fault? > > The expected behavior is that emacs may warn about or ignore that it > cannot write the savehist file. Calling kill-emacs should still quit > emacs. I can reproduce this under "emacs -Q" by evaluating: (progn (savehist-mode) (setq savehist-file "/usr/foo") (confirm-exit-emacs)) I have attached a patch which fixes this bug by showing a warning if this file is not readable. Best regards, Stefan Kangas --000000000000c6558e05ad2a8cde Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-exiting-Emacs-when-savehist-file-not-writable.patch" Content-Disposition: attachment; filename="0001-Fix-exiting-Emacs-when-savehist-file-not-writable.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 9dfe3aa7147b07bd_0.1 RnJvbSBkNzgwODY0ZmQzODc2ODgwMWM4ODc3OGVlNjk0YTFhNTM1ZTQxODEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDE4IEF1ZyAyMDIwIDE5OjI5OjE5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Rml4IGV4aXRpbmcgRW1hY3Mgd2hlbiBzYXZlaGlzdC1maWxlIG5vdCB3cml0YWJsZQoKKiBsaXNw L3NhdmVoaXN0LmVsIChzYXZlaGlzdC1zYXZlKTogU2hvdyB3YXJuaW5nIHdoZW4gJ3NhdmVoaXN0 LWZpbGUnCmlzIG5vdCB3cml0YWJsZS4gIChCdWcjMzQwOTMpCihzYXZlaGlzdC0taGFzLWdpdmVu LWZpbGUtd2FybmluZyk6IE5ldyB2YXJpYWJsZS4KLS0tCiBsaXNwL3NhdmVoaXN0LmVsIHwgNDEg KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAyNCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Nh dmVoaXN0LmVsIGIvbGlzcC9zYXZlaGlzdC5lbAppbmRleCA0ZTUyZWZlN2YxLi41YTY0YjkzMjdh IDEwMDY0NAotLS0gYS9saXNwL3NhdmVoaXN0LmVsCisrKyBiL2xpc3Avc2F2ZWhpc3QuZWwKQEAg LTIxNSw2ICsyMTUsNyBAQCBzYXZlaGlzdC11bmluc3RhbGwKICAgICAoY2FuY2VsLXRpbWVyIHNh dmVoaXN0LXRpbWVyKQogICAgIChzZXRxIHNhdmVoaXN0LXRpbWVyIG5pbCkpKQogCisoZGVmdmFy IHNhdmVoaXN0LS1oYXMtZ2l2ZW4tZmlsZS13YXJuaW5nIG5pbCkKIChkZWZ1biBzYXZlaGlzdC1z YXZlICgmb3B0aW9uYWwgYXV0by1zYXZlKQogICAiU2F2ZSB0aGUgdmFsdWVzIG9mIG1pbmlidWZm ZXIgaGlzdG9yeSB2YXJpYWJsZXMuCiBVbmJvdW5kIHN5bWJvbHMgcmVmZXJlbmNlZCBpbiBgc2F2 ZWhpc3QtYWRkaXRpb25hbC12YXJpYWJsZXMnIGFyZSBpZ25vcmVkLgpAQCAtMjg4LDIzICsyODks MjkgQEAgc2F2ZWhpc3Qtc2F2ZQogICAgIDs7IElmIGF1dG9zYXZpbmcsIGF2b2lkIHdyaXRpbmcg aWYgbm90aGluZyBoYXMgY2hhbmdlZCBzaW5jZSB0aGUKICAgICA7OyBsYXN0IHdyaXRlLgogICAg IChsZXQgKChjaGVja3N1bSAobWQ1IChjdXJyZW50LWJ1ZmZlcikgbmlsIG5pbCBzYXZlaGlzdC1j b2Rpbmctc3lzdGVtKSkpCi0gICAgICAodW5sZXNzIChhbmQgYXV0by1zYXZlIChlcXVhbCBjaGVj a3N1bSBzYXZlaGlzdC1sYXN0LWNoZWNrc3VtKSkKLQk7OyBTZXQgZmlsZS1wcmVjaW91cy1mbGFn IHdoZW4gc2F2aW5nIHRoZSBidWZmZXIgYmVjYXVzZSB3ZQotCTs7IGRvbid0IHdhbnQgYSBoYWxm LWZpbmlzaGVkIHdyaXRlIHJ1aW5pbmcgdGhlIGVudGlyZQotCTs7IGhpc3RvcnkuICBSZW1lbWJl ciB0aGF0IHRoaXMgaXMgcnVuIGZyb20gYSB0aW1lciBhbmQgZnJvbQotCTs7IGtpbGwtZW1hY3Mt aG9vaywgYW5kIGFsc28gdGhhdCBtdWx0aXBsZSBFbWFjcyBpbnN0YW5jZXMKLQk7OyBjb3VsZCB3 cml0ZSB0byB0aGlzIGZpbGUgYXQgb25jZS4KLQkobGV0ICgoZmlsZS1wcmVjaW91cy1mbGFnIHQp Ci0JICAgICAgKGNvZGluZy1zeXN0ZW0tZm9yLXdyaXRlIHNhdmVoaXN0LWNvZGluZy1zeXN0ZW0p Ci0gICAgICAgICAgICAgIChkaXIgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc2F2ZWhpc3QtZmlsZSkp KQotICAgICAgICAgIDs7IEVuc3VyZSB0aGF0IHRoZSBkaXJlY3RvcnkgZXhpc3RzIGJlZm9yZSBz YXZpbmcuCi0gICAgICAgICAgKHVubGVzcyAoZmlsZS1leGlzdHMtcCBkaXIpCi0gICAgICAgICAg ICAobWFrZS1kaXJlY3RvcnkgZGlyIHQpKQotCSAgKHdyaXRlLXJlZ2lvbiAocG9pbnQtbWluKSAo cG9pbnQtbWF4KSBzYXZlaGlzdC1maWxlIG5pbAotCQkJKHVubGVzcyAoY2FsbGVkLWludGVyYWN0 aXZlbHktcCAnaW50ZXJhY3RpdmUpICdxdWlldCkpKQotCSh3aGVuIHNhdmVoaXN0LWZpbGUtbW9k ZXMKLQkgIChzZXQtZmlsZS1tb2RlcyBzYXZlaGlzdC1maWxlIHNhdmVoaXN0LWZpbGUtbW9kZXMp KQotCShzZXRxIHNhdmVoaXN0LWxhc3QtY2hlY2tzdW0gY2hlY2tzdW0pKSkpKQorICAgICAgKGNv bmRpdGlvbi1jYXNlIGVycgorICAgICAgICAodW5sZXNzIChhbmQgYXV0by1zYXZlIChlcXVhbCBj aGVja3N1bSBzYXZlaGlzdC1sYXN0LWNoZWNrc3VtKSkKKwkgIDs7IFNldCBmaWxlLXByZWNpb3Vz LWZsYWcgd2hlbiBzYXZpbmcgdGhlIGJ1ZmZlciBiZWNhdXNlIHdlCisJICA7OyBkb24ndCB3YW50 IGEgaGFsZi1maW5pc2hlZCB3cml0ZSBydWluaW5nIHRoZSBlbnRpcmUKKwkgIDs7IGhpc3Rvcnku ICBSZW1lbWJlciB0aGF0IHRoaXMgaXMgcnVuIGZyb20gYSB0aW1lciBhbmQgZnJvbQorCSAgOzsg a2lsbC1lbWFjcy1ob29rLCBhbmQgYWxzbyB0aGF0IG11bHRpcGxlIEVtYWNzIGluc3RhbmNlcwor CSAgOzsgY291bGQgd3JpdGUgdG8gdGhpcyBmaWxlIGF0IG9uY2UuCisJICAobGV0ICgoZmlsZS1w cmVjaW91cy1mbGFnIHQpCisJICAgICAgICAoY29kaW5nLXN5c3RlbS1mb3Itd3JpdGUgc2F2ZWhp c3QtY29kaW5nLXN5c3RlbSkKKyAgICAgICAgICAgICAgICAoZGlyIChmaWxlLW5hbWUtZGlyZWN0 b3J5IHNhdmVoaXN0LWZpbGUpKSkKKyAgICAgICAgICAgIDs7IEVuc3VyZSB0aGF0IHRoZSBkaXJl Y3RvcnkgZXhpc3RzIGJlZm9yZSBzYXZpbmcuCisgICAgICAgICAgICAodW5sZXNzIChmaWxlLWV4 aXN0cy1wIGRpcikKKyAgICAgICAgICAgICAgKG1ha2UtZGlyZWN0b3J5IGRpciB0KSkKKwkgICAg KHdyaXRlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSBzYXZlaGlzdC1maWxlIG5pbAor CQkJICAodW5sZXNzIChjYWxsZWQtaW50ZXJhY3RpdmVseS1wICdpbnRlcmFjdGl2ZSkgJ3F1aWV0 KSkpCisJICAod2hlbiBzYXZlaGlzdC1maWxlLW1vZGVzCisJICAgIChzZXQtZmlsZS1tb2RlcyBz YXZlaGlzdC1maWxlIHNhdmVoaXN0LWZpbGUtbW9kZXMpKQorCSAgKHNldHEgc2F2ZWhpc3QtbGFz dC1jaGVja3N1bSBjaGVja3N1bSkpCisgICAgICAgIChmaWxlLWVycm9yCisgICAgICAgICAodW5s ZXNzIHNhdmVoaXN0LS1oYXMtZ2l2ZW4tZmlsZS13YXJuaW5nCisgICAgICAgICAgKGx3YXJuICco c2F2ZWhpc3QtZmlsZSkgOndhcm5pbmcgIkVycm9yIHdyaXRpbmcgYCVzJzogJXMiCisgICAgICAg ICAgICAgICAgIHNhdmVoaXN0LWZpbGUgKGNhZGRyIGVycikpCisgICAgICAgICAgKHNldHEgc2F2 ZWhpc3QtLWhhcy1naXZlbi1maWxlLXdhcm5pbmcgdCkpKSkpKSkKIAogKGRlZnVuIHNhdmVoaXN0 LWF1dG9zYXZlICgpCiAgICJTYXZlIHRoZSBtaW5pYnVmZmVyIGhpc3RvcnkgaWYgaXQgaGFzIGJl ZW4gbW9kaWZpZWQgc2luY2UgdGhlIGxhc3Qgc2F2ZS4KLS0gCjIuMjguMAoK --000000000000c6558e05ad2a8cde--