From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 501e2096d6: Fix some issues with a recent change Date: Mon, 27 Dec 2021 15:19:15 -0800 Message-ID: References: <164051393145.21885.8315099612759503047@vcs2.savannah.gnu.org> <20211226101851.B61E5C04DCC@vcs2.savannah.gnu.org> <83bl13nsav.fsf@gnu.org> <87fsqe3ly7.fsf@yahoo.com> <874k6u3alb.fsf@yahoo.com> <87ilva1sev.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier , Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 28 00:21:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1zJH-0002KC-V2 for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Dec 2021 00:21:43 +0100 Original-Received: from localhost ([::1]:59678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1zJG-0005pH-89 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Dec 2021 18:21:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1zGy-00043u-7K for emacs-devel@gnu.org; Mon, 27 Dec 2021 18:19:21 -0500 Original-Received: from [2607:f8b0:4864:20::62b] (port=39840 helo=mail-pl1-x62b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1zGw-0008A0-SJ; Mon, 27 Dec 2021 18:19:19 -0500 Original-Received: by mail-pl1-x62b.google.com with SMTP id h6so8472427plf.6; Mon, 27 Dec 2021 15:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=zZGJF8cPnrDEGbtF0MQrGQZs98NALvVkskD+Qeaewdw=; b=qB2/mIfuRkGqqFDB9e2jJX22I7ARlef3uc+L3I42+ZAJk+jAxWH6pQvqWog9cAHtYq 0PwYAHXU7Z/TD40YzW3zL1mZq76Zc66FiJnNkY+tgXxDLFVcTNQj9cTFccVP0SnIaGrw U81cmSDXdzGQsLVf1TidA2MuOu6L2Xr3UXJxTSd2MQgZsIgI1fbgjdP0TMzSFUh0eqY8 41BhshKignFwAdAJn8HMf1e73/h7bY3EXSIClVt1++Hg+Brp60xxdWtE93WRNMuCg5AW hDJ9e8wpY4JaS3JYUVxgYilA/Z/0BCKclc9RcYH593d7YWo2Zl9vr22IT5gBdv0LdRDn jfTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=zZGJF8cPnrDEGbtF0MQrGQZs98NALvVkskD+Qeaewdw=; b=1NhZsRGWRXM3O/k2IgETOgw/9YP3pY2QthzZKhZryI/a3335o4fXVGozde19q7s/wV d17JE8Tm/pJ0QiPDWwbpP3NzQGd+lCypsD/+4i4WChOKfwHi+AEIQWkmz+fmGGGBLgaZ 6qA9+7ljzixMYN+v5kln98KNpxUGHpo6VmdXwBGA7Q3DQHtSZTyjFrYzElZsI7bd2NrT U02tXfUYX9CgAZN/16luc7y6HTj4CPJU2JlJF8wK6V4F2uoD3ylJAXaLZJyCi4uZrnC1 3/pYNtO2yr3k9PLFqjQMdOnvyUQ2GgTuHopizhguVF0WVBrVspVHFq5hEjJGj1F7/g0+ axBw== X-Gm-Message-State: AOAM53058QGkWVFxP9bywpRijsw0qI5VRYhEYZL8ul0cEFvBXiQyirPg rUFKnwpBLDQ1hnq8wxHi4rC9r79Rj01VGiNEOcs= X-Google-Smtp-Source: ABdhPJzr82Xbek1AMYcyQicbtTPY0YlYcIN09YZL+OD3BtsaPaoQcJBZ7rSsptQJg1AdCyudsBygU0MUK+bgavS+QUk= X-Received: by 2002:a17:902:ab97:b0:149:8662:1736 with SMTP id f23-20020a170902ab9700b0014986621736mr4720814plr.174.1640647155836; Mon, 27 Dec 2021 15:19:15 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 27 Dec 2021 15:19:15 -0800 In-Reply-To: X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62b (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283456 Archived-At: Stefan Monnier writes: >> Okay, so how about "Fix some issues with the recently introduced pinch >> support?" > > That would have been a good improvement, yes. I would try to follow the CONTRIBUTE guidelines of sticking to 50 characters or fewer when possible, so you could probably shorten that to something like: Fix issues with recently introduced pinch support or even Clean up pinch support This makes it easier to read the line in various situations (avoiding truncating), but note that this is just a recommendation and not a requirement.