From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language} Date: Fri, 29 Jan 2021 14:10:36 -0600 Message-ID: References: <20210128134320.25762.38081@vcs0.savannah.gnu.org> <20210128134322.507A820B72@vcs0.savannah.gnu.org> <87pn1n4v2d.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25612"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier , Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 29 21:18:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5aEJ-0006TG-VK for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jan 2021 21:18:55 +0100 Original-Received: from localhost ([::1]:57478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5aEI-0006eL-Hr for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jan 2021 15:18:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5a6M-0005yj-HH for emacs-devel@gnu.org; Fri, 29 Jan 2021 15:10:42 -0500 Original-Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:33201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5a6J-0007zw-Iz for emacs-devel@gnu.org; Fri, 29 Jan 2021 15:10:42 -0500 Original-Received: by mail-pl1-x62b.google.com with SMTP id d13so5902021plg.0 for ; Fri, 29 Jan 2021 12:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=OGmibSmgAiJn3Ef1F4Ht/JEwSVSIt1HIZiro53sLqBA=; b=WV1mkB2WxutdofntBn32WJpXk/vQac0hajPk/N0sq/U2th0gz19IdzJNMqV4vNgLUc fdMKGQ2AjsGFSJZldE0Ato328Ckrwnr79crziz+r476SRlQFg9rba9HpkAp0u+JlPgW1 /c5krEHzuZHC+qFb9Yo5NdWQU4ptrc1PkBUyczJOM8TWk0UkyD0ib7as2WlrdImLRe+w qpeQQ8hfmac4cNCAdJ1v5X+Zg0M9Gd/OEE7Icav8UCv85ur0Cd/kB7OY4EleiHN3ui2H Nf2h1O9yM6W4LFO+/iVmUJ3uOW2OLJT3d/pjfB9PesqEQNJ6XfzyBQqY/VWbLPhsL1tt q8Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=OGmibSmgAiJn3Ef1F4Ht/JEwSVSIt1HIZiro53sLqBA=; b=MJWBbGWCmYDIwDtW42kS6mfessxuVYHU+Vo+QfpdVypDGFD/0/AhIScwvo1jBAYrBE oZKvGHJl1TiuURaycX8HF004Vx/rqeeDIUlbQaoAcPjQ6gQub/MxtvO3z9s0tPfQN+Lj NKpkn7cQLZG12gYfPLiS3s0qGzaVj/kc6+aZSSo16BHRLQcIjlUtyKY4M+jABIK9nTSD O87A2KvGSWN85MHSFj7dbaSnnVMDRtBBzQ+vvGugNg4IfIQD5zv4xzfJUgxju4OAqImE zU594izICS8E/NZMT0LOUpayF4YRzG0hkjOPmJ13URn9k86qQrhBKZBkdmr1mhxPL1hN wS/g== X-Gm-Message-State: AOAM533ccZYzWYnbKXIvMQB6J0HhVlhgFaJftAVIH/YzoC8rTy5sq2iq GmTaKVFDKHIX64GtdXAjhOreXNDLswTPD+sSzZo= X-Google-Smtp-Source: ABdhPJz73aE4Z98c8/jK+QE0pisOxbeDZnDRbhQLDJmbkF4ETKMrw8EU69uxupJoTy4CwGPuTdknEe3bWdJ0tQbBaPo= X-Received: by 2002:a17:90a:5c81:: with SMTP id r1mr6237589pji.175.1611951037332; Fri, 29 Jan 2021 12:10:37 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Jan 2021 14:10:36 -0600 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263588 Archived-At: Stefan Monnier writes: >>> commit 62233c9824047e989cb72c8e2d05e4b4444fe0be > [...] >> Looks, like this has broken electric-tests :-( > > What makes you think so? `make check` gives me no failures. I think you need to say: make -C test electric-tests I see many failures like the following: Test electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode backtrace: (closure ((test-in-code . t) (test-in-strings . t) (test-in-comments (electric-pair-test-for "(<>" 2 60 "(<><>" 3 'js-mode '((electric-pa (closure (t) nil (electric-pair-test-for "(<>" 2 60 "(<><>" 3 'js-mo ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name electric-pair-angle-brackets-everywhe ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/electric-tests.el" " command-line() normal-top-level() Test electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode condition: (void-function closure) FAILED 7/478 electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode (0.000086 sec)