all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 62233c9: Use lexical-binding in lisp/{term,nxml,language}
Date: Fri, 29 Jan 2021 14:10:36 -0600	[thread overview]
Message-ID: <CADwFkmnN3g2vh=TRwxLyFdy6HVQp=pVSG4VAmjNd+tpDE3pHKg@mail.gmail.com> (raw)
In-Reply-To: <jwvsg6jsg8w.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> commit 62233c9824047e989cb72c8e2d05e4b4444fe0be
> [...]
>> Looks, like this has broken electric-tests :-(
>
> What makes you think so?  `make check` gives me no failures.

I think you need to say:

    make -C test electric-tests

I see many failures like the following:

    Test electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode
backtrace:
      (closure ((test-in-code . t) (test-in-strings . t) (test-in-comments
      (electric-pair-test-for "(<>" 2 60 "(<><>" 3 'js-mode '((electric-pa
      (closure (t) nil (electric-pair-test-for "(<>" 2 60 "(<><>" 3 'js-mo
      ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
      ert-run-test(#s(ert-test :name electric-pair-angle-brackets-everywhe
      ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
      ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
      ert-run-tests-batch((not (tag :unstable)))
      ert-run-tests-batch-and-exit((not (tag :unstable)))
      eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
      command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/electric-tests.el" "
      command-line()
      normal-top-level()
    Test electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode
condition:
        (void-function closure)
       FAILED    7/478
electric-pair-angle-brackets-everywhere-2-at-point-2-in-js-mode
(0.000086 sec)



      parent reply	other threads:[~2021-01-29 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210128134320.25762.38081@vcs0.savannah.gnu.org>
     [not found] ` <20210128134322.507A820B72@vcs0.savannah.gnu.org>
2021-01-29 15:33   ` master 62233c9: Use lexical-binding in lisp/{term,nxml,language} Michael Albinus
2021-01-29 19:20     ` Stefan Monnier
2021-01-29 20:09       ` Michael Albinus
2021-01-29 21:49         ` Stefan Monnier
2021-01-29 20:10       ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmnN3g2vh=TRwxLyFdy6HVQp=pVSG4VAmjNd+tpDE3pHKg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.