From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37420: [PATCH] Recommend against SHA-1 for security-related applications Date: Fri, 20 Sep 2019 20:50:59 +0200 Message-ID: References: <87v9tsv65b.fsf@gnus.org> <87ef0grneg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197216"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37420@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 20:56:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBO4q-000pBa-W2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 20:56:21 +0200 Original-Received: from localhost ([::1]:34742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBO4o-0001v6-AA for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 14:56:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54278) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBO0h-0003ko-8r for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBO0g-0005rV-Aa for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBO0g-0005rR-75 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBO0g-00052h-44 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37420-submit@debbugs.gnu.org id=B37420.156900547919320 (code B ref 37420); Fri, 20 Sep 2019 18:52:02 +0000 Original-Received: (at 37420) by debbugs.gnu.org; 20 Sep 2019 18:51:19 +0000 Original-Received: from localhost ([127.0.0.1]:58500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBNzz-00051X-5O for submit@debbugs.gnu.org; Fri, 20 Sep 2019 14:51:19 -0400 Original-Received: from mail-pf1-f182.google.com ([209.85.210.182]:34365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBNzx-00051E-09 for 37420@debbugs.gnu.org; Fri, 20 Sep 2019 14:51:18 -0400 Original-Received: by mail-pf1-f182.google.com with SMTP id b128so5114302pfa.1 for <37420@debbugs.gnu.org>; Fri, 20 Sep 2019 11:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QnEft4YM923wTYICbaNNSssDxWH/70R7TzGt7h6Vte0=; b=LJ9pCl+qb75VpkdVvP0QCw0l9g8vorF7C9reWj/OB1PqyDYRGXNWxgXf2DkH7efU6H l6cvk3oEhIp8+HYaV0UeQ+UXXKQCEn2JNoK1cPFTnba49EUohPynMfUOJq3xvOb3RNUA s8YtTiHahM3hlXtgZcPvjGdfOhnE7zQ7YvhhZjRogi0unf2qaRgouE5qE+NIaP5feqQv KEoBkRmjSdgh379xoCsQveIRQbrUlXbP/zkRPml4VMLchBUayl4EZHONw3gjEgYpsP6u Q+mqsovyzYwYfaSXbHrjurc7PKexiPzQQZdgtNFX1177v1fIeNTIUPvfAnRg9ZKYJPsF i+GQ== X-Gm-Message-State: APjAAAUoNZFu1pbseADZ7AmbY8WaX8kgCL4/zXL7UKlMLwDn2uW3UBou KMu7RcV3q2R1JagvwpP+Qdu2/vU0X4iovElWVt0= X-Google-Smtp-Source: APXvYqwNRoHLEUiFAas4oRvL3jStkTMbUEMnHI0bPmx7zT+I2pOWdAC3PbpjQ9mRhNon/POCOkkNjYXZrTvJBE1LVbg= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr17511639pgl.333.1569005470787; Fri, 20 Sep 2019 11:51:10 -0700 (PDT) In-Reply-To: <87ef0grneg.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166785 Archived-At: Lars Ingebrigtsen writes: > > +Note that SHA-1 is not collision resistant and should not be used > > +for anything security-related. See `secure-hash' for > > +alternatives." > > Looks good. Thanks. Since there were no other comments, I've now committed this first patch as commit 6d50010b34. I'll address the second patch in a separate email. Best regards, Stefan Kangas