From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Stefan Kangas <stefan@marxist.se>
Newsgroups: gmane.emacs.bugs
Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite'
Date: Wed, 12 Jun 2019 11:09:33 +0200
Message-ID: <CADwFkmnKHGO8Tx33tckrFzeVAk7rtRBOuQH5Qxx0P_h2wDV_bA@mail.gmail.com>
References: <a2aaddd0-ce03-44f8-831f-5e0cbc1a0896@default>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="132937"; mail-complaints-to="usenet@blaine.gmane.org"
To: 25032@debbugs.gnu.org, Drew Adams <drew.adams@oracle.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 12 11:10:20 2019
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hazGt-000YKS-AP
	for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 11:10:19 +0200
Original-Received: from localhost ([::1]:57822 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hazGs-0003V3-7u
	for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 05:10:18 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36978)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hazGe-0003TG-BI
 for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 05:10:05 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hazGd-0002xu-CG
 for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 05:10:04 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:47163)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hazGc-0002xK-LX
 for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 05:10:03 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hazGc-0003Yw-AC
 for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 05:10:02 -0400
X-Loop: help-debbugs@gnu.org
In-Reply-To: <a2aaddd0-ce03-44f8-831f-5e0cbc1a0896@default>
Resent-From: Stefan Kangas <stefan@marxist.se>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Wed, 12 Jun 2019 09:10:02 +0000
Resent-Message-ID: <handler.25032.B25032.156033059313668@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 25032
X-GNU-PR-Package: emacs
Original-Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156033059313668
 (code B ref 25032); Wed, 12 Jun 2019 09:10:02 +0000
Original-Received: (at 25032) by debbugs.gnu.org; 12 Jun 2019 09:09:53 +0000
Original-Received: from localhost ([127.0.0.1]:60707 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1hazGS-0003YN-Vh
 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 05:09:53 -0400
Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:40914)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@gmail.com>) id 1hazGQ-0003Y5-L1
 for 25032@debbugs.gnu.org; Wed, 12 Jun 2019 05:09:51 -0400
Original-Received: by mail-wm1-f49.google.com with SMTP id v19so5677231wmj.5
 for <25032@debbugs.gnu.org>; Wed, 12 Jun 2019 02:09:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=9w4Klhk5ksFQBxwfkexxrURPF/3v2iRWciNco9M8MLI=;
 b=eFWnPzLL5bZSqjDgiS+vP5SVzET7/zV6sAcTvGBwt2I/bqXrPe5uq7KN+joG5BXVyv
 R+oXsr7bXtlnGD5NNSkGTJeMnGeNgtN9f1y4DVzj68FYiqJ0Ni6l4CFmUcztV5vugNEc
 uzCGJVsIBqWvWMj10a5CM3/7b92d+UbEbZMOJIIGQwQ8vJpOWhuWLVzUKBzl+SlKmfnV
 26RpJb0/Goxpz9BewOrMVQ8Jyd9UIFXsajKnlUHEfof5guTTP5BqWgMThlK/K832jFAs
 cj71xhdfwlgzEB51/CRdl2XatL7FouAKdM9I78yrHZiftMmDvyAetM8CIZZA4G3OngeW
 m2eQ==
X-Gm-Message-State: APjAAAVogkNp4JbSWNwD39s26FGyxBcPgWIptEmmeFnRiTTEeLR1UGnk
 AZJrvsEmqA1VFDqM/b525U/PY7kR8birURb0sU7d9xpl
X-Google-Smtp-Source: APXvYqypt+5+kx/SMQhKJhknfGcewkJ/sqAMn/mUaNx7AgMQGDOazvtz9ovOtW/DjNtepg0akSEyg4j34hPfFvaccgY=
X-Received: by 2002:a1c:f515:: with SMTP id t21mr2329698wmh.39.1560330584463; 
 Wed, 12 Jun 2019 02:09:44 -0700 (PDT)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
 <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:160423
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/160423>

Drew Adams <drew.adams@oracle.com> writes:

> 1. Why is "internal" function `bookmark-set-internal' a _command_
>    (interactive)?  What sense does an "internal" command make?  It seems
>    that the `interactive' spec here was a copy+paste mistake.  It should
>    be removed, I think.
>
> 2. The `interactive' spec for `bookmark-set-internal' seems wrong
>    anyway.  NAME is the raw prefix arg?  And then NAME is simply taken
>    as is (as STR) and compared using `string-equal'?  This cannot be
>    correct.

This has now been fixed.  See bug#36121.

> 6. Error messages, like other messages, should not end with a period.

This too has been fixed.  See bug#35916.

Best regards,
Stefan Kangas