From: Stefan Kangas <stefan@marxist.se>
To: Tom Baker <tombaker17@gmail.com>
Cc: 21652@debbugs.gnu.org
Subject: bug#21652: bell chars
Date: Fri, 14 Aug 2020 23:26:13 -0700 [thread overview]
Message-ID: <CADwFkmnHuzeGANQD0cfXFa4SG0M+mTVj034-+ACxM3ME_v=N7w@mail.gmail.com> (raw)
In-Reply-To: <CAK9k5td5cmpd4WA7Vkd+EkWny+ws_k_rUd-dXctmutZXZZcYYA@mail.gmail.com> (Tom Baker's message of "Thu, 8 Oct 2015 18:55:25 -0400")
Tom Baker <tombaker17@gmail.com> writes:
> I have a real need to have my command shells beep at me when their work is done, so I set it up so beeps are passed to the
> host system.
>
> In the function comint-carriage-motion I alter
>
> (defun comint-carriage-motion (start end)
> "Interpret carriage control characters in the region from START to END.
> Translate carriage return/linefeed sequences to linefeeds.
> Make single carriage returns delete to the beginning of the line.
> Make backspaces delete the previous character."
>
> to say
>
> (defun comint-carriage-motion (start end)
> "Interpret carriage control characters and bells in the region from START to END.
> Translate carriage return/linefeed sequences to linefeeds.
> Make single carriage returns delete to the beginning of the line.
> Make backspaces delete the previous character. Pass bells through."
>
> and the code chunk
>
> (cond ((= ch ?\b) ; CH = BS
> (delete-char 1)
> (if (> (point) lbeg)
> (delete-char -1)))
> ((= ch ?\n)
> (when delete-end ; CH = LF
> (if (< delete-end (point))
> (delete-region lbeg delete-end))
> (set-marker delete-end nil)
> (setq delete-end nil))
> (forward-char 1)
> (setq lbeg (point)))
> (t ; CH = CR
>
> changed to
>
> (cond ((= ch ?\b) ; CH = BS
> (delete-char 1)
> (if (> (point) lbeg)
> (delete-char -1)))
> ((= ch ?\n)
> (when delete-end ; CH = LF
> (if (< delete-end (point))
> (delete-region lbeg delete-end))
> (set-marker delete-end nil)
> (setq delete-end nil))
> (forward-char 1)
> (setq lbeg (point)))
> ((= ch ?\a)
> (forward-char 1)
> (ding)
> (sit-for 0.45 t)) ; CH = BL
> (t ; CH = CR
So the difference here is that you would like to add a call to (ding)?
I'm not sure the addition you propose is suitable for general use.
Perhaps you could explain the use-case here in a bit more detail? For
example, why can't you just add an advice to the function in question?
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-08-15 6:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 22:55 bug#21652: bell chars Tom Baker
2020-08-15 6:26 ` Stefan Kangas [this message]
2020-08-16 1:10 ` Tom Baker
2020-08-16 14:23 ` Stefan Kangas
2020-08-16 14:56 ` Eli Zaretskii
2020-08-16 15:55 ` Tom Baker
2020-08-16 16:34 ` Andreas Schwab
2020-08-16 17:19 ` Tom Baker
2020-08-16 16:39 ` Eli Zaretskii
2020-08-16 17:10 ` Tom Baker
2020-08-16 17:29 ` Eli Zaretskii
2020-08-16 17:51 ` Andreas Schwab
2020-08-16 18:11 ` Eli Zaretskii
2022-03-22 18:15 ` Lars Ingebrigtsen
2020-08-16 16:11 ` Tom Baker
2020-08-16 17:31 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnHuzeGANQD0cfXFa4SG0M+mTVj034-+ACxM3ME_v=N7w@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=21652@debbugs.gnu.org \
--cc=tombaker17@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.