From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36526: 26.2; Open diff at current location (feature request with suggested code) Date: Fri, 13 Sep 2019 13:59:25 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101150"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36526@debbugs.gnu.org To: Campbell Barton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 13 14:00:36 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8kFd-000Q8f-J7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 14:00:33 +0200 Original-Received: from localhost ([::1]:42798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8kFb-0006qY-7f for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 08:00:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50312) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8kFC-0006q8-6b for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 08:00:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8kFA-0002Gz-MA for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 08:00:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8kF8-0002Dy-CW for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 08:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i8kF8-00088B-A0 for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Sep 2019 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36526 X-GNU-PR-Package: emacs Original-Received: via spool by 36526-submit@debbugs.gnu.org id=B36526.156837598431202 (code B ref 36526); Fri, 13 Sep 2019 12:00:02 +0000 Original-Received: (at 36526) by debbugs.gnu.org; 13 Sep 2019 11:59:44 +0000 Original-Received: from localhost ([127.0.0.1]:44473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8kEq-00087C-6s for submit@debbugs.gnu.org; Fri, 13 Sep 2019 07:59:44 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:42887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8kEo-00086z-7V for 36526@debbugs.gnu.org; Fri, 13 Sep 2019 07:59:42 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id z12so3585697pgp.9 for <36526@debbugs.gnu.org>; Fri, 13 Sep 2019 04:59:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IS/cu65GjBmlthRCj682hwlb4zw65Qv5OGN+p8SYiSg=; b=BAqRs35gXMtV9M2wVceQ1ry9Ofcvx5/xES8hjAt3ofARb7NQw6NUqBz0h/KfLT18Sg nNcf9LdxUpAOCkWd7UJfegLi8YHh8P2vY9I4shCRZzQ1cPRmIojVmthSOTAOQvs6UXm3 /YllCKiVUPWse5T2jiLJuIxy+5ZEzKSnBw376s92pwb2d/39quCouWeE5qpDzb/aV4MQ /LtABR6lMwRb8tYU2wAcJN6nLo66075eyYcV9Rfgx6DaOdObyNx0XoB6NzmeOPRkEKLL vLjZLjXXS0FVFZoOCOXatRweSDiboZP0ExYgUuf3l6ah24vzpCy9hsEXXgzC7WXO1rrX TQpQ== X-Gm-Message-State: APjAAAXVT8587NJc5iLIxsz5HPBb1qTU9gm8qp9n8fjWHCpCMzAvaJY7 Tx+wISx53x+C7hAbsAMo/2JpmI9TUrZBEE9lsGA= X-Google-Smtp-Source: APXvYqyr9meya6ckOU2CYPCjc3+ZSkROFxga8kvtfDP0Fhdy75gipHQUxBTEvDKFDC5bfinncBhlLR9HBSyLj1/UFvc= X-Received: by 2002:a63:ef4d:: with SMTP id c13mr6783377pgk.200.1568375976278; Fri, 13 Sep 2019 04:59:36 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166395 Archived-At: Campbell Barton writes: > This is a feature suggestion which I've written example code for > > `vc-root-diff` (or a new function), could jump to the closest line. > > This is useful since you move to the context of the current line. > > I've written code that does this, > it would be useful if it was built into emacs. > > See: https://emacs.stackexchange.com/a/51439/2418 Thanks for the feature suggestion. I haven't looked at your code, but if we decided to use it, it seems like a non-trivial change and would require you to sign copyright papers. You can find more information about copyright assignment here: https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html Would you be willing to do that? If the answer to that is yes, could you please also submit your code as a patch? You can find more information on how to do that in the CONTRIBUTE file in the emacs repository. That would make it easier to review and test your suggested changes. Best regards, Stefan Kangas