From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) Date: Sat, 21 Sep 2024 17:59:08 -0700 Message-ID: References: <172663360099.23732.9998257239822693024@vcs2.savannah.gnu.org> <20240918042641.56C7BC410E2@vcs2.savannah.gnu.org> <87v7yt322l.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 22 03:00:30 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssAxh-0003s7-Bk for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Sep 2024 03:00:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssAwa-0000Re-FE; Sat, 21 Sep 2024 20:59:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssAwV-0000RP-3o for emacs-devel@gnu.org; Sat, 21 Sep 2024 20:59:16 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssAwT-0003a4-IW for emacs-devel@gnu.org; Sat, 21 Sep 2024 20:59:14 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5c50ea4419dso1654039a12.0 for ; Sat, 21 Sep 2024 17:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726966749; x=1727571549; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=0f3G0v2quAVumi+2Hu/oZCawKiFT3myF2L2qsmSq8zs=; b=FifKmeSGdCn7k4PkBSdGxE4uFBxZ/KRUPlsZyiuvyK5m6zs1ZPs7jesYa5xLxdzb3w r+iQL01GlFekdjhY8Lgg3SaVA80pvX5GtOCf/snu7CC+kzAF3sQjPXbWsM2svtxep9+g DsrNo8r7844KmlZSS/M5gjREpIpyAoqIpsy9a25uTSE/Cb0+HXUHeY5AOScXHn+mB3m2 gWkLIclVKS/EHZoyapYVGs6NAESPHR3TvP2UtXRYJsD3LiM057n5/2kekNA5NNKzuVqA X3NzqImIjaU5ZyVz+mkD+MkgwZOaaj1UpE+bPmOCEDVocFbjTcSAR1iacs6h9km7eQco sMCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726966749; x=1727571549; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0f3G0v2quAVumi+2Hu/oZCawKiFT3myF2L2qsmSq8zs=; b=EkgLSE24K/7divMdiMcQwOySDpxMh9CyswuT3yj189tsCUScpkPBhgUBAn9c5l1UEj I6+oOr+U5aiUCLnL5Y//+gw6dsp2NKa4BmYbTGY43O2Hoimqpky0OJRmZ2tOO0B23vQr Iy5SoIv4TsXRnTkeWnNWGUw8FU6PNNTTN360ceh7t8hSft6qbNRfv4t7dKskJXt3Q553 BDyO+89ssc2wVWo30Vo/wP8YmSlVSBqCicooyl7zf7FvBVd1mARN9ia7Q0jas6IvH285 U4PcADKVV4NnG9kFOO5cBfXVVZzpJC0pZ3UjspwvXq53CznUiTC2WkSUSAWWYIvQz2hv 4v7A== X-Forwarded-Encrypted: i=1; AJvYcCW/bWDuXMCsFXv82anSopemV1sVgM13KEb1fzWx4vMd69+kMUor6+MKjvpP5mxozcdsY1vhSJF6/LKI4w==@gnu.org X-Gm-Message-State: AOJu0YwCDZ4M4vWgwqXi+ytTRSdUpj1ez6pGF7NCRFUaYbtuqylJeKuL j2lDE6QZzlOPgHccdjYS54bHYv0OAJVufwbZw/zQ+wFe26A6GhMYboASZd7pEqG9ki6ckecGazD ejJH39HwUN5NVlDV4nRi1J1lMp1c= X-Google-Smtp-Source: AGHT+IG7GQI9ynf4pe11ytBBkzhKmUJMVQv2J/d/TlNnv83a0sqwgW0gMP6LPMFqWRkTkHhaASnTwY//c9/W8OxD21Y= X-Received: by 2002:a05:6402:d0e:b0:5c2:7699:fb6f with SMTP id 4fb4d7f45d1cf-5c464dba943mr6111923a12.15.1726966749274; Sat, 21 Sep 2024 17:59:09 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 21 Sep 2024 17:59:08 -0700 In-Reply-To: <87v7yt322l.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323905 Archived-At: Po Lu writes: > Yuan Fu writes: > >> branch: emacs-30 >> commit f0daa2f2153a9d250d32ac1261a6fffb30860e31 >> Author: Yuan Fu >> Commit: Yuan Fu >> >> Conservative heuristic for tree-sitter parser ranges (bug#73324) >> >> * src/treesit.c (treesit_sync_visible_region): If the parser's original >> ranges don't overlap with visible region, give it a zero range, rather >> than don't set any range. >> * test/src/treesit-tests.el (treesit-range-fixup-after-edit): Test new >> behavior. > > Please fill ChangeLog entries in commit messages to a width of 64 > columns, not 71 or 72, as here. I don't want to get into another argument about this, but I don't see any problem with the above formatting, FWIW. In any case, I really don't think it is a good use of our time to police the recently introduced default of 64 columns here. We never did that before, when the default in `vc-git-log-edit-mode' was 70 characters, and there is no reason to start doing it now.