From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: New library wallpaper.el pushed to master Date: Wed, 14 Sep 2022 07:52:39 -0400 Message-ID: References: <878rmm1xmx.fsf@yahoo.com> <87zgf2zcgd.fsf@yahoo.com> <83mtb22ni6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3751"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 14 14:54:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYRuT-0000lK-EE for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 14:54:33 +0200 Original-Received: from localhost ([::1]:52642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYRuS-00049B-DA for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 08:54:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYQwi-0000ko-3k for emacs-devel@gnu.org; Wed, 14 Sep 2022 07:52:53 -0400 Original-Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:42755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYQwb-00009f-To; Wed, 14 Sep 2022 07:52:47 -0400 Original-Received: by mail-ot1-x32d.google.com with SMTP id h9-20020a9d5549000000b0063727299bb4so10137923oti.9; Wed, 14 Sep 2022 04:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date; bh=EOv0cSQr6MYjRWKVqRSEXZpqpuongO0qa0IOa5a6/tk=; b=D7sNMuTokjJTnkG7Ee6g14K+rMlkAITaUaKTiot1Sk3s58+rF+foSlQRjFIsBQEoiZ vryQql+zyYyKtsSnmU3n4o35VAPgMfnIhn0W8VMm2FA7lBOF2vCbhtxBNUfZ5/CJerM2 bGWgakoYCxnZqnBbPlMWKJSZKbHV1y8Jr6pFebePpGZDbRVuv3mssRkCJeY8KheSeLnO Qdj7+0PUKzObAlhWroL7I0c+ILmM/Yq4/HxzICpo7NhsjX4JWDIPjN3QUfRuWWe3i43j mhg15Fe1bJ2q4UdYzNnJodPNH/eZXeRpScOHvQmMxODZEwuNuLlMgkWLxu4M1tLCy88y PBtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date; bh=EOv0cSQr6MYjRWKVqRSEXZpqpuongO0qa0IOa5a6/tk=; b=YaKIgVByLwUzuVz1heM6jPBXfwdecmX/Pn6lCbNZRH2x5ug7X3nXxZd3q6PNgPZ6IJ D+EpR6iZDWqA8aw3BFyopfucOGKKdkDzolptrCqCdFwi5DmxHOH0//016kk1Ew4YqApM COCNSyCmu9x2K2yE/41pPR4k5/kVKLLNpXvfIbehjIAlhV5J78qNHoKIAo7TF3AIL18U j2k9Rl7ELu/U4bUriEuFUBHP37Im9wolZSW99eQZkl6s4Q3oT5RdNUwZkgEwDdK1YHJK VH7c4GRxuA9TOAYj+1RUyB51VCgcIYSGd8R3L4HOvRYGNHOvEwUkPiuip2YmIEdPopnY veqg== X-Gm-Message-State: ACgBeo2mau4D1T8TS5XiVlDUDFTW6YfveYhH9hJlTqdGo20F02YyRshX j8S21qyken+yOoLx2DfaGaeM/XPxCZ7xXRNZ107kNYZv X-Google-Smtp-Source: AA6agR7JBnxRgMtXh0jo8H2hlOkF3oveDNenjaLm0SR6wIHimFvCVAwitW/dC8Sna70zAJKPXLfR+hRhVVcDRd3bok8= X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr5839513otn.224.1663156360341; Wed, 14 Sep 2022 04:52:40 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 14 Sep 2022 07:52:39 -0400 In-Reply-To: <83mtb22ni6.fsf@gnu.org> X-Hashcash: 1:20:220914:eliz@gnu.org::pb9sQNNsKhCsoEWX:1ntc Received-SPF: pass client-ip=2607:f8b0:4864:20::32d; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295312 Archived-At: Eli Zaretskii writes: >> BTW, what about actions usually taken to modify the wallpaper such as >> scaling, cropping, and offsets? Shouldn't wallpaper-set take several >> arguments to specify those? > > No, I think it should just use the image. If the user wants to modify > the image, he/she can do that using "other means", including the > lately introduced 'image-crop' command. There's no reason to make > this simple facility understand too much about images and their > formats. I guess what Po Lu had in mind was supporting options such as the following, from the "feh" man page: --bg-center Center the file on the background. If it is too small, it will be surrounded by a border as specified by --image-bg. --bg-fill Like --bg-scale, but preserves aspect ratio by zooming the image until it fits. Either a horizontal or a vertical part of the im= =E2=80=90 age will be cut off --bg-max Like --bg-fill, but scale the image to the maximum size that fits the screen with borders on one side. The border color can be set using --image-bg. --bg-scale Fit the file into the background without repeating it, cutting off stuff or using borders. But the aspect ratio is not pre=E2= =80=90 served either --bg-tile Tile (repeat) the image in case it is too small for the screen I think it would be worthwhile to add some defcustoms for this, as this is likely to be something that users will commonly want to customize. But I agree with Po Lu that we should try to make this transparent with regards to the tool. Perhaps we could add a `wallpaper-default-method' option with values like `center', `fill', `max', `scale', and `tile'.