From: Stefan Kangas <stefankangas@gmail.com>
To: Niall Dooley <dooleyn@gmail.com>, 67441@debbugs.gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: bug#67441: [PATCH] eglot: Add ruff-lsp as an alternative python server
Date: Thu, 14 Dec 2023 17:22:29 -0800 [thread overview]
Message-ID: <CADwFkmnEf6irDR_yHoi3k5t5s4WZgVwCq9GTqb7izjHP1K1Gvw@mail.gmail.com> (raw)
In-Reply-To: <20231124155236.49559-1-dooleyn@gmail.com>
Niall Dooley <dooleyn@gmail.com> writes:
> ruff-lsp [1] is a Language Server Protocol implementation for Ruff [2,
> 3], an extremely fast Python linter and code formatter, written in
> Rust.
>
> It supports surfacing Ruff diagnostics and providing Code Actions to
> fix them, but is intended to be used alongside another Python LSP in
> order to support features like navigation and autocompletion.
>
> [1]: https://github.com/astral-sh/ruff-lsp
> [2]: https://github.com/astral-sh/ruff
> [3]: https://docs.astral.sh/ruff/
João, any comments here? Does eglot support running more than one LSP
server at the same time?
AFAICT, pylsp (for example) has built-in support for ruff, so while I'm
sure there's a use case for ruff-lsp, I don't think I currently
understand it.
In any case, I think the patch seems harmless enough, and could probably
be installed as-is.
> ---
> lisp/progmodes/eglot.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 48ea33c3ee1..d7d91bddb01 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -216,7 +216,7 @@ chosen (interactively or automatically)."
> (vimrc-mode . ("vim-language-server" "--stdio"))
> ((python-mode python-ts-mode)
> . ,(eglot-alternatives
> - '("pylsp" "pyls" ("pyright-langserver" "--stdio") "jedi-language-server")))
> + '("pylsp" "pyls" ("pyright-langserver" "--stdio") "jedi-language-server" "ruff-lsp")))
> ((js-json-mode json-mode json-ts-mode)
> . ,(eglot-alternatives '(("vscode-json-language-server" "--stdio")
> ("vscode-json-languageserver" "--stdio")
> --
> 2.30.2
next prev parent reply other threads:[~2023-12-15 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 15:52 bug#67441: [PATCH] eglot: Add ruff-lsp as an alternative python server Niall Dooley
2023-12-15 1:22 ` Stefan Kangas [this message]
2023-12-15 1:29 ` João Távora
2023-12-16 11:12 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnEf6irDR_yHoi3k5t5s4WZgVwCq9GTqb7izjHP1K1Gvw@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=67441@debbugs.gnu.org \
--cc=dooleyn@gmail.com \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.