From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57691@debbugs.gnu.org
Subject: bug#57691: 29.0.50; image-tests failures
Date: Fri, 9 Sep 2022 18:37:20 -0400 [thread overview]
Message-ID: <CADwFkmnDgH-TuStU0WGLMuRScTCWy2YRMH_5zuOf=DeXQObzCA@mail.gmail.com> (raw)
In-Reply-To: <83czc4d7up.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> What does that test check? why does it want to see the delay?
It used to just check that no metadata was returned for these images.
Then Lars changed the GIF and WebP loading code to always add a `delay',
so I adapted the tests to that.
(More work is needed to make these tests check for more substantial
things. See the TODO where I say that we could expand them to test
using files that actually do contain metadata.)
> The native APIs support animated GIFs better than with libgif, so
> artificially making changes of the delay for the single benefit of
> running this test is not the best idea, IMO.
Gotcha. So it sounds like we should leave that alone, and adapt the
test to Windows instead.
Does the below workaround make sense? That way, at least we test
something.
diff --git a/test/manual/image-tests.el b/test/manual/image-tests.el
index c66080cf02..4b1b122309 100644
--- a/test/manual/image-tests.el
+++ b/test/manual/image-tests.el
@@ -220,11 +220,13 @@ image-tests-image-mask-p/error-on-invalid-spec
;; TODO: These tests could be expanded with files that actually
;; contain metadata.
+(defvar w32-use-native-image-API)
(ert-deftest image-tests-image-metadata/gif ()
(image-skip-unless 'gif)
- (should (memq 'delay
- (image-metadata
- (create-image (cdr (assq 'gif image-tests--images)))))))
+ (let ((w32-use-native-image-API nil))
+ (should (memq 'delay
+ (image-metadata
+ (create-image (cdr (assq 'gif image-tests--images))))))))
(ert-deftest image-tests-image-metadata/jpeg ()
(image-skip-unless 'jpeg)
next prev parent reply other threads:[~2022-09-09 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 6:26 bug#57691: 29.0.50; image-tests failures Eli Zaretskii
2022-09-09 9:03 ` Stefan Kangas
2022-09-09 11:51 ` Eli Zaretskii
2022-09-09 12:44 ` Stefan Kangas
2022-09-09 12:56 ` Eli Zaretskii
2022-09-09 22:37 ` Stefan Kangas [this message]
2022-09-10 6:07 ` Eli Zaretskii
2022-09-12 13:23 ` Stefan Kangas
2022-09-12 16:00 ` Eli Zaretskii
2022-09-13 9:40 ` Stefan Kangas
2022-09-13 12:05 ` Eli Zaretskii
2022-09-09 12:44 ` Stefan Kangas
2022-09-09 12:57 ` Eli Zaretskii
2022-09-09 22:37 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnDgH-TuStU0WGLMuRScTCWy2YRMH_5zuOf=DeXQObzCA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=57691@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.